From patchwork Wed Apr 6 12:44:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1613946 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=JqF9lic0; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KYPNw5Vsfz9sFr for ; Wed, 6 Apr 2022 22:45:03 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6427F385DC31 for ; Wed, 6 Apr 2022 12:45:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6427F385DC31 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1649249100; bh=mJ3bEpdnKKuyyt33NFzdvFh2fJ1iSbKvDDWwV2D2wCg=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=JqF9lic0ZqMAZkznSWJRgmqlrk/u10ZPGSqg829PoVZ2wYp1eIE/1S8Xsf6Xeqydb kID/wsTPFcJ3Db0MqNgdb1EJ1XkM9OZZtT9inORXctRd5Stkt9kfRZOtFPbQfRR46L e+cAD/RQd792biPUiNM3zfGGjg7i/JNQv2xE6uqE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 106B3385840C for ; Wed, 6 Apr 2022 12:44:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 106B3385840C Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C8748210E4; Wed, 6 Apr 2022 12:44:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B089F13A8E; Wed, 6 Apr 2022 12:44:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xYn4KTeLTWIQawAAMHmgww (envelope-from ); Wed, 06 Apr 2022 12:44:39 +0000 Date: Wed, 6 Apr 2022 14:44:38 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/105165 - sorry instead of ICE for _Complex asm goto MIME-Version: 1.0 Message-Id: <20220406124439.B089F13A8E@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Cc: Jakub Jelinek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Complex lowering cannot currently deal with asm gotos with _Complex output operands. Emit a sorry instead of ICEing, those should not appear in practice. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk and branch? Thanks, Richard. 2022-04-06 Richard Biener PR middle-end/105165 * tree-complex.cc (expand_complex_asm): Sorry for asm goto _Complex outputs. * gcc.dg/pr105165.c: New testcase. --- gcc/testsuite/gcc.dg/pr105165.c | 13 +++++++++++++ gcc/tree-complex.cc | 16 ++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/pr105165.c diff --git a/gcc/testsuite/gcc.dg/pr105165.c b/gcc/testsuite/gcc.dg/pr105165.c new file mode 100644 index 00000000000..055a10528b5 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr105165.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-O" } */ + +unsigned int _Complex a0; +unsigned int _Complex +foo (unsigned int _Complex a1, unsigned int _Complex a2) +{ + unsigned int _Complex x; + asm goto ("" : "=r" (x) : : : lab); /* { dg-message "sorry, unimplemented" } */ + a0 = x; + lab: + return x + a1 + a2 + 1; +} diff --git a/gcc/tree-complex.cc b/gcc/tree-complex.cc index 8f03b236094..42db96a132b 100644 --- a/gcc/tree-complex.cc +++ b/gcc/tree-complex.cc @@ -41,6 +41,7 @@ along with GCC; see the file COPYING3. If not see #include "cfgloop.h" #include "cfganal.h" #include "gimple-fold.h" +#include "diagnostic-core.h" /* For each complex ssa name, a lattice value. We're interested in finding @@ -1614,6 +1615,7 @@ expand_complex_asm (gimple_stmt_iterator *gsi) { gasm *stmt = as_a (gsi_stmt (*gsi)); unsigned int i; + bool diagnosed_p = false; for (i = 0; i < gimple_asm_noutputs (stmt); ++i) { @@ -1622,6 +1624,20 @@ expand_complex_asm (gimple_stmt_iterator *gsi) if (TREE_CODE (op) == SSA_NAME && TREE_CODE (TREE_TYPE (op)) == COMPLEX_TYPE) { + if (gimple_asm_nlabels (stmt) > 0) + { + if (!diagnosed_p) + { + sorry_at (gimple_location (stmt), + "% with complex typed outputs"); + diagnosed_p = true; + } + /* Make sure to not ICE later, see PR105165. */ + tree zero = build_zero_cst (TREE_TYPE (TREE_TYPE (op))); + set_component_ssa_name (op, false, zero); + set_component_ssa_name (op, true, zero); + continue; + } tree type = TREE_TYPE (op); tree inner_type = TREE_TYPE (type); tree r = build1 (REALPART_EXPR, inner_type, op);