diff mbox series

PR target/93995 ICE in patch_jump_insn, at cfgrtl.c:1290 on riscv64-linux-gnu

Message ID 20200303080337.43192-1-kito.cheng@sifive.com
State New
Headers show
Series PR target/93995 ICE in patch_jump_insn, at cfgrtl.c:1290 on riscv64-linux-gnu | expand

Commit Message

Kito Cheng March 3, 2020, 8:03 a.m. UTC 
Last code gen change of LTGT didn't consider the situation of cbranch with LTGT,
branch only support few compare codes.

gcc/ChangeLog

	* config/riscv/riscv.c (riscv_emit_float_compare): Using NE to compare
	the result of IOR.

gcc/testsuite/ChangeLog

	* gcc.dg/pr93995.c: New.
---
 gcc/config/riscv/riscv.c       |  7 +++---
 gcc/testsuite/gcc.dg/pr93995.c | 46 ++++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+), 3 deletions(-)
 create mode 100644 gcc/testsuite/gcc.dg/pr93995.c

Comments

Jim Wilson March 3, 2020, 10:23 p.m. UTC | #1 
On Tue, Mar 3, 2020 at 12:03 AM Kito Cheng <kito.cheng@sifive.com> wrote:
> gcc/ChangeLog
>         * config/riscv/riscv.c (riscv_emit_float_compare): Using NE to compare
>         the result of IOR.
>
> gcc/testsuite/ChangeLog
>         * gcc.dg/pr93995.c: New.

Thanks.  This looks good to me.

Jim
Kito Cheng March 4, 2020, 6:20 a.m. UTC | #2 
Committed, thanks :)


On Wed, Mar 4, 2020 at 6:23 AM Jim Wilson <jimw@sifive.com> wrote:
>
> On Tue, Mar 3, 2020 at 12:03 AM Kito Cheng <kito.cheng@sifive.com> wrote:
> > gcc/ChangeLog
> >         * config/riscv/riscv.c (riscv_emit_float_compare): Using NE to compare
> >         the result of IOR.
> >
> > gcc/testsuite/ChangeLog
> >         * gcc.dg/pr93995.c: New.
>
> Thanks.  This looks good to me.
>
> Jim
diff mbox series

Patch

diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c
index d45b19d861b..94b5ac01762 100644
--- a/gcc/config/riscv/riscv.c
+++ b/gcc/config/riscv/riscv.c
@@ -2299,9 +2299,10 @@  riscv_emit_float_compare (enum rtx_code *code, rtx *op0, rtx *op1)
 
     case LTGT:
       /* (a < b) | (a > b) */
-      *code = IOR;
-      *op0 = riscv_force_binary (word_mode, LT, cmp_op0, cmp_op1);
-      *op1 = riscv_force_binary (word_mode, GT, cmp_op0, cmp_op1);
+      tmp0 = riscv_force_binary (word_mode, LT, cmp_op0, cmp_op1);
+      tmp1 = riscv_force_binary (word_mode, GT, cmp_op0, cmp_op1);
+      *op0 = riscv_force_binary (word_mode, IOR, tmp0, tmp1);
+      *op1 = const0_rtx;
       break;
 
     default:
diff --git a/gcc/testsuite/gcc.dg/pr93995.c b/gcc/testsuite/gcc.dg/pr93995.c
new file mode 100644
index 00000000000..b89c85db10a
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr93995.c
@@ -0,0 +1,46 @@ 
+/* PR target/93995 */
+/* { dg-do run } */
+/* { dg-options "-O2 -fno-trapping-math" } */
+
+double s1[4], s2[4], s3[64];
+
+int
+main (void)
+{
+  int i;
+  asm volatile ("" : : : "memory");
+  for (i = 0; i < 4; i++)
+    s3[0 * 4 + i] = __builtin_isgreater (s1[i], s2[i]) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[1 * 4 + i] = (!__builtin_isgreater (s1[i], s2[i])) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[2 * 4 + i] = __builtin_isgreaterequal (s1[i], s2[i]) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[3 * 4 + i] = (!__builtin_isgreaterequal (s1[i], s2[i])) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[4 * 4 + i] = __builtin_isless (s1[i], s2[i]) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[5 * 4 + i] = (!__builtin_isless (s1[i], s2[i])) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[6 * 4 + i] = __builtin_islessequal (s1[i], s2[i]) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[7 * 4 + i] = (!__builtin_islessequal (s1[i], s2[i])) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[8 * 4 + i] = __builtin_islessgreater (s1[i], s2[i]) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[9 * 4 + i] = (!__builtin_islessgreater (s1[i], s2[i])) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[10 * 4 + i] = __builtin_isunordered (s1[i], s2[i]) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[11 * 4 + i] = (!__builtin_isunordered (s1[i], s2[i])) ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[12 * 4 + i] = s1[i] > s2[i] ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[13 * 4 + i] = s1[i] >= s2[i] ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[14 * 4 + i] = s1[i] < s2[i] ? -1.0 : 0.0;
+  for (i = 0; i < 4; i++)
+    s3[15 * 4 + i] = s1[i] <= s2[i] ? -1.0 : 0.0;
+  asm volatile ("" : : : "memory");
+  return 0;
+}