| Message ID | 20131119074431.GM892@tucnak.redhat.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Nov 18, 2013 at 11:44 PM, Jakub Jelinek <jakub@redhat.com> wrote: > On Tue, Nov 19, 2013 at 05:32:12PM +1030, Alan Modra wrote: >> On Tue, Nov 19, 2013 at 06:17:41AM +0100, Hans-Peter Nilsson wrote: >> > In file included from /tmp/x/gcc/libbacktrace/atomic.c:37: >> > /tmp/x/gcc/libbacktrace/internal.h:182: error: expected declaration specifiers or '...' before 'off_t' >> > make[3]: *** [atomic.lo] Error 1 >> > >> > brgds, H-P >> > PS. Host is Fedora 12, x86_64. >> >> Likewise on powerpc-linux. Fixed here by #include <sys/types.h> in >> atomic.c. > > Given: > /* We assume that <sys/types.h> and "backtrace.h" have already been > included. */ > comment at the start of internal.h, I've committed following fix as obvious. > All other libbacktrace source files that include internal.h include both > sys/types.h and backtrace.h before internal.h. > > 2013-11-19 Jakub Jelinek <jakub@redhat.com> > > * atomic.c: Include sys/types.h. Thanks. My apologies for the breakage. I thought I explicitly tested that case, but evidently I somehow messed up. Ian
--- libbacktrace/atomic.c.jj 2013-11-19 08:35:09.000000000 +0100 +++ libbacktrace/atomic.c 2013-11-19 08:42:15.390239574 +0100 @@ -32,6 +32,8 @@ POSSIBILITY OF SUCH DAMAGE. */ #include "config.h" +#include <sys/types.h> + #include "backtrace.h" #include "backtrace-supported.h" #include "internal.h"