From patchwork Tue Nov 19 07:44:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 292313 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B23A32C00C2 for ; Tue, 19 Nov 2013 18:45:00 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=V4oSl3oywS1mVr5L/ E3DV5PLjXSDXv8ejdKXzNpMQuOcYuL/bw/1WBKtmwQ6C0s7c9PrAW2t+zAbf9yCz UH3bpVRI+LhpRoSSoEnSXW2Qj+dWHW2Ihj1EYYvwgEQNdYQTIdJnFuXTUXtooG69 1fWpNTnk6OBbcko7V5fVn1Wi7k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; s=default; bh=tOdg2vqMYPnumN0YCtz7wDo 8qXs=; b=WUODibg/ItzPP/4unhLu38UC5TDcGzb1D0iKBJs7Yqm0wF/8m3fmhvl v2kBJa8S7Gr58hGweK8YtAdNvn/VEokto+/RR/vZj8slLhTlXtJIP9uzO4OXLWNF HRPCG1K4/YU+nLCq8hbj4C5bi95tCE3cakX8zoov7d5e8nk3fRO0= Received: (qmail 16667 invoked by alias); 19 Nov 2013 07:44:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 16657 invoked by uid 89); 19 Nov 2013 07:44:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_50, RDNS_NONE, SPF_HELO_PASS, SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2013 07:44:49 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJ7iaMN011387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 19 Nov 2013 02:44:36 -0500 Received: from tucnak.zalov.cz (vpn1-5-186.ams2.redhat.com [10.36.5.186]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAJ7iYt7009703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Nov 2013 02:44:35 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.7/8.14.7) with ESMTP id rAJ7iX1u017101; Tue, 19 Nov 2013 08:44:33 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.7/8.14.7/Submit) id rAJ7iWVF017100; Tue, 19 Nov 2013 08:44:32 +0100 Date: Tue, 19 Nov 2013 08:44:32 +0100 From: Jakub Jelinek To: Hans-Peter Nilsson , iant@google.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer Message-ID: <20131119074431.GM892@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <201311190517.rAJ5Hfvd024907@ignucius.se.axis.com> <20131119070212.GC22514@bubble.grove.modra.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131119070212.GC22514@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes On Tue, Nov 19, 2013 at 05:32:12PM +1030, Alan Modra wrote: > On Tue, Nov 19, 2013 at 06:17:41AM +0100, Hans-Peter Nilsson wrote: > > In file included from /tmp/x/gcc/libbacktrace/atomic.c:37: > > /tmp/x/gcc/libbacktrace/internal.h:182: error: expected declaration specifiers or '...' before 'off_t' > > make[3]: *** [atomic.lo] Error 1 > > > > brgds, H-P > > PS. Host is Fedora 12, x86_64. > > Likewise on powerpc-linux. Fixed here by #include in > atomic.c. Given: /* We assume that and "backtrace.h" have already been included. */ comment at the start of internal.h, I've committed following fix as obvious. All other libbacktrace source files that include internal.h include both sys/types.h and backtrace.h before internal.h. 2013-11-19 Jakub Jelinek * atomic.c: Include sys/types.h. Jakub --- libbacktrace/atomic.c.jj 2013-11-19 08:35:09.000000000 +0100 +++ libbacktrace/atomic.c 2013-11-19 08:42:15.390239574 +0100 @@ -32,6 +32,8 @@ POSSIBILITY OF SUCH DAMAGE. */ #include "config.h" +#include + #include "backtrace.h" #include "backtrace-supported.h" #include "internal.h"