| Message ID | 20231230-support-clearfog-gtr-l8-sfp-v4-2-1d7f0e2c7128@solid-run.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 30/12/2023 16:44, Josua Mayer wrote: > Convert the existing txt binding for armada-38x socs to DT schema > format. > Where is the conversion? I don't see. Conversion means "remove and add" in a diff. I see only second part. > Note that the current bindings only document the SoC (armada380, > armada385, armada388). This is undesirable, instead there should be > entries for actual boards. > > For now only convert to yaml, the content can be corrected separately. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > .../bindings/arm/marvell/armada-38x.yaml | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > new file mode 100644 > index 000000000000..5af222e6db18 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell Armada 38x Platforms > + > +maintainers: > + - Gregory CLEMENT <gregory.clement@bootlin.com> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + > + - description: Armada 380 SoC > + items: > + - const: marvell,armada380 > + > + - description: Armada 385 SoC > + items: > + - const: marvell,armada385 > + - const: marvell,armada380 > + No, we have been here. NAK. Best regards, Krzysztof
Am 04.01.24 um 09:39 schrieb Krzysztof Kozlowski: > On 30/12/2023 16:44, Josua Mayer wrote: >> Convert the existing txt binding for armada-38x socs to DT schema >> format. >> > Where is the conversion? I don't see. Conversion means "remove and add" > in a diff. I see only second part. > > + - description: Armada 385 SoC > + items: > + - const: marvell,armada385 > + - const: marvell,armada380 > + > No, we have been here. > > NAK. I had intended to drop this patch, I should have seen it looking at draft before sending .... . I will do as you requested first: convert and add some valid boards in one step. Sincerely Josua Mayer
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file mode 100644 index 000000000000..5af222e6db18 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml @@ -0,0 +1,33 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Marvell Armada 38x Platforms + +maintainers: + - Gregory CLEMENT <gregory.clement@bootlin.com> + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Armada 380 SoC + items: + - const: marvell,armada380 + + - description: Armada 385 SoC + items: + - const: marvell,armada385 + - const: marvell,armada380 + + - description: Armada 388 SoC + items: + - const: marvell,armada388 + - const: marvell,armada385 + - const: marvell,armada380 + +additionalProperties: true
Convert the existing txt binding for armada-38x socs to DT schema format. Note that the current bindings only document the SoC (armada380, armada385, armada388). This is undesirable, instead there should be entries for actual boards. For now only convert to yaml, the content can be corrected separately. Signed-off-by: Josua Mayer <josua@solid-run.com> --- .../bindings/arm/marvell/armada-38x.yaml | 33 ++++++++++++++++++++++ 1 file changed, 33 insertions(+)