| Message ID | 20231230-support-clearfog-gtr-l8-sfp-v4-1-1d7f0e2c7128@solid-run.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 0 lines checked |
| robh/patch-applied | success |
On 30/12/2023 16:44, Josua Mayer wrote: > The current bindings documentation for armada-38x are only listing SoCs, > but no actual boards. Only actual boards should be listed. > > Delete this invalid binding document. > > Conversion to a boilerplate yaml has been considered but is not useful. > A new bindings documentation in yaml format can be introduced with new > bindings for specific boards. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > .../devicetree/bindings/arm/marvell/armada-38x.txt | 27 ---- I asked you what to do in one step. Don't break steps into multiple steps. This should be squashed. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.txt b/Documentation/devicetree/bindings/arm/marvell/armada-38x.txt deleted file mode 100644 index 202953f1887e..000000000000 --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.txt +++ /dev/null @@ -1,27 +0,0 @@ -Marvell Armada 38x Platforms Device Tree Bindings -------------------------------------------------- - -Boards with a SoC of the Marvell Armada 38x family shall have the -following property: - -Required root node property: - - - compatible: must contain "marvell,armada380" - -In addition, boards using the Marvell Armada 385 SoC shall have the -following property before the previous one: - -Required root node property: - -compatible: must contain "marvell,armada385" - -In addition, boards using the Marvell Armada 388 SoC shall have the -following property before the previous one: - -Required root node property: - -compatible: must contain "marvell,armada388" - -Example: - -compatible = "marvell,a385-rd", "marvell,armada385", "marvell,armada380";
The current bindings documentation for armada-38x are only listing SoCs, but no actual boards. Only actual boards should be listed. Delete this invalid binding document. Conversion to a boilerplate yaml has been considered but is not useful. A new bindings documentation in yaml format can be introduced with new bindings for specific boards. Signed-off-by: Josua Mayer <josua@solid-run.com> --- .../devicetree/bindings/arm/marvell/armada-38x.txt | 27 ---------------------- 1 file changed, 27 deletions(-)