| Message ID | 20231124-ltc4282-support-v2-1-952bf926f83c@analog.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for LTC4282 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, Nov 24, 2023 at 03:18:16PM +0100, Nuno Sa via B4 Relay wrote: > + adi,gpio1-mode: > + description: Defines the function of the Pin. > + $ref: /schemas/types.yaml#/definitions/string > + enum: [gpio, power_bad, power_good] > + > + adi,gpio2-mode: > + description: Defines the function of the Pin. > + 0 - GPIO Mode. > + 1 - Acts as an input pin and it is feeded into the ADC. > + 2 - Pulls Low when the MOSFET is dissipating power (stress). These three descriptions here probably need to be updated, one for being too short and these two for still having the integer stuff in the descriptions. Otherwise I think this is looking okay. Cheers, Conor. > + $ref: /schemas/types.yaml#/definitions/string > + enum: [gpio, adc_input, stress_fet] > + > + adi,gpio3-mode: > + description: Defines the function of the Pin. > + 0 - GPIO Mode. > + 1 - Acts as an input pin and it is feeded into the ADC. > + $ref: /schemas/types.yaml#/definitions/string > + enum: [gpio, adc_input]
On Sat, 2023-11-25 at 11:56 +0000, Conor Dooley wrote: > On Fri, Nov 24, 2023 at 03:18:16PM +0100, Nuno Sa via B4 Relay wrote: > > > + adi,gpio1-mode: > > + description: Defines the function of the Pin. > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [gpio, power_bad, power_good] > > + > > + adi,gpio2-mode: > > + description: Defines the function of the Pin. > > + 0 - GPIO Mode. > > + 1 - Acts as an input pin and it is feeded into the ADC. > > + 2 - Pulls Low when the MOSFET is dissipating power (stress). > > These three descriptions here probably need to be updated, one for being > too short and these two for still having the integer stuff in the > descriptions. Otherwise I think this is looking okay. > Yeah, the integer stuff are leftovers. I can also try to add more into the description. - Nuno Sá >
On Mon, Nov 27, 2023 at 08:56:36AM +0100, Nuno Sá wrote: > On Sat, 2023-11-25 at 11:56 +0000, Conor Dooley wrote: > > On Fri, Nov 24, 2023 at 03:18:16PM +0100, Nuno Sa via B4 Relay wrote: > > > > > + adi,gpio1-mode: > > > + description: Defines the function of the Pin. > > > + $ref: /schemas/types.yaml#/definitions/string > > > + enum: [gpio, power_bad, power_good] > > > + > > > + adi,gpio2-mode: > > > + description: Defines the function of the Pin. > > > + 0 - GPIO Mode. > > > + 1 - Acts as an input pin and it is feeded into the ADC. > > > + 2 - Pulls Low when the MOSFET is dissipating power (stress). > > > > These three descriptions here probably need to be updated, one for being > > too short and these two for still having the integer stuff in the > > descriptions. Otherwise I think this is looking okay. > > > > Yeah, the integer stuff are leftovers. I can also try to add more into the > description. That'd be great, thanks.
On Fri, Nov 24, 2023 at 03:18:16PM +0100, Nuno Sa wrote: > Add bindings for the LTC4282 High Current Hot Swap Controller with I2C > Compatible Monitoring. > > Signed-off-by: Nuno Sa <nuno.sa@analog.com> > --- > .../devicetree/bindings/hwmon/adi,ltc4282.yaml | 206 +++++++++++++++++++++ > MAINTAINERS | 6 + > 2 files changed, 212 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml > new file mode 100644 > index 000000000000..6c979f70687e > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml > @@ -0,0 +1,206 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/adi,ltc4282.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices LTC4282 I2C High Current Hot Swap Controller over I2C > + > +maintainers: > + - Nuno Sa <nuno.sa@analog.com> > + > +description: | > + Analog Devices LTC4282 I2C High Current Hot Swap Controller over I2C. > + > + https://www.analog.com/media/en/technical-documentation/data-sheets/ltc4282.pdf > + > +properties: > + compatible: > + enum: > + - adi,ltc4282 > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + > + clocks: > + maxItems: 1 > + > + '#clock-cells': > + const: 0 > + > + adi,rsense-nano-ohms: > + description: Value of the sense resistor. > + > + adi,vin-mode-microvolt: > + description: > + Selects operating range for the Undervoltage, Overvoltage and Foldback > + pins. Also for the ADC. Should be set to the nominal input voltage. > + enum: [3300000, 5000000, 12000000, 24000000] > + default: 12000000 > + > + adi,fet-bad-timeout-ms: > + description: > + From the moment a FET bad conditions is present, this property selects the > + wait time/timeout for a FET-bad fault to be signaled. Setting this to 0, > + disables FET bad faults to be reported. > + default: 255 > + maximum: 255 > + > + adi,overvoltage-dividers: > + description: | > + Select which dividers to use for VDD Overvoltage detection. Note that > + when the internal dividers are used the threshold is referenced to VDD. > + The percentages in the datasheet are misleading since the actual values > + to look for are in the "Absolute Maximum Ratings" table in the > + "Comparator Inputs" section. In there there's a line for each of the 5%, > + 10% and 15% settings with the actual min, typical and max tolerances. > + $ref: /schemas/types.yaml#/definitions/string > + enum: [external, vdd_5_percent, vdd_10_percent, vdd_15_percent] > + default: 0 Default is an integer yet the type is a string? > + > + adi,undervoltage-dividers: > + description: | > + Select which dividers to use for VDD Overvoltage detection. Note that > + when the internal dividers are used the threshold is referenced to VDD. > + The percentages in the datasheet are misleading since the actual values > + to look for are in the "Absolute Maximum Ratings" table in the > + "Comparator Inputs" section. In there there's a line for each of the 5%, > + 10% and 15% settings with the actual min, typical and max tolerances. > + $ref: /schemas/types.yaml#/definitions/string > + enum: [external, vdd_5_percent, vdd_10_percent, vdd_15_percent] > + default: 0
On Tue, 2023-11-28 at 09:37 -0600, Rob Herring wrote: > On Fri, Nov 24, 2023 at 03:18:16PM +0100, Nuno Sa wrote: > > Add bindings for the LTC4282 High Current Hot Swap Controller with I2C > > Compatible Monitoring. > > > > Signed-off-by: Nuno Sa <nuno.sa@analog.com> > > --- > > .../devicetree/bindings/hwmon/adi,ltc4282.yaml | 206 > > +++++++++++++++++++++ > > MAINTAINERS | 6 + > > 2 files changed, 212 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml > > b/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml > > new file mode 100644 > > index 000000000000..6c979f70687e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml > > @@ -0,0 +1,206 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/hwmon/adi,ltc4282.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices LTC4282 I2C High Current Hot Swap Controller over I2C > > + > > +maintainers: > > + - Nuno Sa <nuno.sa@analog.com> > > + > > +description: | > > + Analog Devices LTC4282 I2C High Current Hot Swap Controller over I2C. > > + > > + > > https://www.analog.com/media/en/technical-documentation/data-sheets/ltc4282.pdf > > + > > +properties: > > + compatible: > > + enum: > > + - adi,ltc4282 > > + > > + reg: > > + maxItems: 1 > > + > > + vdd-supply: true > > + > > + clocks: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 0 > > + > > + adi,rsense-nano-ohms: > > + description: Value of the sense resistor. > > + > > + adi,vin-mode-microvolt: > > + description: > > + Selects operating range for the Undervoltage, Overvoltage and > > Foldback > > + pins. Also for the ADC. Should be set to the nominal input voltage. > > + enum: [3300000, 5000000, 12000000, 24000000] > > + default: 12000000 > > + > > + adi,fet-bad-timeout-ms: > > + description: > > + From the moment a FET bad conditions is present, this property > > selects the > > + wait time/timeout for a FET-bad fault to be signaled. Setting this to > > 0, > > + disables FET bad faults to be reported. > > + default: 255 > > + maximum: 255 > > + > > + adi,overvoltage-dividers: > > + description: | > > + Select which dividers to use for VDD Overvoltage detection. Note that > > + when the internal dividers are used the threshold is referenced to > > VDD. > > + The percentages in the datasheet are misleading since the actual > > values > > + to look for are in the "Absolute Maximum Ratings" table in the > > + "Comparator Inputs" section. In there there's a line for each of the > > 5%, > > + 10% and 15% settings with the actual min, typical and max tolerances. > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [external, vdd_5_percent, vdd_10_percent, vdd_15_percent] > > + default: 0 > > Default is an integer yet the type is a string? Argh, another leftover from v1. Thanks for catching it... Will change it in v3. - Nuno Sá >
diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml new file mode 100644 index 000000000000..6c979f70687e --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml @@ -0,0 +1,206 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/adi,ltc4282.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices LTC4282 I2C High Current Hot Swap Controller over I2C + +maintainers: + - Nuno Sa <nuno.sa@analog.com> + +description: | + Analog Devices LTC4282 I2C High Current Hot Swap Controller over I2C. + + https://www.analog.com/media/en/technical-documentation/data-sheets/ltc4282.pdf + +properties: + compatible: + enum: + - adi,ltc4282 + + reg: + maxItems: 1 + + vdd-supply: true + + clocks: + maxItems: 1 + + '#clock-cells': + const: 0 + + adi,rsense-nano-ohms: + description: Value of the sense resistor. + + adi,vin-mode-microvolt: + description: + Selects operating range for the Undervoltage, Overvoltage and Foldback + pins. Also for the ADC. Should be set to the nominal input voltage. + enum: [3300000, 5000000, 12000000, 24000000] + default: 12000000 + + adi,fet-bad-timeout-ms: + description: + From the moment a FET bad conditions is present, this property selects the + wait time/timeout for a FET-bad fault to be signaled. Setting this to 0, + disables FET bad faults to be reported. + default: 255 + maximum: 255 + + adi,overvoltage-dividers: + description: | + Select which dividers to use for VDD Overvoltage detection. Note that + when the internal dividers are used the threshold is referenced to VDD. + The percentages in the datasheet are misleading since the actual values + to look for are in the "Absolute Maximum Ratings" table in the + "Comparator Inputs" section. In there there's a line for each of the 5%, + 10% and 15% settings with the actual min, typical and max tolerances. + $ref: /schemas/types.yaml#/definitions/string + enum: [external, vdd_5_percent, vdd_10_percent, vdd_15_percent] + default: 0 + + adi,undervoltage-dividers: + description: | + Select which dividers to use for VDD Overvoltage detection. Note that + when the internal dividers are used the threshold is referenced to VDD. + The percentages in the datasheet are misleading since the actual values + to look for are in the "Absolute Maximum Ratings" table in the + "Comparator Inputs" section. In there there's a line for each of the 5%, + 10% and 15% settings with the actual min, typical and max tolerances. + $ref: /schemas/types.yaml#/definitions/string + enum: [external, vdd_5_percent, vdd_10_percent, vdd_15_percent] + default: 0 + + adi,current-limit-sense-microvolt: + description: + The current limit sense voltage of the chip is adjustable between + 12.5mV and 34.4mV in 3.1mV steps. This effectively limits the current + on the load. + enum: [12500, 15625, 18750, 21875, 25000, 28125, 31250, 34375] + default: 25000 + + adi,overcurrent-retry: + description: + If set, enables the chip to auto-retry 256 timer cycles after an + Overcurrent fault. + type: boolean + + adi,overvoltage-retry-disable: + description: + If set, disables the chip to auto-retry 50ms after an Overvoltage fault. + It's enabled by default. + type: boolean + + adi,undervoltage-retry-disable: + description: + If set, disables the chip to auto-retry 50ms after an Undervoltage fault. + It's enabled by default. + type: boolean + + adi,fault-log-enable: + description: + If set, enables the FAULT_LOG and ADC_ALERT_LOG registers to be written + to the EEPROM when a fault bit transitions high and hence, will be + available after a power cycle (the chip loads the contents of + the EE_FAULT_LOG register - the one in EEPROM - into FAULT_LOG at boot). + type: boolean + + adi,gpio-alert: + description: Use the ALERT pin as a GPIO. + type: boolean + + adi,gpio1-mode: + description: Defines the function of the Pin. + $ref: /schemas/types.yaml#/definitions/string + enum: [gpio, power_bad, power_good] + + adi,gpio2-mode: + description: Defines the function of the Pin. + 0 - GPIO Mode. + 1 - Acts as an input pin and it is feeded into the ADC. + 2 - Pulls Low when the MOSFET is dissipating power (stress). + $ref: /schemas/types.yaml#/definitions/string + enum: [gpio, adc_input, stress_fet] + + adi,gpio3-mode: + description: Defines the function of the Pin. + 0 - GPIO Mode. + 1 - Acts as an input pin and it is feeded into the ADC. + $ref: /schemas/types.yaml#/definitions/string + enum: [gpio, adc_input] + + gpio-controller: + description: + This property applies if some of the pins are used as GPIOs. + + '#gpio-cells': + const: 2 + +required: + - compatible + - reg + - adi,rsense-nano-ohms + +dependencies: + adi,alert-as-gpio: [gpio-controller, '#gpio-cells'] + +allOf: + - if: + required: + - adi,gpio1-mode + then: + allOf: + - if: + properties: + adi,gpio1-mode: + const: gpio + then: + dependencies: + adi,gpio1-mode: [gpio-controller, '#gpio-cells'] + - if: + required: + - adi,gpio2-mode + then: + allOf: + - if: + properties: + adi,gpio2-mode: + const: gpio + then: + dependencies: + adi,gpio2-mode: [gpio-controller, '#gpio-cells'] + - if: + required: + - adi,gpio3-mode + then: + allOf: + - if: + properties: + adi,gpio3-mode: + const: gpio + then: + dependencies: + adi,gpio3-mode: [gpio-controller, '#gpio-cells'] + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + hwmon@50 { + compatible = "adi,ltc4282"; + reg = <0x50>; + adi,rsense-nano-ohms = <500>; + + gpio-controller; + #gpio-cells = <2>; + + adi,gpio1-mode = "power_good"; + adi,gpio2-mode = "gpio"; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 97f51d5ec1cf..4a2b84ea1274 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12629,6 +12629,12 @@ S: Maintained F: Documentation/hwmon/ltc4261.rst F: drivers/hwmon/ltc4261.c +LTC4282 HARDWARE MONITOR DRIVER +M: Nuno Sa <nuno.sa@analog.com> +L: linux-hwmon@vger.kernel.org +S: Supported +F: Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml + LTC4306 I2C MULTIPLEXER DRIVER M: Michael Hennerich <michael.hennerich@analog.com> L: linux-i2c@vger.kernel.org