diff mbox series

[04/11] DT: USB: Convert ehci-orion to YAML

Message ID 20220820194804.3352415-5-andrew@lunn.ch
State Changes Requested, archived
Headers show
Series Start converting MVEBU bindings to YAML | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 3 warnings, 44 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Andrew Lunn Aug. 20, 2022, 7:47 p.m. UTC
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 .../devicetree/bindings/usb/ehci-orion.txt    | 22 ----------
 .../bindings/usb/marvell,orion-ehci.yaml      | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 22 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/usb/ehci-orion.txt
 create mode 100644 Documentation/devicetree/bindings/usb/marvell,orion-ehci.yaml

Comments

Rob Herring (Arm) Aug. 21, 2022, 8:21 p.m. UTC | #1
On Sat, 20 Aug 2022 21:47:57 +0200, Andrew Lunn wrote:
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  .../devicetree/bindings/usb/ehci-orion.txt    | 22 ----------
>  .../bindings/usb/marvell,orion-ehci.yaml      | 44 +++++++++++++++++++
>  2 files changed, 44 insertions(+), 22 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/usb/ehci-orion.txt
>  create mode 100644 Documentation/devicetree/bindings/usb/marvell,orion-ehci.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/


ehci@50000: '#address-cells', '#size-cells', 'port@1' do not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/kirkwood-c200-v1.dtb
	arch/arm/boot/dts/kirkwood-l-50.dtb

usb@50000: 'phy-names' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/armada-375-db.dtb

usb@58000: 'usb-phy' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/armada-388-helios4.dtb

usb@58000: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/armada-388-gp.dtb

usb@5e000: 'marvell,usb-misc-reg', 'phy-names' do not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm64/boot/dts/marvell/armada-3720-db.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dtb
	arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dtb
	arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtb

usb@a0000: 'dr_mode', 'phy-names' do not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm64/boot/dts/marvell/ac5-98dx35xx-rd.dtb

usb-host@50000: 'vbus-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/dove-sbc-a510.dtb
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/ehci-orion.txt b/Documentation/devicetree/bindings/usb/ehci-orion.txt
deleted file mode 100644
index 2855bae79fda..000000000000
--- a/Documentation/devicetree/bindings/usb/ehci-orion.txt
+++ /dev/null
@@ -1,22 +0,0 @@ 
-* EHCI controller, Orion Marvell variants
-
-Required properties:
-- compatible: must be one of the following
-	"marvell,orion-ehci"
-	"marvell,armada-3700-ehci"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- interrupts: The EHCI interrupt
-
-Optional properties:
-- clocks: reference to the clock
-- phys: reference to the USB PHY
-- phy-names: name of the USB PHY, should be "usb"
-
-Example:
-
-	ehci@50000 {
-		compatible = "marvell,orion-ehci";
-		reg = <0x50000 0x1000>;
-		interrupts = <19>;
-	};
diff --git a/Documentation/devicetree/bindings/usb/marvell,orion-ehci.yaml b/Documentation/devicetree/bindings/usb/marvell,orion-ehci.yaml
new file mode 100644
index 000000000000..5db56d62b3b5
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/marvell,orion-ehci.yaml
@@ -0,0 +1,44 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/marvell,orion-ehci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Orion USB Controller Device Tree Bindings
+
+maintainers:
+  - Andrew Lunn <andrew@lunn.ch>
+
+properties:
+  compatible:
+    enum:
+      - marvell,orion-ehci
+      - marvell,armada-3700-ehci
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  phys:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    ehci@50000 {
+        compatible = "marvell,orion-ehci";
+        reg = <0x50000 0x1000>;
+        interrupts = <19>;
+    };
+...