diff mbox

[15/30] package/matchbox-common: break dependency chain for display

Message ID decaf19e18b41b46067fa48d59ba2171e4893598.1429725549.git.yann.morin.1998@free.fr
State Changes Requested
Headers show

Commit Message

Yann E. MORIN April 22, 2015, 6:09 p.m. UTC
Currently, matchbox-common depends on either matchbox-dsktop or
matchbox-panel, and the three are organised so that matchbox-common gets
indented in the menuconfig.

That's a feature of menuconfig to consider the dependency chain to
indent sub-options.

Add a fake, prompt-less option to break that dependency chain.

Note: yes, this is an dirty hack.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/matchbox/matchbox-common/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Arnout Vandecappelle May 1, 2015, 8:02 p.m. UTC | #1
On 22/04/15 20:09, Yann E. MORIN wrote:
> Currently, matchbox-common depends on either matchbox-dsktop or
> matchbox-panel, and the three are organised so that matchbox-common gets
> indented in the menuconfig.
> 
> That's a feature of menuconfig to consider the dependency chain to
> indent sub-options.
> 
> Add a fake, prompt-less option to break that dependency chain.
> 
> Note: yes, this is an dirty hack.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

 Now that you've moved the packages out of the matchbox/ directory and sorted
them alphabetically, this is no longer needed.

 Or else, I missed the point :-)

 Regards,
 Arnout

> ---
>  package/matchbox/matchbox-common/Config.in | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/matchbox/matchbox-common/Config.in b/package/matchbox/matchbox-common/Config.in
> index 6ec4697..93761f5 100644
> --- a/package/matchbox/matchbox-common/Config.in
> +++ b/package/matchbox/matchbox-common/Config.in
> @@ -1,3 +1,8 @@
> +# Hack! Break dependency chain so that matchbox-common does
> +# not get indented below matchbox-panel or matchbox-desktop.
> +config FOO
> +    bool
> +
>  config BR2_PACKAGE_MATCHBOX_COMMON
>  	bool "matchbox-common"
>  	depends on BR2_PACKAGE_MATCHBOX_PANEL || BR2_PACKAGE_MATCHBOX_DESKTOP
>
Yann E. MORIN May 2, 2015, noon UTC | #2
Arnout, All,

On 2015-05-01 22:02 +0200, Arnout Vandecappelle spake thusly:
> On 22/04/15 20:09, Yann E. MORIN wrote:
> > Currently, matchbox-common depends on either matchbox-dsktop or
> > matchbox-panel, and the three are organised so that matchbox-common gets
> > indented in the menuconfig.
> > 
> > That's a feature of menuconfig to consider the dependency chain to
> > indent sub-options.
> > 
> > Add a fake, prompt-less option to break that dependency chain.
> > 
> > Note: yes, this is an dirty hack.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
>  Now that you've moved the packages out of the matchbox/ directory and sorted
> them alphabetically, this is no longer needed.
> 
>  Or else, I missed the point :-)

No, that's correct. I'll drop this.

Thanks! :-)

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/package/matchbox/matchbox-common/Config.in b/package/matchbox/matchbox-common/Config.in
index 6ec4697..93761f5 100644
--- a/package/matchbox/matchbox-common/Config.in
+++ b/package/matchbox/matchbox-common/Config.in
@@ -1,3 +1,8 @@ 
+# Hack! Break dependency chain so that matchbox-common does
+# not get indented below matchbox-panel or matchbox-desktop.
+config FOO
+    bool
+
 config BR2_PACKAGE_MATCHBOX_COMMON
 	bool "matchbox-common"
 	depends on BR2_PACKAGE_MATCHBOX_PANEL || BR2_PACKAGE_MATCHBOX_DESKTOP