diff mbox series

[2/2] support/check-bin-arch: exclude kernel modules for merged /usr

Message ID ce786b49c9bbe6a3e2ebde9ca28b56de86e68b2e.1520454419.git.yann.morin.1998@free.fr
State Changes Requested
Headers show
Series [1/2] spport/check-bin-arch: accept arbitrary ignore paths | expand

Commit Message

Yann E. MORIN March 7, 2018, 8:27 p.m. UTC
When using a merged /usr, the kernel module path is really
/usr/lib/modules, as /lib is a symlink to usr/lib .

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 support/scripts/check-bin-arch | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard March 7, 2018, 8:45 p.m. UTC | #1
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > When using a merged /usr, the kernel module path is really
 > /usr/lib/modules, as /lib is a symlink to usr/lib .

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
Yann E. MORIN March 7, 2018, 9:23 p.m. UTC | #2
Peter, All,

On 2018-03-07 21:45 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> 
>  > When using a merged /usr, the kernel module path is really
>  > /usr/lib/modules, as /lib is a symlink to usr/lib .
> 
>  > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>  > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> 
> Reviewed-by: Peter Korsgaard <peter@korsgaard.com>

But I forgot to update the manual with this new location! ;-)

Should I still cary your rev-tag in round 2?

Regards,
Yann E. MORIN.
Peter Korsgaard March 7, 2018, 9:35 p.m. UTC | #3
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2018-03-07 21:45 +0100, Peter Korsgaard spake thusly:
 >> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
 >> 
 >> > When using a merged /usr, the kernel module path is really
 >> > /usr/lib/modules, as /lib is a symlink to usr/lib .
 >> 
 >> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 >> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 >> 
 >> Reviewed-by: Peter Korsgaard <peter@korsgaard.com>

 > But I forgot to update the manual with this new location! ;-)

 > Should I still cary your rev-tag in round 2?

Sure!
diff mbox series

Patch

diff --git a/support/scripts/check-bin-arch b/support/scripts/check-bin-arch
index 922791ab89..258014b98f 100755
--- a/support/scripts/check-bin-arch
+++ b/support/scripts/check-bin-arch
@@ -14,6 +14,7 @@  declare -a IGNORES=(
 	# and its modules may still be 64-bit. To keep the basic
 	# check-bin-arch logic simple, just skip this directory.
 	"/lib/modules"
+	"/usr/lib/modules"
 
 	# Skip files in /usr/share, several packages (qemu,
 	# pru-software-support) legitimately install ELF binaries that