| Message ID | b3d829351f7593b214a93a3503b789113d3d63ca.1428081325.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
diff --git a/support/download/check-hash b/support/download/check-hash index c24d26b..96d12a5 100755 --- a/support/download/check-hash +++ b/support/download/check-hash @@ -31,8 +31,12 @@ h_file="${1}" file="${2}" base="${3}" +# Bail early if no hash to check +if [ -z "${h_file}" ]; then + exit 0 +fi # Does the hash-file exist? -if [ -z "${h_file}" -o ! -f "${h_file}" ]; then +if [ ! -f "${h_file}" ]; then printf "WARNING: no hash file for %s\n" "${base}" >&2 exit 0 fi
When downloading froma repository, we explicitly pass no hash file, becasue we can't check hashes in that case. However, we're still printing a message that there is a missign hash file. Beside being a bit annoying (since we can't do anything about it), it may also be wrong, especially for packages for which we supportmultiple versions, with some being downloaded via a git clone and others as tarballs. Just print no warning when the path to the hash file is empty. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- support/download/check-hash | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)