| Message ID | a30751a9b30f9cc2b22bacffa659ef311622e180.1427037564.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sun, Mar 22, 2015 at 4:21 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Instead of silently accepting a missing .hash file, print a warning. > > This can be grepped from a build log, to find packages that still have > no hash, with the long-term goal of adding hashes for all packages. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: Samuel Martin <s.martin49@gmail.com> Regards,
diff --git a/support/download/check-hash b/support/download/check-hash index d200868..82cc750 100755 --- a/support/download/check-hash +++ b/support/download/check-hash @@ -33,6 +33,7 @@ base="${3}" # Does the hash-file exist? if [ -z "${h_file}" -o ! -f "${h_file}" ]; then + printf "WARNING: no hash file for %s\n" "${base}" >&2 exit 0 fi
Instead of silently accepting a missing .hash file, print a warning. This can be grepped from a build log, to find packages that still have no hash, with the long-term goal of adding hashes for all packages. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- support/download/check-hash | 1 + 1 file changed, 1 insertion(+)