diff mbox series

package/perftest: fix unmet direct dependencies

Message ID ZNnU4wGoYvMTOSkQ@waldemar-brodkorb.de
State Accepted
Headers show
Series package/perftest: fix unmet direct dependencies | expand

Commit Message

Waldemar Brodkorb Aug. 14, 2023, 7:16 a.m. UTC
rdma-core selects perftest and needs NPTL.
Should be backported to stable branches, because the problem
exist since the addition of the package.

Fixes:
 - http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/perftest/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN Aug. 14, 2023, 10:56 a.m. UTC | #1
Waldemar, All,

On 2023-08-14 09:16 +0200, Waldemar Brodkorb spake thusly:
> rdma-core selects perftest and needs NPTL.
> Should be backported to stable branches, because the problem
> exist since the addition of the package.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/perftest/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/perftest/Config.in b/package/perftest/Config.in
> index 25cd1a9b8d..0a4114015b 100644
> --- a/package/perftest/Config.in
> +++ b/package/perftest/Config.in
> @@ -20,7 +20,7 @@ config BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
>  config BR2_PACKAGE_PERFTEST
>  	bool "perftest"
>  	depends on BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # rdma-core

You also missed propagating the dependency on the kernel headers
version, so I've done that.

I also expanded the commit log to explain when the two issues were
introduced.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  	depends on !BR2_STATIC_LIBS # rdma-core
>  	# musl does not define sysconf(_SC_LEVEL1_DCACHE_LINESIZE)
>  	depends on !BR2_TOOLCHAIN_USES_MUSL
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard Sept. 12, 2023, 6:18 p.m. UTC | #2
>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:

 > rdma-core selects perftest and needs NPTL.
 > Should be backported to stable branches, because the problem
 > exist since the addition of the package.

 > Fixes:
 >  - http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de

 > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Committed to 2023.02.x and 2023.05.x, thanks.
diff mbox series

Patch

diff --git a/package/perftest/Config.in b/package/perftest/Config.in
index 25cd1a9b8d..0a4114015b 100644
--- a/package/perftest/Config.in
+++ b/package/perftest/Config.in
@@ -20,7 +20,7 @@  config BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
 config BR2_PACKAGE_PERFTEST
 	bool "perftest"
 	depends on BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # rdma-core
 	depends on !BR2_STATIC_LIBS # rdma-core
 	# musl does not define sysconf(_SC_LEVEL1_DCACHE_LINESIZE)
 	depends on !BR2_TOOLCHAIN_USES_MUSL