diff mbox series

board/qemu/ppc64le-powernv8: fixup example

Message ID ZNew/asuEOItVTZZ@waldemar-brodkorb.de
State Accepted
Headers show
Series board/qemu/ppc64le-powernv8: fixup example | expand

Commit Message

Waldemar Brodkorb Aug. 12, 2023, 4:19 p.m. UTC
Use full relative pathes for rootfs and kernel, like in other
readme's.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 board/qemu/ppc64le-powernv8/readme.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Aug. 12, 2023, 7:54 p.m. UTC | #1
On Sat, 12 Aug 2023 18:19:09 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:

> Use full relative pathes for rootfs and kernel, like in other
> readme's.
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  board/qemu/ppc64le-powernv8/readme.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. I was initially a bit confused because all
those readme.txt files for Qemu configurations are used in our Gitlab
CI infra to automatically boot the resulting kernel/rootfs images in
Qemu, and the build/test was working fine in our CI.

Turns out that board/qemu/post-image.sh strips output/images/, and then
board/qemu/start-qemu.sh.in chdir into ${BINARIES_DIR}. So indeed, it
makes sense that both this incorrect readme.txt, and all the other ones
for Qemu defconfigs, that had output/images, worked.

Thomas
Peter Korsgaard Sept. 12, 2023, 6:04 p.m. UTC | #2
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > On Sat, 12 Aug 2023 18:19:09 +0200
 > Waldemar Brodkorb <wbx@openadk.org> wrote:

 >> Use full relative pathes for rootfs and kernel, like in other
 >> readme's.
 >> 
 >> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
 >> ---
 >> board/qemu/ppc64le-powernv8/readme.txt | 2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)

 > Applied to master, thanks. I was initially a bit confused because all
 > those readme.txt files for Qemu configurations are used in our Gitlab
 > CI infra to automatically boot the resulting kernel/rootfs images in
 > Qemu, and the build/test was working fine in our CI.

 > Turns out that board/qemu/post-image.sh strips output/images/, and then
 > board/qemu/start-qemu.sh.in chdir into ${BINARIES_DIR}. So indeed, it
 > makes sense that both this incorrect readme.txt, and all the other ones
 > for Qemu defconfigs, that had output/images, worked.

Committed to 2023.02.x and 2023.05.x, thanks.
diff mbox series

Patch

diff --git a/board/qemu/ppc64le-powernv8/readme.txt b/board/qemu/ppc64le-powernv8/readme.txt
index 059f55fbc9..b57c97464a 100644
--- a/board/qemu/ppc64le-powernv8/readme.txt
+++ b/board/qemu/ppc64le-powernv8/readme.txt
@@ -1,5 +1,5 @@ 
 Run the emulation with:
 
-qemu-system-ppc64 -M powernv9 -kernel vmlinux -append "console=hvc0 rootwait root=/dev/nvme0n1" -device nvme,bus=pcie.3,addr=0x0,drive=drive0,serial=1234 -drive file=./rootfs.ext2,if=none,id=drive0,format=raw,cache=none -device e1000e,netdev=net0,mac=C0:FF:EE:00:01:03,bus=pcie.1,addr=0x0  -netdev user,id=net0 -serial mon:stdio -nographic # qemu_ppc64le_powernv8_defconfig
+qemu-system-ppc64 -M powernv9 -kernel output/images/vmlinux -append "console=hvc0 rootwait root=/dev/nvme0n1" -device nvme,bus=pcie.3,addr=0x0,drive=drive0,serial=1234 -drive file=output/images/rootfs.ext2,if=none,id=drive0,format=raw,cache=none -device e1000e,netdev=net0,mac=C0:FF:EE:00:01:03,bus=pcie.1,addr=0x0  -netdev user,id=net0 -serial mon:stdio -nographic # qemu_ppc64le_powernv8_defconfig
 
 The login prompt will appear in the terminal window.