| Message ID | ZND9hxOZvMoUHrgQ@waldemar-brodkorb.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | package/mpg123: fix linking error | expand |
Hello Waldemar, On Mon, 7 Aug 2023 16:19:51 +0200 Waldemar Brodkorb <wbx@openadk.org> wrote: > Fixes following build errors: > http://autobuild.buildroot.net/?reason=mpg123-1.31.3 Should be a pointer to a specific build issue, because http://autobuild.buildroot.net/?reason=mpg123-1.31.3 points to several issues, and in 5 years when we will look at this, we will no longer know which issue it refers to. Also, it should be just "Fixes:" Finally, and probably even more importantly: we really, really, really want an explanation of since when the problem has appeared, so that we know if this commit needs to be backported to a stable branch or not. Could you do this research and submit an updated patch? Thanks a lot! Thomas
diff --git a/package/mpg123/0001-mpg123-buildfix.patch b/package/mpg123/0001-mpg123-buildfix.patch new file mode 100644 index 0000000000..cc731ea967 --- /dev/null +++ b/package/mpg123/0001-mpg123-buildfix.patch @@ -0,0 +1,24 @@ +Signed-off-by: Waldemar Brodkorb <wbx@openadk.org> +Upstream: https://sourceforge.net/p/mpg123/bugs/353/ + +diff -Nur mpg123-1.31.3.orig/src/libmpg123/getcpuflags.h mpg123-1.31.3/src/libmpg123/getcpuflags.h +--- mpg123-1.31.3.orig/src/libmpg123/getcpuflags.h 2023-03-15 09:02:58.000000000 +0100 ++++ mpg123-1.31.3/src/libmpg123/getcpuflags.h 2023-08-07 15:57:19.444106173 +0200 +@@ -44,6 +44,8 @@ + + unsigned int getcpuflags(struct cpuflags* cf); + ++#if ((defined OPT_X86) || (defined OPT_X86_64) || (defined OPT_NEON) || (defined OPT_NEON64)) && (defined OPT_MULTI) ++ + #ifdef WANT_GETCPUFLAGS + #include <string.h> + // Wrapper needed for ignorant clang memory sanitizer that chokes +@@ -55,8 +57,6 @@ + } + #endif + +-#if ((defined OPT_X86) || (defined OPT_X86_64) || (defined OPT_NEON) || (defined OPT_NEON64)) && (defined OPT_MULTI) +- + // We really evaluate the CPU flags. + #define OPT_CPU_FLAGS +
Fixes following build errors: http://autobuild.buildroot.net/?reason=mpg123-1.31.3 Patch was provided by upstream: https://sourceforge.net/p/mpg123/bugs/353/ Signed-off-by: Waldemar Brodkorb <wbx@openadk.org> --- package/mpg123/0001-mpg123-buildfix.patch | 24 +++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 package/mpg123/0001-mpg123-buildfix.patch