| Message ID | BLU0-SMTP4083C56CA0B43BBAC9B3616D9750@phx.gbl |
|---|---|
| State | Superseded |
| Headers | show |
On 03/09/2014 03:01 PM, Bernd Kuhls wrote: > Signed-off-by: Bernd Kuhls <berndkuhls@hotmail.com> > Signed-off-by: Spenser Gilliland <spenser@gillilanding.com> > --- > v4: rebased v3 > v3: Config.in: move package to "Graphic libraries" (Arnout) > v2: rebased v1 > v1: rebased Spenser Gilliland´s patch: > http://patchwork.ozlabs.org/patch/278302/ > > package/Config.in | 1 + > package/{x11r7 => }/mesa3d/Config.in | 0 > package/{x11r7 => }/mesa3d/mesa3d-uclibc-locale.patch | 0 > package/{x11r7 => }/mesa3d/mesa3d.mk | 0 > package/x11r7/Config.in | 1 - > 5 files changed, 1 insertion(+), 1 deletion(-) > rename package/{x11r7 => }/mesa3d/Config.in (100%) > rename package/{x11r7 => }/mesa3d/mesa3d-uclibc-locale.patch (100%) > rename package/{x11r7 => }/mesa3d/mesa3d.mk (100%) Reviewed-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com> Regards, Sebastien.
Bernd, All, On 2014-03-09 20:01 +0100, Bernd Kuhls spake thusly: Maybe it would be nice to give in the commit log a bit more details on why it makes sense to move it out of x11r7. > Signed-off-by: Bernd Kuhls <berndkuhls@hotmail.com> > Signed-off-by: Spenser Gilliland <spenser@gillilanding.com> [--SNIP--] > diff --git a/package/Config.in b/package/Config.in > index 70e5a7f..b0da653 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -188,6 +188,7 @@ source "package/fbv/Config.in" > source "package/imagemagick/Config.in" > source "package/linux-fusion/Config.in" > source "package/lite/Config.in" > +source "package/mesa3d/Config.in" If I understand correctly, mesa3d is an implementation of OpenGL. So, *maybe* it would make sense to move it along the other OpenGL packages, into package/opengl/. But I'd like others to confirm this first. Otherwise, looks good. Regards, Yann E. MORIN.
Hi, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote in news:20140310173941.GA3282@free.fr: > Maybe it would be nice to give in the commit log a bit more details on > why it makes sense to move it out of x11r7. mesa3d does not depend on x11, it can be used by wayland as well. > If I understand correctly, mesa3d is an implementation of OpenGL. So, > *maybe* it would make sense to move it along the other OpenGL packages, > into package/opengl/. In package/opengl/ are only virtual packages. Regards, Bernd
Bernd, All, On 2014-03-10 18:52 +0100, Bernd Kuhls spake thusly: > Hi, > > "Yann E. MORIN" <yann.morin.1998@free.fr> wrote in > news:20140310173941.GA3282@free.fr: > > > Maybe it would be nice to give in the commit log a bit more details on > > why it makes sense to move it out of x11r7. > > mesa3d does not depend on x11, it can be used by wayland as well. Just add this in the commit log. ;-) > > If I understand correctly, mesa3d is an implementation of OpenGL. So, > > *maybe* it would make sense to move it along the other OpenGL packages, > > into package/opengl/. > > In package/opengl/ are only virtual packages. Right. Mesa3D is more on the provider-side, indeed. So no need to put it in package/opengl. OK. ;-) Regards, Yann E. MORIN.
Yann E., All On Mon, Mar 10, 2014 at 06:39:41PM +0100, Yann E. MORIN wrote: > > diff --git a/package/Config.in b/package/Config.in > > index 70e5a7f..b0da653 100644 > > --- a/package/Config.in > > +++ b/package/Config.in > > @@ -188,6 +188,7 @@ source "package/fbv/Config.in" > > source "package/imagemagick/Config.in" > > source "package/linux-fusion/Config.in" > > source "package/lite/Config.in" > > +source "package/mesa3d/Config.in" > > If I understand correctly, mesa3d is an implementation of OpenGL. So, > *maybe* it would make sense to move it along the other OpenGL packages, > into package/opengl/. Some quick thoughts: 1. As Mesa3D is an implementation of OpenGL, it will be a provider for the virtual packages libegl, libgles and libopenvg. 2. Mesa3D also provides libgl, but: - no package in Buildroot requires full OpenGL. - Buildroot is unlikely to include packages for AMD/NVidia/Intel drivers (providers for libgl). So there is no need for a libgl virtual package. 3. IMHO package/opengl should only contain the definitions of the virtual packages, not the providers (otherwise sunxi-mali should be moved to package/opengl too!). Best regards, ELB
Eric, All, On 2014-03-10 19:20 +0100, Eric Le Bihan spake thusly: > Yann E., All > On Mon, Mar 10, 2014 at 06:39:41PM +0100, Yann E. MORIN wrote: > > > > diff --git a/package/Config.in b/package/Config.in > > > index 70e5a7f..b0da653 100644 > > > --- a/package/Config.in > > > +++ b/package/Config.in > > > @@ -188,6 +188,7 @@ source "package/fbv/Config.in" > > > source "package/imagemagick/Config.in" > > > source "package/linux-fusion/Config.in" > > > source "package/lite/Config.in" > > > +source "package/mesa3d/Config.in" > > > > If I understand correctly, mesa3d is an implementation of OpenGL. So, > > *maybe* it would make sense to move it along the other OpenGL packages, > > into package/opengl/. > Some quick thoughts: > > 1. As Mesa3D is an implementation of OpenGL, it will be a provider for the > virtual packages libegl, libgles and libopenvg. I've looked on my distro, and mesa3d does not provide any file named libegl*.so or ligles*.so or libopenvg*.so. So I don't think it should be, *as is*, a provider for libegl, libgles or libopenvg. > 2. Mesa3D also provides libgl, but: libgl or libglx ? On my distro (Ubuntu 13.10), there's no libgl.so, only libglx.so which is provided by a bumch of different packages, of which the nvidia blobs. All I have that looks to be from mesa3d if libglapi.so. > - no package in Buildroot requires full OpenGL. > - Buildroot is unlikely to include packages for AMD/NVidia/Intel drivers > (providers for libgl). Unlikely, but what about a powerfull, game-console-class device using a NVidia (or Intel, AMD) GPU? > So there is no need for a libgl virtual package. Indeed, so no need to provide a virtul package for that as long as we do not have a real user. It will always be time to add it later. And it's not like it would be rocket-science to do it! :-) > 3. IMHO package/opengl should only contain the definitions of the virtual > packages, not the providers (otherwise sunxi-mali should be moved to > package/opengl too!). Yes, I already replied to Bernd in this direction: mesa3d treads on the provider side. So like other GL providers, it does not really belong to package/opengl. Regards, Yann E. MORIN.
Eric Le Bihan <eric.le.bihan.dev@free.fr> wrote in news:20140310182030.GB18832@pc-eric: > 2. Mesa3D also provides libgl, but: > > - no package in Buildroot requires full OpenGL. Hi, xbmc depends on libGL.so ;) Regards, Bernd
On 03/10/14 19:41, Yann E. MORIN wrote: >> > 1. As Mesa3D is an implementation of OpenGL, it will be a provider for the >> > virtual packages libegl, libgles and libopenvg. > I've looked on my distro, and mesa3d does not provide any file named > libegl*.so or ligles*.so or libopenvg*.so. So I don't think it should > be, *as is*, a provider for libegl, libgles or libopenvg. Have you looked at libegl1-mesa, libgles2-mesa, libopenvg1-mesa? > >> > 2. Mesa3D also provides libgl, but: > libgl or libglx ? > > On my distro (Ubuntu 13.10), there's no libgl.so, only libglx.so which > is provided by a bumch of different packages, of which the nvidia blobs. That one is in libgl1-mesa-glx. All that stuff is only installed if you need it - which you usually don't because glx is enough for desktop use. Regards, Arnout
On 2014-03-12 07:24 +0100, Arnout Vandecappelle spake thusly: > On 03/10/14 19:41, Yann E. MORIN wrote: > >> > 1. As Mesa3D is an implementation of OpenGL, it will be a provider for the > >> > virtual packages libegl, libgles and libopenvg. > > I've looked on my distro, and mesa3d does not provide any file named > > libegl*.so or ligles*.so or libopenvg*.so. So I don't think it should > > be, *as is*, a provider for libegl, libgles or libopenvg. > > Have you looked at libegl1-mesa, libgles2-mesa, libopenvg1-mesa? Indeed, I was looking for libegl, not libEGL. And apt-file is not smart enough to do a case-insensitive search by default, so now: $ apt-file search -i libegl |grep -E '\.so' [...] libegl1-mesa: /usr/lib/x86_64-linux-gnu/mesa-egl/libEGL.so.1.0.0 [...] $ apt-file search -i libgles |grep -E '\.so' [...] libgles1-mesa: /usr/lib/x86_64-linux-gnu/mesa-egl/libGLESv1_CM.so.1.1.0 [...] libgles2-mesa: /usr/lib/x86_64-linux-gnu/mesa-egl/libGLESv2.so.2.0.0 [...] $ apt-file search -i libopenvg |grep -E '\.so' [...] libopenvg1-mesa: /usr/lib/x86_64-linux-gnu/mesa-egl/libOpenVG.so.1.0.0 [...] OK, good. So mesa3d can be added as a provider for libegl, libgles and libopenvg, indeed. It can be done in a separate patch, later. Regards, Yann E. MORIN.
diff --git a/package/Config.in b/package/Config.in index 70e5a7f..b0da653 100644 --- a/package/Config.in +++ b/package/Config.in @@ -188,6 +188,7 @@ source "package/fbv/Config.in" source "package/imagemagick/Config.in" source "package/linux-fusion/Config.in" source "package/lite/Config.in" +source "package/mesa3d/Config.in" source "package/ocrad/Config.in" source "package/psplash/Config.in" source "package/sawman/Config.in" diff --git a/package/x11r7/mesa3d/Config.in b/package/mesa3d/Config.in similarity index 100% rename from package/x11r7/mesa3d/Config.in rename to package/mesa3d/Config.in diff --git a/package/x11r7/mesa3d/mesa3d-uclibc-locale.patch b/package/mesa3d/mesa3d-uclibc-locale.patch similarity index 100% rename from package/x11r7/mesa3d/mesa3d-uclibc-locale.patch rename to package/mesa3d/mesa3d-uclibc-locale.patch diff --git a/package/x11r7/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk similarity index 100% rename from package/x11r7/mesa3d/mesa3d.mk rename to package/mesa3d/mesa3d.mk diff --git a/package/x11r7/Config.in b/package/x11r7/Config.in index 5ef118b..458d09f 100644 --- a/package/x11r7/Config.in +++ b/package/x11r7/Config.in @@ -15,7 +15,6 @@ if BR2_PACKAGE_XORG7 endmenu menu "X11R7 Libraries" source package/x11r7/libxcb/Config.in - source package/x11r7/mesa3d/Config.in source package/x11r7/xcb-util/Config.in source package/x11r7/xcb-util-image/Config.in source package/x11r7/xcb-util-keysyms/Config.in