Message ID | 290464f65f82952a8b2ae2672d330aff1f43e29f.1605821010.git.yann.morin.1998@free.fr |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <buildroot-bounces@busybox.net> X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=IQN8OWo0; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CcXk55XCKz9sTR for <incoming-buildroot@patchwork.ozlabs.org>; Fri, 20 Nov 2020 08:24:13 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3567827A5C; Thu, 19 Nov 2020 21:24:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sYTZ6JScD8l0; Thu, 19 Nov 2020 21:23:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 8D3B6274E2; Thu, 19 Nov 2020 21:23:57 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 397E51BF32B for <buildroot@lists.busybox.net>; Thu, 19 Nov 2020 21:23:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2E662874BB for <buildroot@lists.busybox.net>; Thu, 19 Nov 2020 21:23:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uZ4hcG-3xOWQ for <buildroot@lists.busybox.net>; Thu, 19 Nov 2020 21:23:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2EF2D874B2 for <buildroot@buildroot.org>; Thu, 19 Nov 2020 21:23:55 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id o15so7947219wru.6 for <buildroot@buildroot.org>; Thu, 19 Nov 2020 13:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/JjSVoDZjl1DVXt50xxIqPVfsB5K1twhq7sOMgpR14I=; b=IQN8OWo0yNWfQvdFnVOyP0oqH0NwMNiauVNWs39USijbz35HYNx7rF1/M95mefL08K G7wKjwqbKz5XpfCNj22+ob8dZ2gqtmI9MAMKdx+5SgFD+fWfQgc7w8WcSDqWpS62EAVo uHgZD8nDDd2U9FzYjbe5Ga+qcadWalvlIIDWnnwwo/uF2/K1uEP4zK3A6kugIlhrcaWJ kvq+tLcUKe5mxnK/jypMYF12ZGq5iShMwSIWkrG2Tak5hPLAmHi3oKFKRUbJC/wLWFQ2 I3Sm3LGYAxsFgAzW3a4EYWPa2fSea335EzXN0hgAqpLuqTmWr7cLTeFdO64B+V0ABtKy V5Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/JjSVoDZjl1DVXt50xxIqPVfsB5K1twhq7sOMgpR14I=; b=ANiF8LQgwIdvcTxai0MRIdwagtiXMV1tZJDLImJaXTsl/NIdA+rz34RjoyVjRD4nXC AvMTBaopewxmmWPHXuxKb2P/n2K8FMbL2BQacqZrBcySCF/CacNnrguExqwcOZwc4ynk jn3w+ZT7HJA+DP5vr2PaNlI1gEunUVbcxLgrcl8k/+1qbXTAbGp7hiFUWv3UaiEA3KIQ 0E15QzSu8PvEI8H21ZX64hgNy5ksEtRT+Wxdg1EGcuUR+d0dsMduQDrf/tVqwxtYYL0q Mij3dpaOsEOXbmCJlJsK8Hd4sXda22+4u5n3S9k+oLKQRMdgYTCrQzNVkv5LxX/zPx/S UkLw== X-Gm-Message-State: AOAM533pB03adh07yvSzhBB9gYtjt5mcpmVBxKeK4ZZQi9pQJS/VOGYD xLZSo1xHtSJraE3RE9Yo/yAafROOuuA= X-Google-Smtp-Source: ABdhPJwfjbeOkegYNYldcyYa9uiggbWUX90ytdz0QRZB33LF0Elw7HHCvMl2B/A6TTfF7ximtkXCeQ== X-Received: by 2002:a05:6000:364:: with SMTP id f4mr12036911wrf.290.1605821032931; Thu, 19 Nov 2020 13:23:52 -0800 (PST) Received: from scaer.home ([2a01:cb19:8b51:cb00:b94c:b327:ef3f:e064]) by smtp.gmail.com with ESMTPSA id l16sm1935392wrx.5.2020.11.19.13.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 13:23:52 -0800 (PST) From: "Yann E. MORIN" <yann.morin.1998@free.fr> To: buildroot@buildroot.org Date: Thu, 19 Nov 2020 22:23:45 +0100 Message-Id: <290464f65f82952a8b2ae2672d330aff1f43e29f.1605821010.git.yann.morin.1998@free.fr> X-Mailer: git-send-email 2.25.1 In-Reply-To: <cover.1605821010.git.yann.morin.1998@free.fr> References: <cover.1605821010.git.yann.morin.1998@free.fr> MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/7] core/pkg-infra: prepare for alternate default source archives X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot <buildroot.busybox.net> List-Unsubscribe: <http://lists.busybox.net/mailman/options/buildroot>, <mailto:buildroot-request@busybox.net?subject=unsubscribe> List-Archive: <http://lists.busybox.net/pipermail/buildroot/> List-Post: <mailto:buildroot@busybox.net> List-Help: <mailto:buildroot-request@busybox.net?subject=help> List-Subscribe: <http://lists.busybox.net/mailman/listinfo/buildroot>, <mailto:buildroot-request@busybox.net?subject=subscribe> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Vincent Fazio <vfazio@xes-inc.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net> |
Series |
[1/7] core/pkg-infra: prepare for alternate default source archives
|
expand
|
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 54de03da03..5fe1bfe0e2 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -514,11 +514,12 @@ ifneq ($$($(2)_OVERRIDE_SRCDIR),) $(2)_VERSION = custom endif +$(2)_SOURCE_EXT = .tar.gz ifndef $(2)_SOURCE ifdef $(3)_SOURCE $(2)_SOURCE = $$($(3)_SOURCE) else ifdef $(2)_VERSION - $(2)_SOURCE ?= $$($(2)_BASENAME_RAW).tar.gz + $(2)_SOURCE ?= $$($(2)_BASENAME_RAW)$$($(2)_SOURCE_EXT) endif endif
The .tar.gz default extension is historical, and we initially used to only fetch tarballs from remote sites. When we introduced downloads from VCS repositories, we kept that extension, and kept compressing with gz, by lack of good reason to switch to some other compression scheme. However, nowadays, we will want to change the way we construct the tarballs we generate from VCS. This will de facto change the hashes of those tarballs. If we were to keep the .tar.gz extension (and compression), then we'd have a problem with older archives that would no longer match the newer hashes (when someone uses s.b.o. for example), or the other way around (if we updated the archives on s.b.o and someone uses an older Buildroot). So we will want that the archives we generate do not clash with the existing ones, so needs another filename. So, we need a way to be able to use a different extension, whatever we'll want to use when we generate archives from VCS. Note that we do not need to play the host-defaults-to-target-value dance we do for the _SOURCE variable, because this is a purely internal variable, not exposed to packages. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Cc: Vincent Fazio <vfazio@xes-inc.com> --- package/pkg-generic.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)