diff mbox

[6/6,v3] support/download: restore mandatory check of hashes

Message ID 21c6a4cd9d79b9279ba50426a2d0baaa1bc3f0b0.1428322317.git.yann.morin.1998@free.fr
State Superseded
Headers show

Commit Message

Yann E. MORIN April 6, 2015, 12:13 p.m. UTC
Now that custom external toolchains to be downloaded proprely instruct
to not fail on a missing hash, restore the mandatory hash check for
everything else.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 support/download/check-hash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnout Vandecappelle April 6, 2015, 9:05 p.m. UTC | #1
On 06/04/15 14:13, Yann E. MORIN wrote:
> Now that custom external toolchains to be downloaded proprely instruct
> to not fail on a missing hash, restore the mandatory hash check for
> everything else.

 There are also a couple of uclibc versions without hash.

 Otherwise looks good :-)

 Regards,
 Arnout

> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  support/download/check-hash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/download/check-hash b/support/download/check-hash
> index a091c61..96d12a5 100755
> --- a/support/download/check-hash
> +++ b/support/download/check-hash
> @@ -104,5 +104,5 @@ if [ ${nb_checks} -eq 0 ]; then
>          exit 0
>      fi
>      printf "ERROR: No hash found for %s\n" "${base}" >&2
> -    exit 0
> +    exit 3
>  fi
>
Yann E. MORIN April 7, 2015, 10:04 p.m. UTC | #2
Arnout, All,

On 2015-04-06 23:05 +0200, Arnout Vandecappelle spake thusly:
> On 06/04/15 14:13, Yann E. MORIN wrote:
> > Now that custom external toolchains to be downloaded proprely instruct
> > to not fail on a missing hash, restore the mandatory hash check for
> > everything else.
> 
>  There are also a couple of uclibc versions without hash.

Then they should be added (unless they are git snapshots or the
likes...) ;-)

I'll see which are missing and add them; thanks for noticing.

Regards,
Yann E. MORIN.

>  Otherwise looks good :-)
> 
>  Regards,
>  Arnout
> 
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> > ---
> >  support/download/check-hash | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/support/download/check-hash b/support/download/check-hash
> > index a091c61..96d12a5 100755
> > --- a/support/download/check-hash
> > +++ b/support/download/check-hash
> > @@ -104,5 +104,5 @@ if [ ${nb_checks} -eq 0 ]; then
> >          exit 0
> >      fi
> >      printf "ERROR: No hash found for %s\n" "${base}" >&2
> > -    exit 0
> > +    exit 3
> >  fi
> > 
> 
> 
> -- 
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/support/download/check-hash b/support/download/check-hash
index a091c61..96d12a5 100755
--- a/support/download/check-hash
+++ b/support/download/check-hash
@@ -104,5 +104,5 @@  if [ ${nb_checks} -eq 0 ]; then
         exit 0
     fi
     printf "ERROR: No hash found for %s\n" "${base}" >&2
-    exit 0
+    exit 3
 fi