diff mbox series

[1/1] package/oatpp: disable tests

Message ID 20240407135951.1868714-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/oatpp: disable tests | expand

Commit Message

Fabrice Fontaine April 7, 2024, 1:59 p.m. UTC
Fix the following build failure raised since the addition of the package
in commit d5bba26801b352f591451cf73e0b7509de0e6850:

[100%] Linking CXX executable oatppAllTests
/home/buildroot/instance-0/output-1/per-package/oatpp/host/opt/ext-toolchain/m68k-buildroot-uclinux-uclibc/bin/ld.real: cannot find -latomic: No such file or directory

Fixes: d5bba26801b352f591451cf73e0b7509de0e6850
 - http://autobuild.buildroot.org/results/1587b391baecdbb5a24a0c0b2c33d63cb71a2f7f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/oatpp/oatpp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN April 7, 2024, 3:47 p.m. UTC | #1
Fabrice, All,

On 2024-04-07 15:59 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since the addition of the package
> in commit d5bba26801b352f591451cf73e0b7509de0e6850:
> 
> [100%] Linking CXX executable oatppAllTests
> /home/buildroot/instance-0/output-1/per-package/oatpp/host/opt/ext-toolchain/m68k-buildroot-uclinux-uclibc/bin/ld.real: cannot find -latomic: No such file or directory
> 
> Fixes: d5bba26801b352f591451cf73e0b7509de0e6850
>  - http://autobuild.buildroot.org/results/1587b391baecdbb5a24a0c0b2c33d63cb71a2f7f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

I guess we'll leave it to users of oatpp, of which we have none in
Buildroot, to properly link with the required libraries, then...

Regards,
Yann E. MORIN.

> ---
>  package/oatpp/oatpp.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk
> index c8b0c9694a..d3f6e1a9c2 100644
> --- a/package/oatpp/oatpp.mk
> +++ b/package/oatpp/oatpp.mk
> @@ -8,7 +8,7 @@ OATPP_VERSION = 1.3.0
>  OATPP_SITE = $(call github,oatpp,oatpp,$(OATPP_VERSION))
>  OATPP_LICENSE = Apache-2.0
>  OATPP_LICENSE_FILES = LICENSE
> -OATPP_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF
> +OATPP_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF -DOATPP_BUILD_TESTS=OFF
>  OATPP_INSTALL_STAGING = YES
>  # Only builds a static lib and headers
>  OATPP_INSTALL_TARGET = NO
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk
index c8b0c9694a..d3f6e1a9c2 100644
--- a/package/oatpp/oatpp.mk
+++ b/package/oatpp/oatpp.mk
@@ -8,7 +8,7 @@  OATPP_VERSION = 1.3.0
 OATPP_SITE = $(call github,oatpp,oatpp,$(OATPP_VERSION))
 OATPP_LICENSE = Apache-2.0
 OATPP_LICENSE_FILES = LICENSE
-OATPP_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF
+OATPP_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF -DOATPP_BUILD_TESTS=OFF
 OATPP_INSTALL_STAGING = YES
 # Only builds a static lib and headers
 OATPP_INSTALL_TARGET = NO