diff mbox series

[1/1] package/linux-pam: select libxcrypt with glibc

Message ID 20240404205548.1859771-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/linux-pam: select libxcrypt with glibc | expand

Commit Message

Fabrice Fontaine April 4, 2024, 8:55 p.m. UTC
Fix the following build failure raised since bump of glibc to version
2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97:

/home/autobuild/autobuild/instance-6/output-1/per-package/linux-pam/host/bin/../lib/gcc/or1k-buildroot-linux-gnu/13.2.0/../../../../or1k-buildroot-linux-gnu/bin/ld: .libs/pam_pwhistory_la-opasswd.o: in function `compare_password':
opasswd.c:(.text+0x26c): undefined reference to `crypt'

Fixes: b5680f53d60acf8ff6010082f873438a39bd5d97
 - http://autobuild.buildroot.org/results/e17911978febb7b25112940a7c40037b3f98d491

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/linux-pam/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN April 7, 2024, 8:52 a.m. UTC | #1
Fabrice, All,

On 2024-04-04 22:55 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since bump of glibc to version
> 2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97:
> 
> /home/autobuild/autobuild/instance-6/output-1/per-package/linux-pam/host/bin/../lib/gcc/or1k-buildroot-linux-gnu/13.2.0/../../../../or1k-buildroot-linux-gnu/bin/ld: .libs/pam_pwhistory_la-opasswd.o: in function `compare_password':
> opasswd.c:(.text+0x26c): undefined reference to `crypt'
> 
> Fixes: b5680f53d60acf8ff6010082f873438a39bd5d97
>  - http://autobuild.buildroot.org/results/e17911978febb7b25112940a7c40037b3f98d491
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/linux-pam/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/linux-pam/Config.in b/package/linux-pam/Config.in
> index b17716f2f7..c8aca97ac6 100644
> --- a/package/linux-pam/Config.in
> +++ b/package/linux-pam/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_LINUX_PAM
>  	depends on BR2_USE_MMU # fork()
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
>  	select BR2_PACKAGE_FLEX
> +	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
>  	help
>  	  A Security Framework that Provides Authentication for
>  	  Applications
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/linux-pam/Config.in b/package/linux-pam/Config.in
index b17716f2f7..c8aca97ac6 100644
--- a/package/linux-pam/Config.in
+++ b/package/linux-pam/Config.in
@@ -6,6 +6,7 @@  config BR2_PACKAGE_LINUX_PAM
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
 	select BR2_PACKAGE_FLEX
+	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
 	help
 	  A Security Framework that Provides Authentication for
 	  Applications