| Message ID | 20240317141438.809626-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/privoxy: fix build with root | expand |
On 17/03/2024 15:14, Fabrice Fontaine wrote: > Fix the following build failure when the configuration files are > installed as root: > > id: 'privoxy': no such user > ****************************************************************** > WARNING! WARNING! installing config files as root! > It is strongly recommended to run privoxy as a non-root user, > and to install the config files as that user and/or group! > Please read INSTALL, and create a privoxy user and group! > ******************************************************************* > make[1]: *** [GNUmakefile:861: install] Error 1 > > This failure is probably raised since the addition of the package in > commit f8a263fe361ab37ec6765b9ff6478c3b15e3d139 and > https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=26baf6bcc0b5db47b8cf5c55eece0614712b5180 > > Fixes: > - http://autobuild.buildroot.org/results/28d8ca6f0e2d81d62196a0958c9274ad2c8c9871 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Applied to master, thanks. Regards, Arnout > --- > ...on-t-exit-if-configuration-files-are.patch | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch > > diff --git a/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch b/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch > new file mode 100644 > index 0000000000..e04d191ce0 > --- /dev/null > +++ b/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch > @@ -0,0 +1,30 @@ > +From 4b3b267db159dc23314de3062859481b7c397e32 Mon Sep 17 00:00:00 2001 > +From: Fabrice Fontaine <fontaine.fabrice@gmail.com> > +Date: Sun, 17 Mar 2024 12:36:31 +0100 > +Subject: [PATCH] GNUmakefile.in: Don't exit if configuration files are > + installed as root > + > +... as this can be considered acceptable when cross-compiling > +Privoxy inside an autobuilder with only a root user. > + > +Upstream: https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=4b3b267db159dc23314de3062859481b7c397e32 > +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > +--- > + GNUmakefile.in | 1 - > + 1 file changed, 1 deletion(-) > + > +diff --git a/GNUmakefile.in b/GNUmakefile.in > +index 04cceb15..cf79aae1 100644 > +--- a/GNUmakefile.in > ++++ b/GNUmakefile.in > +@@ -927,7 +927,6 @@ install: CONF_DEST LOG_DEST PID_DEST check_doc GROUP_T > + $(ECHO) " and to install the config files as that user and/or group!" ;\ > + $(ECHO) " Please read INSTALL, and create a privoxy user and group!" ;\ > + $(ECHO) "*******************************************************************" ;\ > +- exit 1 ;\ > + fi ;\ > + else \ > + GROUP_T=$(GROUP) ;\ > +-- > +2.39.2 > +
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > Fix the following build failure when the configuration files are > installed as root: > id: 'privoxy': no such user > ****************************************************************** > WARNING! WARNING! installing config files as root! > It is strongly recommended to run privoxy as a non-root user, > and to install the config files as that user and/or group! > Please read INSTALL, and create a privoxy user and group! > ******************************************************************* > make[1]: *** [GNUmakefile:861: install] Error 1 > This failure is probably raised since the addition of the package in > commit f8a263fe361ab37ec6765b9ff6478c3b15e3d139 and > https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=26baf6bcc0b5db47b8cf5c55eece0614712b5180 > Fixes: > - http://autobuild.buildroot.org/results/28d8ca6f0e2d81d62196a0958c9274ad2c8c9871 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks.
diff --git a/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch b/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch new file mode 100644 index 0000000000..e04d191ce0 --- /dev/null +++ b/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch @@ -0,0 +1,30 @@ +From 4b3b267db159dc23314de3062859481b7c397e32 Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <fontaine.fabrice@gmail.com> +Date: Sun, 17 Mar 2024 12:36:31 +0100 +Subject: [PATCH] GNUmakefile.in: Don't exit if configuration files are + installed as root + +... as this can be considered acceptable when cross-compiling +Privoxy inside an autobuilder with only a root user. + +Upstream: https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=4b3b267db159dc23314de3062859481b7c397e32 +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> +--- + GNUmakefile.in | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/GNUmakefile.in b/GNUmakefile.in +index 04cceb15..cf79aae1 100644 +--- a/GNUmakefile.in ++++ b/GNUmakefile.in +@@ -927,7 +927,6 @@ install: CONF_DEST LOG_DEST PID_DEST check_doc GROUP_T + $(ECHO) " and to install the config files as that user and/or group!" ;\ + $(ECHO) " Please read INSTALL, and create a privoxy user and group!" ;\ + $(ECHO) "*******************************************************************" ;\ +- exit 1 ;\ + fi ;\ + else \ + GROUP_T=$(GROUP) ;\ +-- +2.39.2 +
Fix the following build failure when the configuration files are installed as root: id: 'privoxy': no such user ****************************************************************** WARNING! WARNING! installing config files as root! It is strongly recommended to run privoxy as a non-root user, and to install the config files as that user and/or group! Please read INSTALL, and create a privoxy user and group! ******************************************************************* make[1]: *** [GNUmakefile:861: install] Error 1 This failure is probably raised since the addition of the package in commit f8a263fe361ab37ec6765b9ff6478c3b15e3d139 and https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=26baf6bcc0b5db47b8cf5c55eece0614712b5180 Fixes: - http://autobuild.buildroot.org/results/28d8ca6f0e2d81d62196a0958c9274ad2c8c9871 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- ...on-t-exit-if-configuration-files-are.patch | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch