| Message ID | 20240316084335.20839-2-bernd@kuhls.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/5] {toolchain, linux-headers}: add support for 6.7 headers | expand |
On 16/03/2024 09:43, Bernd Kuhls wrote: > For details see https://bugs.busybox.net/show_bug.cgi?id=15934 I'm a bit afraid to apply this. Hopefully the issue will be fixed at some point in busybox; then, we should probably revert this patch (though honestly I don't know what tc is doing in the minimal config...). Regards, Arnout > > Signed-off-by: Bernd Kuhls <bernd@kuhls.net> > --- > package/busybox/busybox-minimal.config | 3 +-- > package/busybox/busybox.config | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/package/busybox/busybox-minimal.config b/package/busybox/busybox-minimal.config > index 1e7ad1d357..5d2a30806a 100644 > --- a/package/busybox/busybox-minimal.config > +++ b/package/busybox/busybox-minimal.config > @@ -955,8 +955,7 @@ CONFIG_PING=y > CONFIG_ROUTE=y > # CONFIG_SLATTACH is not set > # CONFIG_SSL_CLIENT is not set > -CONFIG_TC=y > -CONFIG_FEATURE_TC_INGRESS=y > +# CONFIG_TC is not set > # CONFIG_TCPSVD is not set > # CONFIG_UDPSVD is not set > CONFIG_TELNET=y > diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config > index 6e8bd2799d..cfd16172fa 100644 > --- a/package/busybox/busybox.config > +++ b/package/busybox/busybox.config > @@ -968,8 +968,7 @@ CONFIG_FEATURE_FANCY_PING=y > CONFIG_ROUTE=y > # CONFIG_SLATTACH is not set > # CONFIG_SSL_CLIENT is not set > -CONFIG_TC=y > -CONFIG_FEATURE_TC_INGRESS=y > +# CONFIG_TC is not set > # CONFIG_TCPSVD is not set > # CONFIG_UDPSVD is not set > CONFIG_TELNET=y
On 16/03/2024 20:25, Arnout Vandecappelle wrote: > > > On 16/03/2024 09:43, Bernd Kuhls wrote: >> For details see https://bugs.busybox.net/show_bug.cgi?id=15934 > > I'm a bit afraid to apply this. Hopefully the issue will be fixed at some > point in busybox; then, we should probably revert this patch (though honestly > I don't know what tc is doing in the minimal config...). I didn't apply this one nor the following two. I'm hoping the other maintainers can pipe up with ideas of how to best deal with this? Regards, Arnout > > Regards, > Arnout > >> >> Signed-off-by: Bernd Kuhls <bernd@kuhls.net> >> --- >> package/busybox/busybox-minimal.config | 3 +-- >> package/busybox/busybox.config | 3 +-- >> 2 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/package/busybox/busybox-minimal.config >> b/package/busybox/busybox-minimal.config >> index 1e7ad1d357..5d2a30806a 100644 >> --- a/package/busybox/busybox-minimal.config >> +++ b/package/busybox/busybox-minimal.config >> @@ -955,8 +955,7 @@ CONFIG_PING=y >> CONFIG_ROUTE=y >> # CONFIG_SLATTACH is not set >> # CONFIG_SSL_CLIENT is not set >> -CONFIG_TC=y >> -CONFIG_FEATURE_TC_INGRESS=y >> +# CONFIG_TC is not set >> # CONFIG_TCPSVD is not set >> # CONFIG_UDPSVD is not set >> CONFIG_TELNET=y >> diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config >> index 6e8bd2799d..cfd16172fa 100644 >> --- a/package/busybox/busybox.config >> +++ b/package/busybox/busybox.config >> @@ -968,8 +968,7 @@ CONFIG_FEATURE_FANCY_PING=y >> CONFIG_ROUTE=y >> # CONFIG_SLATTACH is not set >> # CONFIG_SSL_CLIENT is not set >> -CONFIG_TC=y >> -CONFIG_FEATURE_TC_INGRESS=y >> +# CONFIG_TC is not set >> # CONFIG_TCPSVD is not set >> # CONFIG_UDPSVD is not set >> CONFIG_TELNET=y
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes: > On 16/03/2024 20:25, Arnout Vandecappelle wrote: >> >> >> On 16/03/2024 09:43, Bernd Kuhls wrote: >>> For details see https://bugs.busybox.net/show_bug.cgi?id=15934 >> >> I'm a bit afraid to apply this. Hopefully the issue will be fixed >> at some point in busybox; then, we should probably revert this patch >> (though honestly I don't know what tc is doing in the minimal >> config...). > I didn't apply this one nor the following two. I'm hoping the other > maintainers can pipe up with ideas of how to best deal with this? I also don't think having tc enabled by default makes a lot of sense. Notice that Uwe recently posted a patch upstream to fix the build issue: http://lists.busybox.net/pipermail/busybox/2024-March/090678.html
On 24/03/2024 18:45, Peter Korsgaard wrote: >>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes: > > > On 16/03/2024 20:25, Arnout Vandecappelle wrote: > >> > >> > >> On 16/03/2024 09:43, Bernd Kuhls wrote: > >>> For details see https://bugs.busybox.net/show_bug.cgi?id=15934 > >> > >> I'm a bit afraid to apply this. Hopefully the issue will be fixed > >> at some point in busybox; then, we should probably revert this patch > >> (though honestly I don't know what tc is doing in the minimal > >> config...). > > > > I didn't apply this one nor the following two. I'm hoping the other > > maintainers can pipe up with ideas of how to best deal with this? > > I also don't think having tc enabled by default makes a lot of Good point! I'll apply this after all then, with an updated commit log. Regards, Arnout > sense. Notice that Uwe recently posted a patch upstream to fix the build > issue: > > http://lists.busybox.net/pipermail/busybox/2024-March/090678.html >
On 16/03/2024 09:43, Bernd Kuhls wrote: > For details see https://bugs.busybox.net/show_bug.cgi?id=15934 > > Signed-off-by: Bernd Kuhls <bernd@kuhls.net> As mentioned, patches 2, 3 and 4 are applied to master now as well. Thanks! Regards, Arnout > --- > package/busybox/busybox-minimal.config | 3 +-- > package/busybox/busybox.config | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/package/busybox/busybox-minimal.config b/package/busybox/busybox-minimal.config > index 1e7ad1d357..5d2a30806a 100644 > --- a/package/busybox/busybox-minimal.config > +++ b/package/busybox/busybox-minimal.config > @@ -955,8 +955,7 @@ CONFIG_PING=y > CONFIG_ROUTE=y > # CONFIG_SLATTACH is not set > # CONFIG_SSL_CLIENT is not set > -CONFIG_TC=y > -CONFIG_FEATURE_TC_INGRESS=y > +# CONFIG_TC is not set > # CONFIG_TCPSVD is not set > # CONFIG_UDPSVD is not set > CONFIG_TELNET=y > diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config > index 6e8bd2799d..cfd16172fa 100644 > --- a/package/busybox/busybox.config > +++ b/package/busybox/busybox.config > @@ -968,8 +968,7 @@ CONFIG_FEATURE_FANCY_PING=y > CONFIG_ROUTE=y > # CONFIG_SLATTACH is not set > # CONFIG_SSL_CLIENT is not set > -CONFIG_TC=y > -CONFIG_FEATURE_TC_INGRESS=y > +# CONFIG_TC is not set > # CONFIG_TCPSVD is not set > # CONFIG_UDPSVD is not set > CONFIG_TELNET=y
diff --git a/package/busybox/busybox-minimal.config b/package/busybox/busybox-minimal.config index 1e7ad1d357..5d2a30806a 100644 --- a/package/busybox/busybox-minimal.config +++ b/package/busybox/busybox-minimal.config @@ -955,8 +955,7 @@ CONFIG_PING=y CONFIG_ROUTE=y # CONFIG_SLATTACH is not set # CONFIG_SSL_CLIENT is not set -CONFIG_TC=y -CONFIG_FEATURE_TC_INGRESS=y +# CONFIG_TC is not set # CONFIG_TCPSVD is not set # CONFIG_UDPSVD is not set CONFIG_TELNET=y diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config index 6e8bd2799d..cfd16172fa 100644 --- a/package/busybox/busybox.config +++ b/package/busybox/busybox.config @@ -968,8 +968,7 @@ CONFIG_FEATURE_FANCY_PING=y CONFIG_ROUTE=y # CONFIG_SLATTACH is not set # CONFIG_SSL_CLIENT is not set -CONFIG_TC=y -CONFIG_FEATURE_TC_INGRESS=y +# CONFIG_TC is not set # CONFIG_TCPSVD is not set # CONFIG_UDPSVD is not set CONFIG_TELNET=y
For details see https://bugs.busybox.net/show_bug.cgi?id=15934 Signed-off-by: Bernd Kuhls <bernd@kuhls.net> --- package/busybox/busybox-minimal.config | 3 +-- package/busybox/busybox.config | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)