diff mbox series

[1/2] package/zic: add hash for existing patch

Message ID 20240228145642.436509-1-christian@klarinett.li
State Superseded
Headers show
Series [1/2] package/zic: add hash for existing patch | expand

Commit Message

Christian Hitz Feb. 28, 2024, 2:56 p.m. UTC 
From: Christian Hitz <christian.hitz@bbv.ch>

Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
---
 package/zic/zic.hash | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni March 26, 2024, 2:43 p.m. UTC | #1 
Hello Christian,

On Wed, 28 Feb 2024 15:56:40 +0100
Christian Hitz via buildroot <buildroot@buildroot.org> wrote:

> From: Christian Hitz <christian.hitz@bbv.ch>
> 
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>

Thanks for the patch. However, could you explain why you think this is
needed? We only have hashes for files downloaded by Buildroot. This
patch is part of Buildroot itself, and we don't verify hashes of
patches part of Buildroot itself.

Am I missing something obvious here? I don't even think we have some
logic to check the hashes of patches stored in Buildroot itself.

Could you provide more details on what you're trying to achieve?

Thanks!

Thomas
yegorslists--- via buildroot March 26, 2024, 4:06 p.m. UTC | #2 
Hello Thomas

Am 2024-03-26 15:43, schrieb Thomas Petazzoni:
> Hello Christian,
> 
> On Wed, 28 Feb 2024 15:56:40 +0100
> Christian Hitz via buildroot <buildroot@buildroot.org> wrote:
> 
>> From: Christian Hitz <christian.hitz@bbv.ch>
>> 
>> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
> 
> Thanks for the patch. However, could you explain why you think this is
> needed? We only have hashes for files downloaded by Buildroot. This
> patch is part of Buildroot itself, and we don't verify hashes of
> patches part of Buildroot itself.
> 
> Am I missing something obvious here? I don't even think we have some
> logic to check the hashes of patches stored in Buildroot itself.
> 
> Could you provide more details on what you're trying to achieve?

I believe to remember, that, at the time, I had issues with legal-info
and this hash. However, re-testing shows that it's really not needed.

I'll drop this part in v2.

Thanks and Regards,
Christian
diff mbox series

Patch

diff --git a/package/zic/zic.hash b/package/zic/zic.hash
index a2720a27ba..f2a48b1d2e 100644
--- a/package/zic/zic.hash
+++ b/package/zic/zic.hash
@@ -2,3 +2,4 @@ 
 sha512  fa18bae9c0e7c061bc9d5f5f2eb9967f0e4ddb2baafdee9887fa30cd0c60f4aa6f21eacffb17df0d59d26ff54d08c5dcefa98159309eba497e86443624913a82  tzcode2023c.tar.gz
 # Locally computed:
 sha256  0613408568889f5739e5ae252b722a2659c02002839ad970a63dc5e9174b27cf  LICENSE
+sha256  9e3c665b2cf8ad1eeb3458ec736e644e3d0c86a5e2fa8bcc4f34d72317511958  0001-remove-dependency-check-on-version-file.patch