diff mbox series

[1/1] Revert "package/crun: allow building with uClibc"

Message ID 20240213210523.166319-1-fontaine.fabrice@gmail.com
State New
Headers show
Series [1/1] Revert "package/crun: allow building with uClibc" | expand

Commit Message

Fabrice Fontaine Feb. 13, 2024, 9:05 p.m. UTC
This reverts commit 223596c75d73a7eb29152235d3c5d9bf53bd58f5 indeed
fexecve is only available since
https://github.com/wbx-github/uclibc-ng/commit/858ffad217076227089cc17eb832db0bd1497792
resulting in the following build failure with uclibc < 1.0.33:

/home/thomas/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arceb-snps-linux-uclibc/9.2.1/../../../../arceb-snps-linux-uclibc/bin/ld: libcrun_testing.a(libcrun_testing_a-cloned_binary.o): in function `ensure_cloned_binary':
/home/thomas/autobuild/instance-3/output-1/build/crun-1.8.4/src/libcrun/cloned_binary.c:540: undefined reference to `fexecve'

Fixes: 223596c75d73a7eb29152235d3c5d9bf53bd58f5
 - http://autobuild.buildroot.org/results/9c4488d5d26e575f39bcbaed8e0793ed1cdb8cd5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/crun/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/package/crun/Config.in b/package/crun/Config.in
index f6a1ec7c66..bbed21817e 100644
--- a/package/crun/Config.in
+++ b/package/crun/Config.in
@@ -1,8 +1,9 @@ 
 config BR2_PACKAGE_CRUN
 	bool "crun"
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
-	select BR2_PACKAGE_ARGP_STANDALONE if !BR2_TOOLCHAIN_USES_GLIBC
+	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_YAJL # libocispec
 	help
 	  crun is a fast and low-memory OCI Container Runtime in C.