diff mbox series

Bump driver version. Update driver for kernel 6.7+. Fix build failures: x86_64 http://autobuild.buildroot.net/results/b4f34e622410a59943fa763148da1115cea0932d

Message ID 20240131130329.142721-1-adeep@lexina.in
State Superseded
Headers show
Series Bump driver version. Update driver for kernel 6.7+. Fix build failures: x86_64 http://autobuild.buildroot.net/results/b4f34e622410a59943fa763148da1115cea0932d | expand

Commit Message

Viacheslav Jan. 31, 2024, 1:03 p.m. UTC 
From: Viacheslav Bocharov <adeep@lexina.in>

Signed-off-by: Viacheslav Bocharov <adeep@lexina.in>
---
 package/rtl8822cs/rtl8822cs.hash | 2 +-
 package/rtl8822cs/rtl8822cs.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Giulio Benetti Jan. 31, 2024, 1:51 p.m. UTC | #1 
Hi Viacheslav,

thank you for the contribution!

Can you please reword commit log like my pending patch[0]?

This is because Subject can't be that log. You need to split
into Subject and body.

Also Subject should be like:
"package/rtl8822cs: Bump driver to version 2024-..."

Also, when pointing you're fixing a failure you have to use:
Fixes:
http://autobuild.buildroot.net/results/b4f34e622410a59943fa763148da1115cea0932d

You can find explanation in Buildroot manual[1].

So can you please send a V2 patch with requested changes in commit log?

Thank you
Best regards

[0]: 
https://patchwork.ozlabs.org/project/buildroot/patch/20240130110504.559989-1-giulio.benetti@benettiengineering.com/

[1]: 
https://buildroot.org/downloads/manual/manual.html#_analyzing_and_fixing_autobuild_failures
Viacheslav Jan. 31, 2024, 2:09 p.m. UTC | #2 
Hi!

Certainly, it was just an unintentional twitch of my hand while editing 
the message :)

31/01/2024 16.51, Giulio Benetti wrote:
> Hi Viacheslav,
> 
> thank you for the contribution!
> 
> Can you please reword commit log like my pending patch[0]?
> 
> This is because Subject can't be that log. You need to split
> into Subject and body.
> 
> Also Subject should be like:
> "package/rtl8822cs: Bump driver to version 2024-..."
> 
> Also, when pointing you're fixing a failure you have to use:
> Fixes:
> http://autobuild.buildroot.net/results/b4f34e622410a59943fa763148da1115cea0932d
> 
> You can find explanation in Buildroot manual[1].
> 
> So can you please send a V2 patch with requested changes in commit log?
> 
> Thank you
> Best regards
> 
> [0]: 
> https://patchwork.ozlabs.org/project/buildroot/patch/20240130110504.559989-1-giulio.benetti@benettiengineering.com/
> 
> [1]: 
> https://buildroot.org/downloads/manual/manual.html#_analyzing_and_fixing_autobuild_failures

--
Viacheslav
diff mbox series

Patch

diff --git a/package/rtl8822cs/rtl8822cs.hash b/package/rtl8822cs/rtl8822cs.hash
index 4b44512913..34bcc412ce 100644
--- a/package/rtl8822cs/rtl8822cs.hash
+++ b/package/rtl8822cs/rtl8822cs.hash
@@ -1,2 +1,2 @@ 
 # Locally calculated
-sha256  b3b8543ff6d6d602ffaf60342969830edc8205917b96d004f84ed79524894dc7  rtl8822cs-2e4e99ae1502b173a938357dc1087e49475b26ed.tar.gz
+sha256  d61fff0ee8b4219a6441791ff26be1b8c49ef8b2ca78345bf12b7a0541f498e9  rtl8822cs-fda6cd263e89567272060e6182a39aee20b894c4.tar.gz
diff --git a/package/rtl8822cs/rtl8822cs.mk b/package/rtl8822cs/rtl8822cs.mk
index 6036acb864..dbdc7d84bf 100644
--- a/package/rtl8822cs/rtl8822cs.mk
+++ b/package/rtl8822cs/rtl8822cs.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-RTL8822CS_VERSION = 2e4e99ae1502b173a938357dc1087e49475b26ed
+RTL8822CS_VERSION = fda6cd263e89567272060e6182a39aee20b894c4
 RTL8822CS_SITE = $(call github,jethome-ru,rtl88x2cs,$(RTL8822CS_VERSION))
 RTL8822CS_LICENSE = GPL-2.0