diff mbox series

package/uuu: fix build failure with host gcc 13.x

Message ID 20240122223037.889955-1-giulio.benetti@benettiengineering.com
State Accepted
Headers show
Series package/uuu: fix build failure with host gcc 13.x | expand

Commit Message

Giulio Benetti Jan. 22, 2024, 10:30 p.m. UTC 
From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>

With gcc version >= 13.x stdint.h must be explicitly included according to
[0] so add local patch to explicitly include stdint.h.

[0]: https://gcc.gnu.org/gcc-13/porting_to.html

Fixes:
still not happened

Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/uuu/0001-Fix-missing-references.patch | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 package/uuu/0001-Fix-missing-references.patch

Comments

Dario Binacchi Jan. 23, 2024, 8:06 a.m. UTC | #1 
Hi Giulio,

On Mon, Jan 22, 2024 at 11:30 PM Giulio Benetti
<giulio.benetti@benettiengineering.com> wrote:
>
> From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
>
> With gcc version >= 13.x stdint.h must be explicitly included according to
> [0] so add local patch to explicitly include stdint.h.
>
> [0]: https://gcc.gnu.org/gcc-13/porting_to.html
>
> Fixes:
> still not happened
>
> Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/uuu/0001-Fix-missing-references.patch | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 package/uuu/0001-Fix-missing-references.patch
>
> diff --git a/package/uuu/0001-Fix-missing-references.patch b/package/uuu/0001-Fix-missing-references.patch
> new file mode 100644
> index 0000000000..140c9755c7
> --- /dev/null
> +++ b/package/uuu/0001-Fix-missing-references.patch
> @@ -0,0 +1,40 @@
> +From 24fd043225903247f71ac10666d820277c0b10b1 Mon Sep 17 00:00:00 2001
> +From: nixgnauhcuy <nixgnauhcuy@gmail.com>
> +Date: Tue, 9 May 2023 14:32:33 +0800
> +Subject: [PATCH] Fix missing references
> +
> +Upstream: https://github.com/nxp-imx/mfgtools/commit/24fd043225903247f71ac10666d820277c0b10b1
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
> + libuuu/libcomm.h | 1 +
> + uuu/buildincmd.h | 1 +
> + 2 files changed, 2 insertions(+)
> +
> +diff --git a/libuuu/libcomm.h b/libuuu/libcomm.h
> +index 0afdfa3..38d622d 100644
> +--- a/libuuu/libcomm.h
> ++++ b/libuuu/libcomm.h
> +@@ -28,6 +28,7 @@
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + */
> ++#include <stdint.h>
> + #include <string>
> + #include <stdarg.h>
> + #include <locale>
> +diff --git a/uuu/buildincmd.h b/uuu/buildincmd.h
> +index 9415117..46286cc 100644
> +--- a/uuu/buildincmd.h
> ++++ b/uuu/buildincmd.h
> +@@ -31,6 +31,7 @@
> +
> + #pragma once
> +
> ++#include <stdint.h>
> + #include <map>
> + #include <string>
> + #include <vector>
> +--
> +2.34.1
> +
> --
> 2.34.1
>

Reviewed-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Thanks and regards,
Dario
Yann E. MORIN Jan. 23, 2024, 9:28 p.m. UTC | #2 
Giulio, All,

On 2024-01-22 23:30 +0100, Giulio Benetti spake thusly:
> From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
> 
> With gcc version >= 13.x stdint.h must be explicitly included according to
> [0] so add local patch to explicitly include stdint.h.

When I read "local patch", it is not immediately obvious that this is a
backport, or that the patch has been upstreamd, and I am wary of such
situations.

But here, this is an actual backport, so a better phrasing would have
been "so backport a commit that...", which I have done when applying.

> [0]: https://gcc.gnu.org/gcc-13/porting_to.html
> 
> Fixes:
> still not happened
> 
> Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/uuu/0001-Fix-missing-references.patch | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 package/uuu/0001-Fix-missing-references.patch
> 
> diff --git a/package/uuu/0001-Fix-missing-references.patch b/package/uuu/0001-Fix-missing-references.patch
> new file mode 100644
> index 0000000000..140c9755c7
> --- /dev/null
> +++ b/package/uuu/0001-Fix-missing-references.patch
> @@ -0,0 +1,40 @@
> +From 24fd043225903247f71ac10666d820277c0b10b1 Mon Sep 17 00:00:00 2001
> +From: nixgnauhcuy <nixgnauhcuy@gmail.com>
> +Date: Tue, 9 May 2023 14:32:33 +0800
> +Subject: [PATCH] Fix missing references
> +
> +Upstream: https://github.com/nxp-imx/mfgtools/commit/24fd043225903247f71ac10666d820277c0b10b1
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
> + libuuu/libcomm.h | 1 +
> + uuu/buildincmd.h | 1 +
> + 2 files changed, 2 insertions(+)
> +
> +diff --git a/libuuu/libcomm.h b/libuuu/libcomm.h
> +index 0afdfa3..38d622d 100644
> +--- a/libuuu/libcomm.h
> ++++ b/libuuu/libcomm.h
> +@@ -28,6 +28,7 @@
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + */
> ++#include <stdint.h>
> + #include <string>
> + #include <stdarg.h>
> + #include <locale>
> +diff --git a/uuu/buildincmd.h b/uuu/buildincmd.h
> +index 9415117..46286cc 100644
> +--- a/uuu/buildincmd.h
> ++++ b/uuu/buildincmd.h
> +@@ -31,6 +31,7 @@
> + 
> + #pragma once
> + 
> ++#include <stdint.h>
> + #include <map>
> + #include <string>
> + #include <vector>
> +-- 
> +2.34.1
> +
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard Feb. 4, 2024, 9:40 p.m. UTC | #3 
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Giulio, All,
 > On 2024-01-22 23:30 +0100, Giulio Benetti spake thusly:
 >> From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
 >> 
 >> With gcc version >= 13.x stdint.h must be explicitly included according to
 >> [0] so add local patch to explicitly include stdint.h.

 > When I read "local patch", it is not immediately obvious that this is a
 > backport, or that the patch has been upstreamd, and I am wary of such
 > situations.

 > But here, this is an actual backport, so a better phrasing would have
 > been "so backport a commit that...", which I have done when applying.

 >> [0]: https://gcc.gnu.org/gcc-13/porting_to.html
 >> 
 >> Fixes:
 >> still not happened
 >> 
 >> Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
 >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

 > Applied to master, thanks.

Committed to 2023.02.x (where it does apply), thanks.
diff mbox series

Patch

diff --git a/package/uuu/0001-Fix-missing-references.patch b/package/uuu/0001-Fix-missing-references.patch
new file mode 100644
index 0000000000..140c9755c7
--- /dev/null
+++ b/package/uuu/0001-Fix-missing-references.patch
@@ -0,0 +1,40 @@ 
+From 24fd043225903247f71ac10666d820277c0b10b1 Mon Sep 17 00:00:00 2001
+From: nixgnauhcuy <nixgnauhcuy@gmail.com>
+Date: Tue, 9 May 2023 14:32:33 +0800
+Subject: [PATCH] Fix missing references
+
+Upstream: https://github.com/nxp-imx/mfgtools/commit/24fd043225903247f71ac10666d820277c0b10b1
+
+Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
+---
+ libuuu/libcomm.h | 1 +
+ uuu/buildincmd.h | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/libuuu/libcomm.h b/libuuu/libcomm.h
+index 0afdfa3..38d622d 100644
+--- a/libuuu/libcomm.h
++++ b/libuuu/libcomm.h
+@@ -28,6 +28,7 @@
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ */
++#include <stdint.h>
+ #include <string>
+ #include <stdarg.h>
+ #include <locale>
+diff --git a/uuu/buildincmd.h b/uuu/buildincmd.h
+index 9415117..46286cc 100644
+--- a/uuu/buildincmd.h
++++ b/uuu/buildincmd.h
+@@ -31,6 +31,7 @@
+ 
+ #pragma once
+ 
++#include <stdint.h>
+ #include <map>
+ #include <string>
+ #include <vector>
+-- 
+2.34.1
+