package/linux-firmware: add scripts for Amlogic

Add scripts for installing Amlogic firmware.

Signed-off-by: Yang Li <yang.li@amlogic.com>
---
 package/linux-firmware/linux-firmware.mk | 6 ++++++
 1 file changed, 6 insertions(+)

Hello,

On Fri, 19 Jan 2024 11:15:02 +0800
Yang Li <yang.li@amlogic.com> wrote:

> Add scripts for installing Amlogic firmware.
> 
> Signed-off-by: Yang Li <yang.li@amlogic.com>

Thanks for your contribution! See some comments below.

> ---
>  package/linux-firmware/linux-firmware.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
> index c09dbc523e..735d4b7e53 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -856,6 +856,12 @@ LINUX_FIRMWARE_FILES += v4l-cx23885-avcore-01.fw
>  # which is installed unconditionally
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)

This option does not exist. Probably you forgot to add some changes in
package/linux-firmware/Config.in?

Also, usually, our options are not per vendor, but more per device or
class of devices. Which devices are supported by those 2 bluetooth
firmware files?

Best regards,

Thomas

Thomas, All,

On 2024-01-19 12:23 +0100, Thomas Petazzoni via buildroot spake thusly:
> On Fri, 19 Jan 2024 11:15:02 +0800
> Yang Li <yang.li@amlogic.com> wrote:
> > Add scripts for installing Amlogic firmware.
> > +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
> This option does not exist. Probably you forgot to add some changes in
> package/linux-firmware/Config.in?

In fact, this has already been applied by Yann@home as of commit:
    https://gitlab.com/buildroot.org/buildroot/-/commit/104b0fee839d3e4885329e77d1b8d553d552fb8e

I thought the review comment was explicit enough, though:

    https://lore.kernel.org/buildroot/ZaOiZNVvO7OuK3sC@landeda/

    Applied to master with the above fixes, thanks.

> Also, usually, our options are not per vendor, but more per device or
> class of devices. Which devices are supported by those 2 bluetooth
> firmware files?

I also changed the Config.in entry for the same reason you noticed.

I however assumed that they were Amlogic Bluettoth chipsets, as per the
path of the binary blob in linux-firmware:
    amlogic/bluetooth/*.bin

The path is 'amlogic', so it made sense to name the Config.oin entry
BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC and to have the prompt list it as
"Amlogic SOC Bluetooth".

If that was not correct, we can change it, though...

Regards,
Yann E. MORIN.

Hi all

On 1/19/24 20:33, yann.morin@orange.com wrote:

> [你通常不会收到来自 yann.morin@orange.com 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
>
> Thomas, All,
>
> On 2024-01-19 12:23 +0100, Thomas Petazzoni via buildroot spake thusly:
>> On Fri, 19 Jan 2024 11:15:02 +0800
>> Yang Li <yang.li@amlogic.com> wrote:
>>> Add scripts for installing Amlogic firmware.
>>> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
>> This option does not exist. Probably you forgot to add some changes in
>> package/linux-firmware/Config.in?
> In fact, this has already been applied by Yann@home as of commit:
>      https://gitlab.com/buildroot.org/buildroot/-/commit/104b0fee839d3e4885329e77d1b8d553d552fb8e
>
> I thought the review comment was explicit enough, though:
>
>      https://lore.kernel.org/buildroot/ZaOiZNVvO7OuK3sC@landeda/
>
>      Applied to master with the above fixes, thanks.
>
>> Also, usually, our options are not per vendor, but more per device or
>> class of devices. Which devices are supported by those 2 bluetooth
>> firmware files?
> I also changed the Config.in entry for the same reason you noticed.
>
> I however assumed that they were Amlogic Bluettoth chipsets, as per the
> path of the binary blob in linux-firmware:
>      amlogic/bluetooth/*.bin
>
> The path is 'amlogic', so it made sense to name the Config.oin entry
> BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC and to have the prompt list it as
> "Amlogic SOC Bluetooth".
>
> If that was not correct, we can change it, though...

Sorry, it's my fault.

^_^

>
> Regards,
> Yann E. MORIN.
>
> --
>                                          ____________
> .-----------------.--------------------:       _    :------------------.
> |  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
> |                 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
> | +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
> | yann.morin (at) orange.com           |_="    ,--' | / \ HTML MAIL    |
> '--------------------------------------:______/_____:------------------'
>
> ____________________________________________________________________________________________________________
> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
>
> This message and its attachments may contain confidential or privileged information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
> Thank you.