| Message ID | 20231229145025.237058-1-ju.o@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] support/testing: test_python_ml_dtypes: remove BR2_PACKAGE_PYTHON3_ZLIB | expand |
Julien, All, On 2023-12-29 15:50 +0100, Julien Olivain spake thusly: > The test_python_ml_dtypes.py enabled BR2_PACKAGE_PYTHON3_ZLIB=y in its > configuration to workaround the fact that the toolchain used to > testing was tainted with zlib. > > The commit 7e0e6e3 > "toolchain/toolchain-external/toolchain-external-bootlin: update to > 2023.11-1" updated the toolchains which are no longer tainted with > zlib. > > The workaround is no longer needed and this commit removes this > config, for consistency. > > Signed-off-by: Julien Olivain <ju.o@free.fr> Applied to master, thanks. Regards, Yann E. MORIN. > --- > Patch tested on branch master at commit 7e0e6e3 with commands: > > make check-package > ... > 0 warnings generated > > support/testing/run-tests \ > -d dl -o output_folder \ > tests.package.test_python_ml_dtypes > ... > OK > --- > support/testing/tests/package/test_python_ml_dtypes.py | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/support/testing/tests/package/test_python_ml_dtypes.py b/support/testing/tests/package/test_python_ml_dtypes.py > index 8d2369576b..8367107247 100644 > --- a/support/testing/tests/package/test_python_ml_dtypes.py > +++ b/support/testing/tests/package/test_python_ml_dtypes.py > @@ -4,16 +4,9 @@ from tests.package.test_python import TestPythonPackageBase > class TestPythonPy3MlDtypes(TestPythonPackageBase): > __test__ = True > > - # Note: BR2_PACKAGE_PYTHON3_ZLIB=y is needed as a runtime > - # dependency because the Bootlin toolchain used for this test is > - # tainted with zlib (and gets detected by python3/numpy). > - # See commit 8ce33fed "package/gdb: gdbserver does not need zlib". > - # This config entry can be removed as soon as the toolchain is > - # updated without zlib in its sysroot. > config = TestPythonPackageBase.config + \ > """ > BR2_PACKAGE_PYTHON3=y > - BR2_PACKAGE_PYTHON3_ZLIB=y > BR2_PACKAGE_PYTHON_ML_DTYPES=y > """ > sample_scripts = ["tests/package/sample_python_ml_dtypes.py"] > -- > 2.43.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/support/testing/tests/package/test_python_ml_dtypes.py b/support/testing/tests/package/test_python_ml_dtypes.py index 8d2369576b..8367107247 100644 --- a/support/testing/tests/package/test_python_ml_dtypes.py +++ b/support/testing/tests/package/test_python_ml_dtypes.py @@ -4,16 +4,9 @@ from tests.package.test_python import TestPythonPackageBase class TestPythonPy3MlDtypes(TestPythonPackageBase): __test__ = True - # Note: BR2_PACKAGE_PYTHON3_ZLIB=y is needed as a runtime - # dependency because the Bootlin toolchain used for this test is - # tainted with zlib (and gets detected by python3/numpy). - # See commit 8ce33fed "package/gdb: gdbserver does not need zlib". - # This config entry can be removed as soon as the toolchain is - # updated without zlib in its sysroot. config = TestPythonPackageBase.config + \ """ BR2_PACKAGE_PYTHON3=y - BR2_PACKAGE_PYTHON3_ZLIB=y BR2_PACKAGE_PYTHON_ML_DTYPES=y """ sample_scripts = ["tests/package/sample_python_ml_dtypes.py"]
The test_python_ml_dtypes.py enabled BR2_PACKAGE_PYTHON3_ZLIB=y in its configuration to workaround the fact that the toolchain used to testing was tainted with zlib. The commit 7e0e6e3 "toolchain/toolchain-external/toolchain-external-bootlin: update to 2023.11-1" updated the toolchains which are no longer tainted with zlib. The workaround is no longer needed and this commit removes this config, for consistency. Signed-off-by: Julien Olivain <ju.o@free.fr> --- Patch tested on branch master at commit 7e0e6e3 with commands: make check-package ... 0 warnings generated support/testing/run-tests \ -d dl -o output_folder \ tests.package.test_python_ml_dtypes ... OK --- support/testing/tests/package/test_python_ml_dtypes.py | 7 ------- 1 file changed, 7 deletions(-)