diff mbox series

[v4,04/10] package/ncurses: install foot terminfo if foot is selected

Message ID 20231221153620.237439-4-adam.duskett@amarulasolutions.com
State Accepted
Headers show
Series [v4,01/10] package/wlroots: add hwdata and hwdata_pnp_ids as a dependency | expand

Commit Message

Adam Duskett Dec. 21, 2023, 3:36 p.m. UTC
From foot/INSTALL.md:
```
As of ncurses 2021-07-31, ncurses includes a version of foot’s
terminfo. **The recommendation is to use those**, and only install the
terminfo definitions from this git repo if the system’s ncurses
predates 2021-07-31.
```

So it is best to follow the instructions and install the foot terminfo
provided by ncurses.

Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
 package/ncurses/ncurses.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Yann E. MORIN Dec. 24, 2023, 9:49 p.m. UTC | #1
Adam, All,

On 2023-12-21 08:36 -0700, Adam Duskett spake thusly:
> From foot/INSTALL.md:
> ```
> As of ncurses 2021-07-31, ncurses includes a version of foot’s
> terminfo. **The recommendation is to use those**, and only install the
> terminfo definitions from this git repo if the system’s ncurses
> predates 2021-07-31.
> ```
> 
> So it is best to follow the instructions and install the foot terminfo
> provided by ncurses.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/ncurses/ncurses.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
> index 3b805cb1fd..00e1c0d424 100644
> --- a/package/ncurses/ncurses.mk
> +++ b/package/ncurses/ncurses.mk
> @@ -73,6 +73,13 @@ NCURSES_TERMINFO_FILES = \
>  	x/xterm-xfree86 \
>  	$(call qstrip,$(BR2_PACKAGE_NCURSES_ADDITIONAL_TERMINFO))
>  
> +ifeq ($(BR2_PACKAGE_FOOT),y)
> +NCURSES_TERMINFO_FILES += \
> +	f/foot \
> +	f/foot+base \
> +	f/foot-direct
> +endif
> +
>  ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),y)
>  NCURSES_CONF_OPTS += --enable-widec
>  NCURSES_LIB_SUFFIX = w
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
index 3b805cb1fd..00e1c0d424 100644
--- a/package/ncurses/ncurses.mk
+++ b/package/ncurses/ncurses.mk
@@ -73,6 +73,13 @@  NCURSES_TERMINFO_FILES = \
 	x/xterm-xfree86 \
 	$(call qstrip,$(BR2_PACKAGE_NCURSES_ADDITIONAL_TERMINFO))
 
+ifeq ($(BR2_PACKAGE_FOOT),y)
+NCURSES_TERMINFO_FILES += \
+	f/foot \
+	f/foot+base \
+	f/foot-direct
+endif
+
 ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),y)
 NCURSES_CONF_OPTS += --enable-widec
 NCURSES_LIB_SUFFIX = w