| Message ID | 20231118194526.467059-1-adam.duskett@amarulasolutions.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/nodejs: downgrade GCC version requirements to 10 | expand |
Adam, All, On 2023-11-18 12:45 -0700, Adam Duskett spake thusly: > NodeJS requires GCC 10.1. However, GCC 10.1 is the first GCC release. That last part was confusing: "GCC 10.1 is the first GCC release"; surely there have been many GCC releases before 10.1! ;-) I've rewrittent this part to make it explicit it was that "GCC 10.1 is the first release of the GCC 10.x series". > As such, we can safely downgrade the GCC version requirements to 10. > > Tested with: run-tests tests.package.test_nodejs using Debian 11 and > gcc 10.2.1. > > Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/nodejs/Config.in | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in > index 72770095d0..50d1360715 100644 > --- a/package/nodejs/Config.in > +++ b/package/nodejs/Config.in > @@ -7,19 +7,19 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS > depends on BR2_TOOLCHAIN_HAS_SYNC_4 > depends on BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS > > -comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 11, wchar, host gcc >= 11" > +comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 10, wchar, host gcc >= 10" > depends on BR2_USE_MMU > depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS > depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \ > - !BR2_HOST_GCC_AT_LEAST_11 || !BR2_TOOLCHAIN_GCC_AT_LEAST_11 || !BR2_USE_WCHAR > + !BR2_HOST_GCC_AT_LEAST_10 || !BR2_TOOLCHAIN_GCC_AT_LEAST_10 || !BR2_USE_WCHAR > > config BR2_PACKAGE_NODEJS > bool "nodejs" > depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv > depends on BR2_INSTALL_LIBSTDCPP > depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS > - depends on BR2_HOST_GCC_AT_LEAST_11 > - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_11 > + depends on BR2_HOST_GCC_AT_LEAST_10 > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_10 > depends on BR2_USE_WCHAR > # uses fork() > depends on BR2_USE_MMU > -- > 2.42.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in index 72770095d0..50d1360715 100644 --- a/package/nodejs/Config.in +++ b/package/nodejs/Config.in @@ -7,19 +7,19 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_HAS_SYNC_4 depends on BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS -comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 11, wchar, host gcc >= 11" +comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 10, wchar, host gcc >= 10" depends on BR2_USE_MMU depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \ - !BR2_HOST_GCC_AT_LEAST_11 || !BR2_TOOLCHAIN_GCC_AT_LEAST_11 || !BR2_USE_WCHAR + !BR2_HOST_GCC_AT_LEAST_10 || !BR2_TOOLCHAIN_GCC_AT_LEAST_10 || !BR2_USE_WCHAR config BR2_PACKAGE_NODEJS bool "nodejs" depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv depends on BR2_INSTALL_LIBSTDCPP depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS - depends on BR2_HOST_GCC_AT_LEAST_11 - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_11 + depends on BR2_HOST_GCC_AT_LEAST_10 + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_10 depends on BR2_USE_WCHAR # uses fork() depends on BR2_USE_MMU
NodeJS requires GCC 10.1. However, GCC 10.1 is the first GCC release. As such, we can safely downgrade the GCC version requirements to 10. Tested with: run-tests tests.package.test_nodejs using Debian 11 and gcc 10.2.1. Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com> --- package/nodejs/Config.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)