| Message ID | 20231027114700.1904-1-francois.dugast.foss@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] board/licheepi_zero: move board files to their own directory | expand |
François, All, On 2023-10-27 13:46 +0200, Francois Dugast spake thusly: > Group files for board licheepi_zero under a new directory. This is > to prepare for a new board also coming to the licheepi directory. Licheepi-zero is a board by Sipeed, the manufacturer, and we already had a subdir for them, so I moved the board files there rather than introduce the board/licheepi/ sub-dir. Applied to master, thanks. Regards, Yann E. MORIN. > Signed-off-by: Francois Dugast <francois.dugast.foss@gmail.com> > --- > board/licheepi/{ => licheepi_zero}/boot.cmd | 0 > board/licheepi/{ => licheepi_zero}/genimage.cfg | 0 > board/licheepi/{ => licheepi_zero}/readme.txt | 0 > configs/licheepi_zero_defconfig | 4 ++-- > 4 files changed, 2 insertions(+), 2 deletions(-) > rename board/licheepi/{ => licheepi_zero}/boot.cmd (100%) > rename board/licheepi/{ => licheepi_zero}/genimage.cfg (100%) > rename board/licheepi/{ => licheepi_zero}/readme.txt (100%) > > diff --git a/board/licheepi/boot.cmd b/board/licheepi/licheepi_zero/boot.cmd > similarity index 100% > rename from board/licheepi/boot.cmd > rename to board/licheepi/licheepi_zero/boot.cmd > diff --git a/board/licheepi/genimage.cfg b/board/licheepi/licheepi_zero/genimage.cfg > similarity index 100% > rename from board/licheepi/genimage.cfg > rename to board/licheepi/licheepi_zero/genimage.cfg > diff --git a/board/licheepi/readme.txt b/board/licheepi/licheepi_zero/readme.txt > similarity index 100% > rename from board/licheepi/readme.txt > rename to board/licheepi/licheepi_zero/readme.txt > diff --git a/configs/licheepi_zero_defconfig b/configs/licheepi_zero_defconfig > index 0d3115a996..c8f74a7f04 100644 > --- a/configs/licheepi_zero_defconfig > +++ b/configs/licheepi_zero_defconfig > @@ -12,7 +12,7 @@ BR2_TARGET_GENERIC_ISSUE="Welcome to Buildroot for the LicheePi Zero" > BR2_TARGET_GENERIC_GETTY_PORT="ttyS0" > BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y > BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh" > -BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/licheepi/genimage.cfg" > +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/licheepi/licheepi_zero/genimage.cfg" > > # Kernel > BR2_LINUX_KERNEL=y > @@ -45,7 +45,7 @@ BR2_TARGET_UBOOT_FORMAT_CUSTOM=y > BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot-sunxi-with-spl.bin" > BR2_PACKAGE_HOST_UBOOT_TOOLS=y > BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT=y > -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/licheepi/boot.cmd" > +BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/licheepi/licheepi_zero/boot.cmd" > > # Required host utilities for building an SDCard image > BR2_PACKAGE_HOST_DOSFSTOOLS=y > -- > 2.30.2 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Hello François, On Fri, 27 Oct 2023 13:46:59 +0200 Francois Dugast <francois.dugast.foss@gmail.com> wrote: > Group files for board licheepi_zero under a new directory. This is > to prepare for a new board also coming to the licheepi directory. > > Signed-off-by: Francois Dugast <francois.dugast.foss@gmail.com> > --- > board/licheepi/{ => licheepi_zero}/boot.cmd | 0 > board/licheepi/{ => licheepi_zero}/genimage.cfg | 0 > board/licheepi/{ => licheepi_zero}/readme.txt | 0 Could you rename the folder to licheepi-zero instead of licheepi_zero? I would have done it myself while applying if there were no other issues with the patch series, but I have comments on PATCH 2/2. Best regards, Thomas
Hello,
On Sat, 4 Nov 2023 19:38:18 +0100
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Could you rename the folder to licheepi-zero instead of licheepi_zero?
I see you actually sent a newer version, which has been merged, and
this earlier version had not been marked as Superseded in our patch
tracking system. You can therefore ignore my previous e-mail.
Best regards,
Thomas
diff --git a/board/licheepi/boot.cmd b/board/licheepi/licheepi_zero/boot.cmd similarity index 100% rename from board/licheepi/boot.cmd rename to board/licheepi/licheepi_zero/boot.cmd diff --git a/board/licheepi/genimage.cfg b/board/licheepi/licheepi_zero/genimage.cfg similarity index 100% rename from board/licheepi/genimage.cfg rename to board/licheepi/licheepi_zero/genimage.cfg diff --git a/board/licheepi/readme.txt b/board/licheepi/licheepi_zero/readme.txt similarity index 100% rename from board/licheepi/readme.txt rename to board/licheepi/licheepi_zero/readme.txt diff --git a/configs/licheepi_zero_defconfig b/configs/licheepi_zero_defconfig index 0d3115a996..c8f74a7f04 100644 --- a/configs/licheepi_zero_defconfig +++ b/configs/licheepi_zero_defconfig @@ -12,7 +12,7 @@ BR2_TARGET_GENERIC_ISSUE="Welcome to Buildroot for the LicheePi Zero" BR2_TARGET_GENERIC_GETTY_PORT="ttyS0" BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh" -BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/licheepi/genimage.cfg" +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/licheepi/licheepi_zero/genimage.cfg" # Kernel BR2_LINUX_KERNEL=y @@ -45,7 +45,7 @@ BR2_TARGET_UBOOT_FORMAT_CUSTOM=y BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot-sunxi-with-spl.bin" BR2_PACKAGE_HOST_UBOOT_TOOLS=y BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT=y -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/licheepi/boot.cmd" +BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/licheepi/licheepi_zero/boot.cmd" # Required host utilities for building an SDCard image BR2_PACKAGE_HOST_DOSFSTOOLS=y
Group files for board licheepi_zero under a new directory. This is to prepare for a new board also coming to the licheepi directory. Signed-off-by: Francois Dugast <francois.dugast.foss@gmail.com> --- board/licheepi/{ => licheepi_zero}/boot.cmd | 0 board/licheepi/{ => licheepi_zero}/genimage.cfg | 0 board/licheepi/{ => licheepi_zero}/readme.txt | 0 configs/licheepi_zero_defconfig | 4 ++-- 4 files changed, 2 insertions(+), 2 deletions(-) rename board/licheepi/{ => licheepi_zero}/boot.cmd (100%) rename board/licheepi/{ => licheepi_zero}/genimage.cfg (100%) rename board/licheepi/{ => licheepi_zero}/readme.txt (100%)