| Message ID | 20231009151729.2223963-5-arbab@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/petitboot: misc fixes/enhancement | expand |
Hi Reza, On 09/10/2023 17:17, Reza Arbab wrote: > This is a better choice on devicetree-based platforms. > > Signed-off-by: Reza Arbab <arbab@linux.ibm.com> > --- > package/petitboot/Config.in | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/package/petitboot/Config.in b/package/petitboot/Config.in > index b534b4900e88..4981c165bf76 100644 > --- a/package/petitboot/Config.in > +++ b/package/petitboot/Config.in > @@ -11,12 +11,11 @@ config BR2_PACKAGE_PETITBOOT > select BR2_PACKAGE_ELFUTILS > select BR2_PACKAGE_LVM2 # devmapper > select BR2_PACKAGE_NCURSES > - # run-time dependency only > + # run-time dependencies This is an unrelated change (sorting the runtime dependencies alphabetically and removing the repetition of the comment). Ideally, this should have been a separate commit. Failing that, it should be explained in the commit message. I've done that. > select BR2_PACKAGE_KEXEC if !BR2_PACKAGE_KEXEC_LITE > - # run-time dependency only > - select BR2_PACKAGE_POWERPC_UTILS if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le ) > - # run-time dependency only > + select BR2_PACKAGE_KEXEC_LITE if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le ) If the user has already selected kexec, then we'll have both kexec and kexec-lite. I don't think that that is a good idea. So instead, I injected a separate commit that introduces BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS, and use that to simplify the condition here and to only select kexec-lite if kexec is not selected: select BR2_PACKAGE_KEXEC if !BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS select BR2_PACKAGE_KEXEC_LITE if BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS && !BR2_PACKAGE_KEXEC Regards, Arnout > select BR2_PACKAGE_NVME if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le ) > + select BR2_PACKAGE_POWERPC_UTILS if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le ) > help > Petitboot is a small kexec-based bootloader >
diff --git a/package/petitboot/Config.in b/package/petitboot/Config.in index b534b4900e88..4981c165bf76 100644 --- a/package/petitboot/Config.in +++ b/package/petitboot/Config.in @@ -11,12 +11,11 @@ config BR2_PACKAGE_PETITBOOT select BR2_PACKAGE_ELFUTILS select BR2_PACKAGE_LVM2 # devmapper select BR2_PACKAGE_NCURSES - # run-time dependency only + # run-time dependencies select BR2_PACKAGE_KEXEC if !BR2_PACKAGE_KEXEC_LITE - # run-time dependency only - select BR2_PACKAGE_POWERPC_UTILS if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le ) - # run-time dependency only + select BR2_PACKAGE_KEXEC_LITE if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le ) select BR2_PACKAGE_NVME if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le ) + select BR2_PACKAGE_POWERPC_UTILS if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le ) help Petitboot is a small kexec-based bootloader
This is a better choice on devicetree-based platforms. Signed-off-by: Reza Arbab <arbab@linux.ibm.com> --- package/petitboot/Config.in | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)