| Message ID | 20231002124736.179251-7-thomas.perale@essensium.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | support for a pre-compiled Go compiler | expand |
Hi Thomas, Thanks for this series, it looks good overall. A few minor fixes for this patch: On Mon, Oct 2, 2023 at 5:48 AM Thomas Perale <thomas.perale@essensium.com> wrote: > +class TestGoBin(TestGoBase): > + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \ > + """ > + BR2_TARGET_ROOTFS_CPIO=y > + BR2_PACKAGE_HOST_GO=y > + BR2_PACKAGE_HOST_GO_SRC=y > + BR2_PACKAGE_TINIFIER=y > + """ I think you meant to put HOST_GO_BIN here (for TestGoBin). > +class TestGoSource(TestGoBase): > + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \ > + """ > + BR2_TARGET_ROOTFS_CPIO=y > + BR2_PACKAGE_HOST_GO=y > + BR2_PACKAGE_HOST_GO_BIN=y > + BR2_PACKAGE_TINIFIER=y > + """ I think you meant to put HOST_GO_SRC here (for TestGoSource). Best regards, Christian Stewart
diff --git a/support/testing/tests/package/test_go.py b/support/testing/tests/package/test_go.py new file mode 100644 index 0000000000..9beb66d0d9 --- /dev/null +++ b/support/testing/tests/package/test_go.py @@ -0,0 +1,41 @@ +import os + +import infra.basetest + + +class TestGoBase(infra.basetest.BRTest): + + def login(self): + cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") + self.emulator.boot(arch="armv5", + kernel="builtin", + options=["-initrd", cpio_file]) + self.emulator.login() + + +class TestGoBin(TestGoBase): + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \ + """ + BR2_TARGET_ROOTFS_CPIO=y + BR2_PACKAGE_HOST_GO=y + BR2_PACKAGE_HOST_GO_SRC=y + BR2_PACKAGE_TINIFIER=y + """ + + def test_run(self): + self.login() + self.assertRunOk("tinifier -h") + + +class TestGoSource(TestGoBase): + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \ + """ + BR2_TARGET_ROOTFS_CPIO=y + BR2_PACKAGE_HOST_GO=y + BR2_PACKAGE_HOST_GO_BIN=y + BR2_PACKAGE_TINIFIER=y + """ + + def test_run(self): + self.login() + self.assertRunOk("tinifier -h")