| Message ID | 20230814145413.2099039-1-giulio.benetti@benettiengineering.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | package/libfuse3: bump to version 3.16.1 | expand |
On Mon, 14 Aug 2023 16:54:13 +0200 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > Let's drop local patch that has been upstreamed: > https://github.com/libfuse/libfuse/commit/b58a0014bff619f1810af49441d987d732c4244e > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > ...est-applications-for-cross-compiler-.patch | 43 ------------------- > package/libfuse3/libfuse3.hash | 2 +- > package/libfuse3/libfuse3.mk | 2 +- > 3 files changed, 2 insertions(+), 45 deletions(-) > delete mode 100644 package/libfuse3/0001-Wrapper-around-test-applications-for-cross-compiler-.patch Trying this, I get: ERROR: libfuse3-3.16.1.tar.gz has wrong sha256 hash: ERROR: expected: 75a7140ce2d4589eda2784d2279be9d2b273a9b6b0f79ecb871dc4dded046fb5 ERROR: got : 17c44c13f6a123c0c13d074fcf61c230a88531202a40c864187dee78f5851693 ERROR: Incomplete download, or man-in-the-middle (MITM) attack Are you sure you tested it? If you still have the original tarball with hash 75a7140ce2d4589eda2784d2279be9d2b273a9b6b0f79ecb871dc4dded046fb5, please keep it around, and compare it with the current tarball of hash 17c44c13f6a123c0c13d074fcf61c230a88531202a40c864187dee78f5851693, so we can understand if it's upstream that re-uploaded a different tarball. Thanks! Thomas
Hi Thomas, On 22/08/23 20:28, Thomas Petazzoni via buildroot wrote: > On Mon, 14 Aug 2023 16:54:13 +0200 > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > >> Let's drop local patch that has been upstreamed: >> https://github.com/libfuse/libfuse/commit/b58a0014bff619f1810af49441d987d732c4244e >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> ...est-applications-for-cross-compiler-.patch | 43 ------------------- >> package/libfuse3/libfuse3.hash | 2 +- >> package/libfuse3/libfuse3.mk | 2 +- >> 3 files changed, 2 insertions(+), 45 deletions(-) >> delete mode 100644 package/libfuse3/0001-Wrapper-around-test-applications-for-cross-compiler-.patch > > Trying this, I get: > > ERROR: libfuse3-3.16.1.tar.gz has wrong sha256 hash: > ERROR: expected: 75a7140ce2d4589eda2784d2279be9d2b273a9b6b0f79ecb871dc4dded046fb5 > ERROR: got : 17c44c13f6a123c0c13d074fcf61c230a88531202a40c864187dee78f5851693 > ERROR: Incomplete download, or man-in-the-middle (MITM) attack > > Are you sure you tested it? yes I did, > If you still have the original tarball with > hash 75a7140ce2d4589eda2784d2279be9d2b273a9b6b0f79ecb871dc4dded046fb5, > please keep it around, and compare it with the current tarball of hash > 17c44c13f6a123c0c13d074fcf61c230a88531202a40c864187dee78f5851693, so we > can understand if it's upstream that re-uploaded a different tarball. I still have that tarball, and indeed they very different each other. In the new version they dropped entirely the doc/html folder while instead adding some .gitignore file, the .github folder for CI/CD and a script called make_release_tarball.sh They don't mention on their Github repository[1] they've changed it, but they did it. Anyway I've just sent V2 patch to correct the hash failure. [1]: https://github.com/libfuse/libfuse/releases Best regards
On Tue, 22 Aug 2023 21:22:40 +0200 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > I still have that tarball, and indeed they very different each other. > In the new version they dropped entirely the doc/html folder while > instead adding some .gitignore file, the .github folder for CI/CD and > a script called make_release_tarball.sh > > They don't mention on their Github repository[1] they've changed it, but > they did it. This is annoying. Could you let them know that it is a problem by filling an issue in their Github repo? Thanks! Thomas
On 22/08/23 21:23, Thomas Petazzoni wrote: > On Tue, 22 Aug 2023 21:22:40 +0200 > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > >> I still have that tarball, and indeed they very different each other. >> In the new version they dropped entirely the doc/html folder while >> instead adding some .gitignore file, the .github folder for CI/CD and >> a script called make_release_tarball.sh >> >> They don't mention on their Github repository[1] they've changed it, but >> they did it. > > This is annoying. Could you let them know that it is a problem by > filling an issue in their Github repo? Done: https://github.com/libfuse/libfuse/issues/829 I went very soft since when you open an Issue you get this template: ``` PLEASE READ BEFORE REPORTING AN ISSUE libfuse does not have any active, regular contributors or developers. The current maintainer continues to apply pull requests and tries to make regular releases, but unfortunately has no capacity to do any development beyond addressing high-impact issues. When reporting bugs, please understand that unless you are including a pull request or are reporting a critical issue, you will probably not get a response. To prevent the issue tracker from being flooded with issues that no-one is intending to work on, and to give more visibility to critical issues that users should be aware of and that most urgently need attention, I will also close most bug reports once they've been inactive for a while. Please note that this isn't meant to imply that you haven't found a bug - you most likely have and I'm grateful that you took the time to report it. Unfortunately, libfuse is a purely volunteer driven project, and at the moment there simply aren't any volunteers. ``` judging from this Issue: https://github.com/libfuse/libfuse/issues/816 I don't think it will change that much. Best regards
diff --git a/package/libfuse3/0001-Wrapper-around-test-applications-for-cross-compiler-.patch b/package/libfuse3/0001-Wrapper-around-test-applications-for-cross-compiler-.patch deleted file mode 100644 index b99b4c23f4..0000000000 --- a/package/libfuse3/0001-Wrapper-around-test-applications-for-cross-compiler-.patch +++ /dev/null @@ -1,43 +0,0 @@ -From b58a0014bff619f1810af49441d987d732c4244e Mon Sep 17 00:00:00 2001 -From: Rudi Heitbaum <rudi@heitbaum.com> -Date: Tue, 13 Jun 2023 20:02:01 +1000 -Subject: [PATCH] Wrapper around test applications for cross compiler - environment in meson.build (#804) - -This enhances commit 7be56c57f93e3436b1fbd9ecc320de5c03a3e4b8 to allow build -fuse to be built using a cross compiler - -Fixes: -../meson.build:180:12: ERROR: Can not run test applications in this cross environment. - -Upstream: https://github.com/libfuse/libfuse/commit/b58a0014bff619f1810af49441d987d732c4244e - -Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> ---- - meson.build | 10 ++++++---- - 1 file changed, 6 insertions(+), 4 deletions(-) - -diff --git a/meson.build b/meson.build -index 7aa4e0d..9707ea3 100644 ---- a/meson.build -+++ b/meson.build -@@ -177,10 +177,12 @@ int main() - } - ''' - --result = cc.run(detect_getmntent_needs_unescape) --if result.compiled() and result.returncode() == 0 and result.stdout().strip() == 'needs escaping' -- message('getmntent does not unescape') -- add_project_arguments('-DGETMNTENT_NEEDS_UNESCAPING', language: 'c') -+if not meson.is_cross_build() -+ result = cc.run(detect_getmntent_needs_unescape) -+ if result.compiled() and result.returncode() == 0 and result.stdout().strip() == 'needs escaping' -+ message('getmntent does not unescape') -+ add_project_arguments('-DGETMNTENT_NEEDS_UNESCAPING', language: 'c') -+ endif - endif - - # Write private test results into fuse_config.h (stored in build directory) --- -2.34.1 - diff --git a/package/libfuse3/libfuse3.hash b/package/libfuse3/libfuse3.hash index 0397efc542..cd990a6991 100644 --- a/package/libfuse3/libfuse3.hash +++ b/package/libfuse3/libfuse3.hash @@ -1,3 +1,3 @@ # Locally calculated sha256 checksums -sha256 cb93e170288804d2e83da9b69925d968655ed75883476773ba5268d08bb1d335 libfuse3-3.15.1.tar.gz +sha256 75a7140ce2d4589eda2784d2279be9d2b273a9b6b0f79ecb871dc4dded046fb5 libfuse3-3.16.1.tar.gz sha256 b8832d9caaa075bbbd2aef24efa09f8b7ab66a832812d88c602da0c7b4397fad LICENSE diff --git a/package/libfuse3/libfuse3.mk b/package/libfuse3/libfuse3.mk index 32e35ff32b..a4b1f08266 100644 --- a/package/libfuse3/libfuse3.mk +++ b/package/libfuse3/libfuse3.mk @@ -4,7 +4,7 @@ # ################################################################################ -LIBFUSE3_VERSION = 3.15.1 +LIBFUSE3_VERSION = 3.16.1 LIBFUSE3_SITE = $(call github,libfuse,libfuse,fuse-$(LIBFUSE3_VERSION)) LIBFUSE3_LICENSE = LGPL-2.1 LIBFUSE3_LICENSE_FILES = LICENSE
Let's drop local patch that has been upstreamed: https://github.com/libfuse/libfuse/commit/b58a0014bff619f1810af49441d987d732c4244e Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- ...est-applications-for-cross-compiler-.patch | 43 ------------------- package/libfuse3/libfuse3.hash | 2 +- package/libfuse3/libfuse3.mk | 2 +- 3 files changed, 2 insertions(+), 45 deletions(-) delete mode 100644 package/libfuse3/0001-Wrapper-around-test-applications-for-cross-compiler-.patch