| Message ID | 20230814024834.11369-2-peterlin@andestech.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei | expand |
On Mon, 14 Aug 2023 10:48:34 +0800 Yu Chien Peter Lin <peterlin@andestech.com> wrote: > The BR2_PACKAGE_GLIBC_ARCH_SUPPORTS requires the RVA extension, > so we select it to enable and use glibc by default. Thanks for the patch. However, the commit log is not a proper justification. Indeed, BR2_RISCV_ISA_CUSTOM_RVA should be enabled if the hardware supports it, not because glibc needs it. If glibc needs it, but the hardware doesn't support this instruction set extension, it doesn't make sense to enable it. Thomas
On Mon, Aug 14, 2023 at 04:39:46PM +0200, Thomas Petazzoni wrote: > On Mon, 14 Aug 2023 10:48:34 +0800 > Yu Chien Peter Lin <peterlin@andestech.com> wrote: > > > The BR2_PACKAGE_GLIBC_ARCH_SUPPORTS requires the RVA extension, > > so we select it to enable and use glibc by default. > > Thanks for the patch. However, the commit log is not a proper > justification. Indeed, BR2_RISCV_ISA_CUSTOM_RVA should be enabled if > the hardware supports it, not because glibc needs it. If glibc needs > it, but the hardware doesn't support this instruction set extension, it > doesn't make sense to enable it. No problem, will reword properly in the next patch. Thanks! Peter Lin > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com
diff --git a/configs/andes_ae350_45_defconfig b/configs/andes_ae350_45_defconfig index ef29ab6454..4e4c38dc21 100644 --- a/configs/andes_ae350_45_defconfig +++ b/configs/andes_ae350_45_defconfig @@ -1,6 +1,7 @@ BR2_riscv=y BR2_riscv_custom=y BR2_RISCV_ISA_CUSTOM_RVM=y +BR2_RISCV_ISA_CUSTOM_RVA=y BR2_RISCV_ISA_CUSTOM_RVF=y BR2_RISCV_ISA_CUSTOM_RVD=y BR2_RISCV_ISA_CUSTOM_RVC=y
The BR2_PACKAGE_GLIBC_ARCH_SUPPORTS requires the RVA extension, so we select it to enable and use glibc by default. Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com> --- configs/andes_ae350_45_defconfig | 1 + 1 file changed, 1 insertion(+)