diff mbox series

[v2,1/1] configs/imx8mn_bsh_smm_s2[_pro]_defconfig: explicitly set binutils version

Message ID 20230708173104.686175-1-dario.binacchi@amarulasolutions.com
State Superseded
Headers show
Series [v2,1/1] configs/imx8mn_bsh_smm_s2[_pro]_defconfig: explicitly set binutils version | expand

Commit Message

Dario Binacchi July 8, 2023, 5:31 p.m. UTC
The commit fb50eab8a5e6b ("package/binutils: switch to 2.39.x as the
default version") raised the error reported by Gitlab CI.

I tried to bump arm-trusted-firmware to the version that fixes the issue
against binutils version 2.39, but the subsequent board update was
unsuccessful. Therefore, for now, it is better not to change the version of
binutils to ensure the proper compilation of the image.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4603996179
https://gitlab.com/buildroot.org/buildroot/-/jobs/4603996181

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

Changes in v2:
- add `Fixes' tag and change a little bit the commit description

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 configs/imx8mn_bsh_smm_s2_defconfig     | 1 +
 configs/imx8mn_bsh_smm_s2_pro_defconfig | 1 +
 2 files changed, 2 insertions(+)

Comments

Thomas Petazzoni Aug. 7, 2023, 10:10 p.m. UTC | #1
Hello,

On Sat,  8 Jul 2023 19:31:04 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:

> The commit fb50eab8a5e6b ("package/binutils: switch to 2.39.x as the
> default version") raised the error reported by Gitlab CI.
> 
> I tried to bump arm-trusted-firmware to the version that fixes the issue
> against binutils version 2.39, but the subsequent board update was
> unsuccessful. Therefore, for now, it is better not to change the version of
> binutils to ensure the proper compilation of the image.
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4603996179
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4603996181
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

This has normally been fixed in a better way by commit:

  https://gitlab.com/buildroot.org/buildroot/-/commit/7b774048be6292bb61f90759ad3b7b58a33a1650

Could you check if it is working fine now?

Thanks!

Thomas
Dario Binacchi Aug. 14, 2023, 2:39 p.m. UTC | #2
Hello Thomas,

On Tue, Aug 8, 2023 at 12:11 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> On Sat,  8 Jul 2023 19:31:04 +0200
> Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
>
> > The commit fb50eab8a5e6b ("package/binutils: switch to 2.39.x as the
> > default version") raised the error reported by Gitlab CI.
> >
> > I tried to bump arm-trusted-firmware to the version that fixes the issue
> > against binutils version 2.39, but the subsequent board update was
> > unsuccessful. Therefore, for now, it is better not to change the version of
> > binutils to ensure the proper compilation of the image.
> >
> > Fixes:
> > https://gitlab.com/buildroot.org/buildroot/-/jobs/4603996179
> > https://gitlab.com/buildroot.org/buildroot/-/jobs/4603996181
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> This has normally been fixed in a better way by commit:
>
>   https://gitlab.com/buildroot.org/buildroot/-/commit/7b774048be6292bb61f90759ad3b7b58a33a1650
>
> Could you check if it is working fine now?

Yes. Now It is working.

Thanks and regards,
Dario

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
diff mbox series

Patch

diff --git a/configs/imx8mn_bsh_smm_s2_defconfig b/configs/imx8mn_bsh_smm_s2_defconfig
index 8b2b74395efc..55d05393e184 100644
--- a/configs/imx8mn_bsh_smm_s2_defconfig
+++ b/configs/imx8mn_bsh_smm_s2_defconfig
@@ -1,5 +1,6 @@ 
 BR2_aarch64=y
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
+BR2_BINUTILS_VERSION_2_38_X=y
 BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3"
 BR2_ROOTFS_POST_BUILD_SCRIPT="board/bsh/imx8mn-bsh-smm-s2/post-build.sh"
 BR2_LINUX_KERNEL=y
diff --git a/configs/imx8mn_bsh_smm_s2_pro_defconfig b/configs/imx8mn_bsh_smm_s2_pro_defconfig
index e9ff244a3555..b3767b332e84 100644
--- a/configs/imx8mn_bsh_smm_s2_pro_defconfig
+++ b/configs/imx8mn_bsh_smm_s2_pro_defconfig
@@ -1,5 +1,6 @@ 
 BR2_aarch64=y
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
+BR2_BINUTILS_VERSION_2_38_X=y
 BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3"
 BR2_ROOTFS_POST_BUILD_SCRIPT="board/bsh/imx8mn-bsh-smm-s2-pro/post-build.sh"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/bsh/imx8mn-bsh-smm-s2-pro/post-image.sh"