diff mbox series

[1/1] package: mono: allow building for aarch64 targets

Message ID 20230524165506.692213-1-stefan@familie-mayrhofer.net
State Accepted
Headers show
Series [1/1] package: mono: allow building for aarch64 targets | expand

Commit Message

Stefan Mayrhofer May 24, 2023, 4:55 p.m. UTC
Add aarch64 to BR2_PACKAGE_MONO_ARCH_SUPPORTS to allow building for aarch64 targets.

I have tested that this compiles successfully and runs on the actual target (imx8mp based board)

Signed-off-by: Stefan Mayrhofer <stefan@familie-mayrhofer.net>
---
 package/mono/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni July 29, 2023, 8:53 a.m. UTC | #1
Hello Stefan,

Sorry for the slow feedback!

On Wed, 24 May 2023 18:55:06 +0200
Stefan Mayrhofer <stefan@familie-mayrhofer.net> wrote:

> Add aarch64 to BR2_PACKAGE_MONO_ARCH_SUPPORTS to allow building for aarch64 targets.
> 
> I have tested that this compiles successfully and runs on the actual target (imx8mp based board)
> 
> Signed-off-by: Stefan Mayrhofer <stefan@familie-mayrhofer.net>

Thanks, I've applied, after doing some very small tweaks:

- Commit title prefix changed from "package: mono:" to "package/mono:"
  which is the standard in Buildroot

- Wrapped lines of the commit logs to a reasonable length

- Reworded to avoid first person sentences ("I have tested ...")

- Modified the Config.in file to preserve alphabetic ordering of
  supported architectures.

Thanks a lot!

Thomas
diff mbox series

Patch

diff --git a/package/mono/Config.in b/package/mono/Config.in
index 76178bcf9b..640c6fb42a 100644
--- a/package/mono/Config.in
+++ b/package/mono/Config.in
@@ -6,7 +6,7 @@  config BR2_PACKAGE_HOST_MONO_ARCH_SUPPORTS
 config BR2_PACKAGE_MONO_ARCH_SUPPORTS
 	bool
 	default y if (BR2_arm || BR2_armeb || BR2_i386 || \
-		      BR2_powerpc || BR2_x86_64)
+		      BR2_powerpc || BR2_x86_64 || BR2_aarch64)
 	depends on BR2_PACKAGE_HOST_MONO_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_LIBATOMIC_OPS_ARCH_SUPPORTS