| Message ID | 20230521082858.500-1-guillaume.bressaix@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] package/pixiewps: bump to version 1.4.2 | expand |
Hello Guillaume, On Sun, 21 May 2023 10:28:58 +0200 "Guillaume W. Bres" <guillaume.bressaix@gmail.com> wrote: > -PIXIEWPS_VERSION = 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59 > -PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,$(PIXIEWPS_VERSION)) > +PIXIEWPS_VERSION = 1.4.2 > +PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,v$(PIXIEWPS_VERSION)) Hum, I'm sorry but this doesn't look like a bump. If we look at the commit history of pixiewps (most recent commits first, older commits last): 464326fbcc499ac92d4f04c3990a9cc9c5124e86 (HEAD -> master, origin/master, origin/HEAD) Update gitignore: add pixiewrapper binary 85af251806ab24454372134e7055823adebd5afa remove gmtime()-related code duplication c1dd3a9ff6618b5f2e3535855cee9ffb10788b81 use gmtime_r() to mute code analysis tools (gmtime() is non-mt-safe) a6b3fa514c0c9a6ad5dc931040218451c64ce150 add pixiewrapper 8964527b85f558465341d9daa8da8d8a94eb0967 add --cstart/cend switches for time_t range 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59 endianeness.h: fix logical bug which broke big endian <--- we are currently here 28f68e694bdf5774300a1451c970578de0e19ce0 (tag: v1.4.2) Bumped version to 1.4.2 <--- you propose to get back here So in fact, you're proposing to go one commit back in time. Maybe it's OK but you should explain why. And a "fix logical bug which broke big endian" seems useful to have in Buildroot. Could you clarify? Thomas
Hello Thomas, > So in fact, you're proposing to go one commit back in time. Maybe it's > OK but you should explain why. And a "fix logical bug which broke big > endian" seems useful to have in Buildroot. > Could you clarify? Yes you are correct, thank you for not merging. I thought tags were just released but that is not the case, we're using a newer commit hash and can't do otherwise until a newer tag is released Guillaume W. Bres Software engineer <guillaume.bressaix@gmail.com> Le dim. 30 juil. 2023 à 23:33, Thomas Petazzoni < thomas.petazzoni@bootlin.com> a écrit : > Hello Guillaume, > > On Sun, 21 May 2023 10:28:58 +0200 > "Guillaume W. Bres" <guillaume.bressaix@gmail.com> wrote: > > > -PIXIEWPS_VERSION = 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59 > > -PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,$(PIXIEWPS_VERSION)) > > +PIXIEWPS_VERSION = 1.4.2 > > +PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,v$(PIXIEWPS_VERSION)) > > Hum, I'm sorry but this doesn't look like a bump. If we look at the > commit history of pixiewps (most recent commits first, older commits > last): > > 464326fbcc499ac92d4f04c3990a9cc9c5124e86 (HEAD -> master, origin/master, > origin/HEAD) Update gitignore: add pixiewrapper binary > 85af251806ab24454372134e7055823adebd5afa remove gmtime()-related code > duplication > c1dd3a9ff6618b5f2e3535855cee9ffb10788b81 use gmtime_r() to mute code > analysis tools (gmtime() is non-mt-safe) > a6b3fa514c0c9a6ad5dc931040218451c64ce150 add pixiewrapper > 8964527b85f558465341d9daa8da8d8a94eb0967 add --cstart/cend switches for > time_t range > 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59 endianeness.h: fix logical bug > which broke big endian <--- we are currently here > 28f68e694bdf5774300a1451c970578de0e19ce0 (tag: v1.4.2) Bumped version to > 1.4.2 <--- you propose to get back here > > So in fact, you're proposing to go one commit back in time. Maybe it's > OK but you should explain why. And a "fix logical bug which broke big > endian" seems useful to have in Buildroot. > > Could you clarify? > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com >
diff --git a/package/pixiewps/pixiewps.hash b/package/pixiewps/pixiewps.hash index 99a09741a3..c3c213906c 100644 --- a/package/pixiewps/pixiewps.hash +++ b/package/pixiewps/pixiewps.hash @@ -1,3 +1,3 @@ # locally computed -sha256 d3d3cf57851e3e734fb1797aa078239ef161d1cbeffc4438497d58a425ef22a2 pixiewps-9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59.tar.gz +sha256 c73ffd58c461a88504cca36e5a29981dc68b78f8fdd31d7c546bc204fad7c435 pixiewps-1.4.2.tar.gz sha256 ccb349b4132ed7737f25e5adebfe61f3d52dca33708df1e50352320438d1d4c2 LICENSE.md diff --git a/package/pixiewps/pixiewps.mk b/package/pixiewps/pixiewps.mk index 1f84bbeb34..a6fb2527d9 100644 --- a/package/pixiewps/pixiewps.mk +++ b/package/pixiewps/pixiewps.mk @@ -4,8 +4,8 @@ # ################################################################################ -PIXIEWPS_VERSION = 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59 -PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,$(PIXIEWPS_VERSION)) +PIXIEWPS_VERSION = 1.4.2 +PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,v$(PIXIEWPS_VERSION)) PIXIEWPS_LICENSE = GPL-3.0+ PIXIEWPS_LICENSE_FILES = LICENSE.md
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com> --- package/pixiewps/pixiewps.hash | 2 +- package/pixiewps/pixiewps.mk | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)