diff mbox series

[v2] toolchain/Config.in: extend gcc bug 43744 to every sh architecture

Message ID 20230205212521.903480-1-giulio.benetti@benettiengineering.com
State Accepted
Headers show
Series [v2] toolchain/Config.in: extend gcc bug 43744 to every sh architecture | expand

Commit Message

Giulio Benetti Feb. 5, 2023, 9:25 p.m. UTC
Gcc bug 43744 affects seems to affect all SH family because it already
affects:
1) sh4, here you can find a buildroot defconfig that fails to build:
http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/defconfig
2) sh4a, here you can find a buildroot defconfig that fails to build:
http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a/defconfig
Note also that gcc bugzilla entry reports the bug for SH and not for
sub-architectures:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744

So let's extend the bug to BR2_sh to match the entire SH architecture.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* add a commit log with details about gcc bug 43744 as pointed by Thomas Petazzoni
---
 toolchain/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Feb. 6, 2023, 9:46 a.m. UTC | #1
On Sun,  5 Feb 2023 22:25:21 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Gcc bug 43744 affects seems to affect all SH family because it already
> affects:
> 1) sh4, here you can find a buildroot defconfig that fails to build:
> http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/defconfig
> 2) sh4a, here you can find a buildroot defconfig that fails to build:
> http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a/defconfig
> Note also that gcc bugzilla entry reports the bug for SH and not for
> sub-architectures:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744
> 
> So let's extend the bug to BR2_sh to match the entire SH architecture.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * add a commit log with details about gcc bug 43744 as pointed by Thomas Petazzoni
> ---
>  toolchain/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
Peter Korsgaard Feb. 22, 2023, 3:48 p.m. UTC | #2
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > Gcc bug 43744 affects seems to affect all SH family because it already
 > affects:
 > 1) sh4, here you can find a buildroot defconfig that fails to build:
 > http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/defconfig
 > 2) sh4a, here you can find a buildroot defconfig that fails to build:
 > http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a/defconfig
 > Note also that gcc bugzilla entry reports the bug for SH and not for
 > sub-architectures:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744

 > So let's extend the bug to BR2_sh to match the entire SH architecture.

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
 > ---
 V1-> V2:
 > * add a commit log with details about gcc bug 43744 as pointed by Thomas Petazzoni

Committed to 2022.11.x, thanks.
diff mbox series

Patch

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 544b423001..01215e0e96 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -115,7 +115,7 @@  config BR2_TOOLCHAIN_HAS_GCC_BUG_43744
 	bool
 	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
 	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9
-	depends on BR2_sh4
+	depends on BR2_sh
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no
 # longer exists in gcc 8.x.