| Message ID | 20221106102046.13138-1-heiko.thiery@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | configs/kontron_bl_imx8mm_defconfig: bump U-boot to 2022.10 | expand |
Heiko, All, On 2022-11-06 11:20 +0100, Heiko Thiery spake thusly: > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/3267233833 > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > configs/kontron_bl_imx8mm_defconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configs/kontron_bl_imx8mm_defconfig b/configs/kontron_bl_imx8mm_defconfig > index ff376662e9..240cb52245 100644 > --- a/configs/kontron_bl_imx8mm_defconfig > +++ b/configs/kontron_bl_imx8mm_defconfig > @@ -38,7 +38,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="IMX_BOOT_UART_BASE=0x30880 > BR2_TARGET_UBOOT=y > BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y > BR2_TARGET_UBOOT_CUSTOM_VERSION=y > -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04" > +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10" As far as I can see, the linked build failure is about missing -luuid and -lgnutls I see you added BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y, below, but did you forget to add BR2_TARGET_UBOOT_NEEDS_GNUTLS=y too? Also, is the version bump really required to fix the build issue? If so, it should be explained in the commit log, plese. Regards, Yann E. MORIN. > BR2_TARGET_UBOOT_BOARD_DEFCONFIG="kontron-sl-mx8mm" > BR2_TARGET_UBOOT_NEEDS_DTC=y > BR2_TARGET_UBOOT_NEEDS_PYTHON3=y > @@ -48,6 +48,7 @@ BR2_TARGET_UBOOT_NEEDS_GNUTLS=y > BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y > BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN=y > BR2_TARGET_UBOOT_NEEDS_IMX_FIRMWARE=y > +BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y > BR2_TARGET_UBOOT_FORMAT_CUSTOM=y > BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="flash.bin" > BR2_TARGET_UBOOT_SPL=y > -- > 2.20.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
)Hi Yann, Am Mo., 7. Nov. 2022 um 21:20 Uhr schrieb Yann E. MORIN <yann.morin.1998@free.fr>: > > Heiko, All, > > On 2022-11-06 11:20 +0100, Heiko Thiery spake thusly: > > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/3267233833 > > > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > > --- > > configs/kontron_bl_imx8mm_defconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/configs/kontron_bl_imx8mm_defconfig b/configs/kontron_bl_imx8mm_defconfig > > index ff376662e9..240cb52245 100644 > > --- a/configs/kontron_bl_imx8mm_defconfig > > +++ b/configs/kontron_bl_imx8mm_defconfig > > @@ -38,7 +38,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="IMX_BOOT_UART_BASE=0x30880 > > BR2_TARGET_UBOOT=y > > BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y > > BR2_TARGET_UBOOT_CUSTOM_VERSION=y > > -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04" > > +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10" > > As far as I can see, the linked build failure is about missing -luuid > and -lgnutls > > I see you added BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y, below, but did you > forget to add BR2_TARGET_UBOOT_NEEDS_GNUTLS=y too? The BR2_TARGET_UBOOT_NEEDS_GNUTLS is already in the defconfig but was not enough. There were some issues with the build system of u-boot. They were fixed upstream and are now available in the new version. > Also, is the version bump really required to fix the build issue? If so, > it should be explained in the commit log, plese. In the new U-boot release are some patches that fix the issue with: a638bd349ea438256daf9c1f323402a137c55e03 (kbuild: add KBUILD_HOSTLDFLAGS to cmd_host-csingle) [1] 31a7688cbe0ed5edf4108a1f7ef4653659610d4b (tools: mkeficapsule: use pkg-config to get -luuid and -lgnutls) [2] [1] https://source.denx.de/u-boot/u-boot/-/commit/a638bd349ea438256daf9c1f323402a137c55e03 [2] https://source.denx.de/u-boot/u-boot/-/commit/31a7688cbe0ed5edf4108a1f7ef4653659610d4b I will explain that in the commit log and send a v2 for that.
diff --git a/configs/kontron_bl_imx8mm_defconfig b/configs/kontron_bl_imx8mm_defconfig index ff376662e9..240cb52245 100644 --- a/configs/kontron_bl_imx8mm_defconfig +++ b/configs/kontron_bl_imx8mm_defconfig @@ -38,7 +38,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="IMX_BOOT_UART_BASE=0x30880 BR2_TARGET_UBOOT=y BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y BR2_TARGET_UBOOT_CUSTOM_VERSION=y -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04" +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10" BR2_TARGET_UBOOT_BOARD_DEFCONFIG="kontron-sl-mx8mm" BR2_TARGET_UBOOT_NEEDS_DTC=y BR2_TARGET_UBOOT_NEEDS_PYTHON3=y @@ -48,6 +48,7 @@ BR2_TARGET_UBOOT_NEEDS_GNUTLS=y BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN=y BR2_TARGET_UBOOT_NEEDS_IMX_FIRMWARE=y +BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y BR2_TARGET_UBOOT_FORMAT_CUSTOM=y BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="flash.bin" BR2_TARGET_UBOOT_SPL=y
Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/3267233833 Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> --- configs/kontron_bl_imx8mm_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)