[1/3] configs/roc_pc_rk3399: remove defconfig

This defconfig has been failing to build for several months, with
nobody stepping up to fix it. It's time to drop it.

See
https://lore.kernel.org/buildroot/20220806224338.0159e15c@windsurf/
for a notification on August 6, 2022 about the issues with this
defconfig.

Fixes:

  https://gitlab.com/buildroot.org/buildroot/-/jobs/3259671226

Cc: Suniel Mahesh <sunil@amarulasolutions.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 DEVELOPERS                                |  2 --
 board/firefly/roc-rk3399-pc/extlinux.conf |  4 ---
 board/firefly/roc-rk3399-pc/genimage.cfg  | 22 -------------
 board/firefly/roc-rk3399-pc/post-build.sh |  5 ---
 board/firefly/roc-rk3399-pc/readme.txt    | 40 -----------------------
 5 files changed, 73 deletions(-)
 delete mode 100644 board/firefly/roc-rk3399-pc/extlinux.conf
 delete mode 100644 board/firefly/roc-rk3399-pc/genimage.cfg
 delete mode 100755 board/firefly/roc-rk3399-pc/post-build.sh
 delete mode 100644 board/firefly/roc-rk3399-pc/readme.txt

Hi Thomas,

This is a Libre Computer only product in the future so the folder is wrong.
I will re-create in the right folder and maintain these boards in the
future.

Best,
Da


On Wed, Nov 2, 2022, 4:19 PM Thomas Petazzoni via buildroot <
buildroot@buildroot.org> wrote:

> This defconfig has been failing to build for several months, with
> nobody stepping up to fix it. It's time to drop it.
>
> See
> https://lore.kernel.org/buildroot/20220806224338.0159e15c@windsurf/
> for a notification on August 6, 2022 about the issues with this
> defconfig.
>
> Fixes:
>
>   https://gitlab.com/buildroot.org/buildroot/-/jobs/3259671226
>
> Cc: Suniel Mahesh <sunil@amarulasolutions.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  DEVELOPERS                                |  2 --
>  board/firefly/roc-rk3399-pc/extlinux.conf |  4 ---
>  board/firefly/roc-rk3399-pc/genimage.cfg  | 22 -------------
>  board/firefly/roc-rk3399-pc/post-build.sh |  5 ---
>  board/firefly/roc-rk3399-pc/readme.txt    | 40 -----------------------
>  5 files changed, 73 deletions(-)
>  delete mode 100644 board/firefly/roc-rk3399-pc/extlinux.conf
>  delete mode 100644 board/firefly/roc-rk3399-pc/genimage.cfg
>  delete mode 100755 board/firefly/roc-rk3399-pc/post-build.sh
>  delete mode 100644 board/firefly/roc-rk3399-pc/readme.txt
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9569ee720b..591276bec8 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2729,13 +2729,11 @@ F:      package/hwloc/
>  F:     package/powertop/
>
>  N:     Suniel Mahesh <sunil@amarulasolutions.com>
> -F:     board/firefly/
>  F:     board/friendlyarm/nanopi-m4
>  F:     board/pine64/rockpro64
>  F:     board/radxa/rockpi-4
>  F:     board/radxa/rockpi-n8
>  F:     board/radxa/rockpi-n10
> -F:     configs/roc_pc_rk3399_defconfig
>  F:     configs/rock_pi_4_defconfig
>  F:     configs/rock_pi_n8_defconfig
>  F:     configs/rock_pi_n10_defconfig
> diff --git a/board/firefly/roc-rk3399-pc/extlinux.conf
> b/board/firefly/roc-rk3399-pc/extlinux.conf
> deleted file mode 100644
> index 50a358fadc..0000000000
> --- a/board/firefly/roc-rk3399-pc/extlinux.conf
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -label RK3399RocPC linux
> -  kernel /boot/Image
> -  devicetree /boot/rk3399-roc-pc.dtb
> -  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk0p1 rootwait
> diff --git a/board/firefly/roc-rk3399-pc/genimage.cfg
> b/board/firefly/roc-rk3399-pc/genimage.cfg
> deleted file mode 100644
> index 966c869273..0000000000
> --- a/board/firefly/roc-rk3399-pc/genimage.cfg
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -image sdcard.img {
> -       hdimage {
> -       }
> -
> -       partition u-boot-tpl-spl-dtb {
> -               in-partition-table = "no"
> -               image = "idbloader.img"
> -               offset = 32K
> -       }
> -
> -       partition u-boot-dtb {
> -               in-partition-table = "no"
> -               image = "u-boot.itb"
> -               offset = 8M
> -               size = 30M
> -       }
> -
> -       partition rootfs {
> -               partition-type = 0x83
> -               image = "rootfs.ext4"
> -       }
> -}
> diff --git a/board/firefly/roc-rk3399-pc/post-build.sh
> b/board/firefly/roc-rk3399-pc/post-build.sh
> deleted file mode 100755
> index 1f5ff6a611..0000000000
> --- a/board/firefly/roc-rk3399-pc/post-build.sh
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -#!/bin/sh
> -
> -BOARD_DIR="$(dirname $0)"
> -
> -install -m 0644 -D $BOARD_DIR/extlinux.conf
> $TARGET_DIR/boot/extlinux/extlinux.conf
> diff --git a/board/firefly/roc-rk3399-pc/readme.txt
> b/board/firefly/roc-rk3399-pc/readme.txt
> deleted file mode 100644
> index 8a6f1cdee6..0000000000
> --- a/board/firefly/roc-rk3399-pc/readme.txt
> +++ /dev/null
> @@ -1,40 +0,0 @@
> -Libre Computer Board ROC-RK3399-PC
> -===================================
> -
> -Build:
> -
> -  $ make roc_pc_rk3399_defconfig
> -  $ make
> -
> -Files created in output directory
> -=================================
> -
> -output/images
> -
> -├── bl31.elf
> -├── idbloader.img
> -├── Image
> -├── rk3399-roc-pc.dtb
> -├── rootfs.ext2
> -├── rootfs.ext4 -> rootfs.ext2
> -├── rootfs.tar
> -├── sdcard.img
> -├── u-boot.bin
> -└── u-boot.itb
> -
> -Creating bootable SD card:
> -==========================
> -
> -Simply invoke (as root)
> -
> -sudo dd if=output/images/sdcard.img of=/dev/sdX && sync
> -
> -Where X is your SD card device
> -
> -Serial console
> ---------------
> -
> -Baudrate for this board is 1500000
> -
> -Wiki link:
> -https://wiki.amarulasolutions.com/bsp/rockchip/rk3399/roc-rk3399-pc.html
> --
> 2.38.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>

Hello Da,

On Wed, 2 Nov 2022 20:03:51 -0400
Da Xue <da@lessconfused.com> wrote:

> This is a Libre Computer only product in the future so the folder is wrong.
> I will re-create in the right folder and maintain these boards in the
> future.

Thanks for your feedback. Should we in the mean time remove the
existing defconfig? Or will you send a patch to fix it up, and rename
what needs to be renamed?

Thanks!

Thomas