| Message ID | 20221026132634.999254-8-giulio.benetti@benettiengineering.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Disable packages with CONFIG_WIRELESS on s390x | expand |
On Wed, 2022-10-26 at 15:26 +0200, Giulio Benetti wrote: > s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this > package for this architecture. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/wilc-driver/Config.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in > index 7ed062bb66..7f970bd38b 100644 > --- a/package/wilc-driver/Config.in > +++ b/package/wilc-driver/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_WILC_DRIVER > bool "wilc kernel module" > + depends on !BR2_s390x > depends on BR2_LINUX_KERNEL > help > External kernel module for WILC1000/3000 devices. > @@ -59,4 +60,5 @@ endif > endif > > comment "wilc kernel module needs a Linux kernel to be built" > + depends on !BR2_s390x > depends on !BR2_LINUX_KERNEL I don't know much on the s390x arch, nor Buildroot paradigms for disabling packages per-architecture, however the change itself looks good to me. Reviewed-by: Kris Bahnsen <kris@embeddedTS.com>
Hi Kris, All, sorry for my previous HTML e-mail, On 26/10/22 19:32, Kris Bahnsen via buildroot wrote: > On Wed, 2022-10-26 at 15:26 +0200, Giulio Benetti wrote: >> s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this >> package for this architecture. >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> package/wilc-driver/Config.in | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in >> index 7ed062bb66..7f970bd38b 100644 >> --- a/package/wilc-driver/Config.in >> +++ b/package/wilc-driver/Config.in >> @@ -1,5 +1,6 @@ >> config BR2_PACKAGE_WILC_DRIVER >> bool "wilc kernel module" >> + depends on !BR2_s390x >> depends on BR2_LINUX_KERNEL >> help >> External kernel module for WILC1000/3000 devices. >> @@ -59,4 +60,5 @@ endif >> endif >> >> comment "wilc kernel module needs a Linux kernel to be built" >> + depends on !BR2_s390x >> depends on !BR2_LINUX_KERNEL > > I don't know much on the s390x arch, nor Buildroot paradigms for disabling packages > per-architecture, however the change itself looks good to me. If you check here: https://elixir.bootlin.com/linux/latest/source/net/Kconfig#L371 You will see that Linux Wireless subsystem is activated only when s390x is not enabled. This also created a build failure with another rtlxxxx driver due to that: http://autobuild.buildroot.net/results/693053491ba61edcff0f75a4f30c13958e7e12ce/ This is why I came in with this patchset that prevents that kind of build failure. > Reviewed-by: Kris Bahnsen <kris@embeddedTS.com> Thank you Best regards
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes: > s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this > package for this architecture. > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Committed to 2022.08.x, thanks.
diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in index 7ed062bb66..7f970bd38b 100644 --- a/package/wilc-driver/Config.in +++ b/package/wilc-driver/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_WILC_DRIVER bool "wilc kernel module" + depends on !BR2_s390x depends on BR2_LINUX_KERNEL help External kernel module for WILC1000/3000 devices. @@ -59,4 +60,5 @@ endif endif comment "wilc kernel module needs a Linux kernel to be built" + depends on !BR2_s390x depends on !BR2_LINUX_KERNEL
s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this package for this architecture. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/wilc-driver/Config.in | 2 ++ 1 file changed, 2 insertions(+)