| Message ID | 20221019215741.2854410-1-oguz.ozhan@mind.be |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/3] support/testing: replace nose2 with pytest - Dockerfile | expand |
Hello Oguz,
On Wed, 19 Oct 2022 23:57:39 +0200
Oguz Ozhan <oguz.ozhan@mind.be> wrote:
> Signed-off-by: Oguz Ozhan <oguz.ozhan@mind.be>
Thanks a lot for your patch series. However, all commit logs are empty.
What is the rationale/motivation for the changes in this patch series?
Why is pytest better than nose2? Could you send a new iteration with a
detailed commit log for each commit that explains the motivation for
the change, and also describes the change itself, especially in PATCH
2/3, where test cases see changes. BTW, these changes in test cases
could be done in a separate preparation commit, as they would still
work with nose2 I believe.
Also another concern is that the series is not really bisectable, but
admittedly I'm not sure it's easy to achieve without doing all the
changes in one single patch.
Best regards,
Thomas
Hi Thomas. Thanks a lot for your comments. I inserted more information in the commit logs and re-sent the patches. KR. Oguz On Fri, Oct 21, 2022 at 9:44 AM Thomas Petazzoni < thomas.petazzoni@bootlin.com> wrote: > Hello Oguz, > > On Wed, 19 Oct 2022 23:57:39 +0200 > Oguz Ozhan <oguz.ozhan@mind.be> wrote: > > > Signed-off-by: Oguz Ozhan <oguz.ozhan@mind.be> > > Thanks a lot for your patch series. However, all commit logs are empty. > What is the rationale/motivation for the changes in this patch series? > Why is pytest better than nose2? Could you send a new iteration with a > detailed commit log for each commit that explains the motivation for > the change, and also describes the change itself, especially in PATCH > 2/3, where test cases see changes. BTW, these changes in test cases > could be done in a separate preparation commit, as they would still > work with nose2 I believe. > > Also another concern is that the series is not really bisectable, but > admittedly I'm not sure it's easy to achieve without doing all the > changes in one single patch. > > Best regards, > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com >
diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile index f54c31b54a..fd1527b1f9 100644 --- a/support/docker/Dockerfile +++ b/support/docker/Dockerfile @@ -38,8 +38,8 @@ RUN apt-get install -y --no-install-recommends \ mercurial \ openssh-server \ python3 \ + python3-pip \ python3-flake8 \ - python3-nose2 \ python3-pexpect \ python3-pytest \ qemu-system-arm \ @@ -53,6 +53,9 @@ RUN apt-get install -y --no-install-recommends \ apt-get -y autoremove && \ apt-get -y clean +# To be able to run tests in parallel +RUN pip install pytest-parallel + # To be able to generate a toolchain with locales, enable one UTF-8 locale RUN sed -i 's/# \(en_US.UTF-8\)/\1/' /etc/locale.gen && \ /usr/sbin/locale-gen
Signed-off-by: Oguz Ozhan <oguz.ozhan@mind.be> --- support/docker/Dockerfile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)