diff mbox series

[1/1] package/ola: ftdidmx needs gcc >= 4.9

Message ID 20220813084659.696492-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/ola: ftdidmx needs gcc >= 4.9 | expand

Commit Message

Fabrice Fontaine Aug. 13, 2022, 8:46 a.m. UTC
Fix the following build failure raised since re-introduction of the
package in commit 16ff948444c3978d63f483344a3d92d994c64312:

Makefile:575: *** libusb is in the dependency chain of libftdi1 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.

Fixes:
 - http://autobuild.buildroot.org/results/f65baf4dd4c9a313745cdb9aefad2eae7a295469

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ola/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Yann E. MORIN Aug. 14, 2022, 8:56 p.m. UTC | #1
Fabrice, All,

On 2022-08-13 10:46 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since re-introduction of the
> package in commit 16ff948444c3978d63f483344a3d92d994c64312:
> 
> Makefile:575: *** libusb is in the dependency chain of libftdi1 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/f65baf4dd4c9a313745cdb9aefad2eae7a295469
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/ola/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/ola/Config.in b/package/ola/Config.in
> index cfca09a936..701083b5d3 100644
> --- a/package/ola/Config.in
> +++ b/package/ola/Config.in
> @@ -86,10 +86,14 @@ config BR2_PACKAGE_OLA_PLUGIN_ESPNET
>  
>  config BR2_PACKAGE_OLA_PLUGIN_FTDIDMX
>  	bool "ftdidmx"
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libftdi1 -> libusb
>  	select BR2_PACKAGE_LIBFTDI1
>  	help
>  	  Build FTDI USB DMX plugin for OLA.
>  
> +comment "ftdidmx needs a toolchain w/ gcc >= 4.9"
> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +
>  config BR2_PACKAGE_OLA_PLUGIN_GPIO
>  	bool "GPIO"
>  	help
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard Sept. 16, 2022, 10:13 a.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure raised since re-introduction of the
 > package in commit 16ff948444c3978d63f483344a3d92d994c64312:

 > Makefile:575: *** libusb is in the dependency chain of libftdi1 that
 > has added it to its _DEPENDENCIES variable without selecting it or
 > depending on it from Config.in.  Stop.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/f65baf4dd4c9a313745cdb9aefad2eae7a295469

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.05.x, thanks.
diff mbox series

Patch

diff --git a/package/ola/Config.in b/package/ola/Config.in
index cfca09a936..701083b5d3 100644
--- a/package/ola/Config.in
+++ b/package/ola/Config.in
@@ -86,10 +86,14 @@  config BR2_PACKAGE_OLA_PLUGIN_ESPNET
 
 config BR2_PACKAGE_OLA_PLUGIN_FTDIDMX
 	bool "ftdidmx"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libftdi1 -> libusb
 	select BR2_PACKAGE_LIBFTDI1
 	help
 	  Build FTDI USB DMX plugin for OLA.
 
+comment "ftdidmx needs a toolchain w/ gcc >= 4.9"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+
 config BR2_PACKAGE_OLA_PLUGIN_GPIO
 	bool "GPIO"
 	help