| Message ID | 20220807222529.1501004-3-giulio.benetti@benettiengineering.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Fix Opencv4 bug found by a user in Mailing list | expand |
On Mon, 8 Aug 2022 00:25:29 +0200 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > Opencv4 library objdetect needs library dnn, otherwise it throws: > ``` > -- Module opencv_objdetect disabled because opencv_dnn dependency can't be resolved! > ``` > So let's "select BR2_PACKAGE_OPENCV4_LIB_DNN" if > BR2_PACKAGE_OPENCV4_LIB_OBJDETECT is enabled. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/opencv4/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/opencv4/Config.in b/package/opencv4/Config.in > index bdeddcc089..4991b4252b 100644 > --- a/package/opencv4/Config.in > +++ b/package/opencv4/Config.in > @@ -155,6 +155,7 @@ config BR2_PACKAGE_OPENCV4_LIB_OBJDETECT > select BR2_PACKAGE_OPENCV4_LIB_CALIB3D > select BR2_PACKAGE_OPENCV4_LIB_IMGPROC > select BR2_PACKAGE_OPENCV4_LIB_ML > + select BR2_PACKAGE_OPENCV4_LIB_DNN Alphabetic ordering was not correct, and it also lacked the propagation of the "depends on" of select BR2_PACKAGE_OPENCV4_LIB_DNN. The final patch is at: https://git.buildroot.org/buildroot/commit/?id=e229943785534e0884c62c7346a8c6df8d565e1e Best regards, Thomas
> Il giorno 15 ago 2022, alle ore 14:35, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto: > > On Mon, 8 Aug 2022 00:25:29 +0200 > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > >> Opencv4 library objdetect needs library dnn, otherwise it throws: >> ``` >> -- Module opencv_objdetect disabled because opencv_dnn dependency can't be resolved! >> ``` >> So let's "select BR2_PACKAGE_OPENCV4_LIB_DNN" if >> BR2_PACKAGE_OPENCV4_LIB_OBJDETECT is enabled. >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> package/opencv4/Config.in | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/package/opencv4/Config.in b/package/opencv4/Config.in >> index bdeddcc089..4991b4252b 100644 >> --- a/package/opencv4/Config.in >> +++ b/package/opencv4/Config.in >> @@ -155,6 +155,7 @@ config BR2_PACKAGE_OPENCV4_LIB_OBJDETECT >> select BR2_PACKAGE_OPENCV4_LIB_CALIB3D >> select BR2_PACKAGE_OPENCV4_LIB_IMGPROC >> select BR2_PACKAGE_OPENCV4_LIB_ML >> + select BR2_PACKAGE_OPENCV4_LIB_DNN > > Alphabetic ordering was not correct, and it also lacked the propagation > of the "depends on" of select BR2_PACKAGE_OPENCV4_LIB_DNN. Oh no, again the dependencies in Config.in! I still keep forgetting them :-/ > > The final patch is at: > > https://git.buildroot.org/buildroot/commit/?id=e229943785534e0884c62c7346a8c6df8d565e1e Thank you Thomas, you’re too kind. Best regards Giulio > > Best regards, > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes: > Opencv4 library objdetect needs library dnn, otherwise it throws: > ``` > -- Module opencv_objdetect disabled because opencv_dnn dependency can't be resolved! > ``` > So let's "select BR2_PACKAGE_OPENCV4_LIB_DNN" if > BR2_PACKAGE_OPENCV4_LIB_OBJDETECT is enabled. > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Committed to 2022.05.x and 2022.02.x, thanks.
diff --git a/package/opencv4/Config.in b/package/opencv4/Config.in index bdeddcc089..4991b4252b 100644 --- a/package/opencv4/Config.in +++ b/package/opencv4/Config.in @@ -155,6 +155,7 @@ config BR2_PACKAGE_OPENCV4_LIB_OBJDETECT select BR2_PACKAGE_OPENCV4_LIB_CALIB3D select BR2_PACKAGE_OPENCV4_LIB_IMGPROC select BR2_PACKAGE_OPENCV4_LIB_ML + select BR2_PACKAGE_OPENCV4_LIB_DNN help Include opencv_objdetect (object detection) module into the OpenCV build.
Opencv4 library objdetect needs library dnn, otherwise it throws: ``` -- Module opencv_objdetect disabled because opencv_dnn dependency can't be resolved! ``` So let's "select BR2_PACKAGE_OPENCV4_LIB_DNN" if BR2_PACKAGE_OPENCV4_LIB_OBJDETECT is enabled. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/opencv4/Config.in | 1 + 1 file changed, 1 insertion(+)