| Message ID | 20220729204457.7266-1-giulio.benetti@benettiengineering.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | toolchain/Config.in: improve gcc bug 43744 condition | expand |
Giulio, All, On 2022-07-29 22:44 +0200, Giulio Benetti spake thusly: > This makes the condition easier to read and it's easier to maintain the > gcc bug too because we don't have to take care about new gcc versions. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Series of two patches applied to master, thanks. Regards, Yann E. MORIN. > --- > toolchain/Config.in | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/toolchain/Config.in b/toolchain/Config.in > index 3cc747c1cc..d2fc347d36 100644 > --- a/toolchain/Config.in > +++ b/toolchain/Config.in > @@ -113,12 +113,9 @@ config BR2_TOOLCHAIN_SUPPORTS_VARIADIC_MI_THUNK > # reappeared on gcc 9.x and is still not fixed on gcc 11.x > config BR2_TOOLCHAIN_HAS_GCC_BUG_43744 > bool > - default y if BR2_sh4 > - depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \ > - BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \ > - BR2_TOOLCHAIN_GCC_AT_LEAST_10 || \ > - BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \ > - BR2_TOOLCHAIN_GCC_AT_LEAST_12 > + default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8 > + default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 > + depends on BR2_sh4 > > # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no > # longer exists in gcc 8.x. > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/toolchain/Config.in b/toolchain/Config.in index 3cc747c1cc..d2fc347d36 100644 --- a/toolchain/Config.in +++ b/toolchain/Config.in @@ -113,12 +113,9 @@ config BR2_TOOLCHAIN_SUPPORTS_VARIADIC_MI_THUNK # reappeared on gcc 9.x and is still not fixed on gcc 11.x config BR2_TOOLCHAIN_HAS_GCC_BUG_43744 bool - default y if BR2_sh4 - depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \ - BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \ - BR2_TOOLCHAIN_GCC_AT_LEAST_10 || \ - BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \ - BR2_TOOLCHAIN_GCC_AT_LEAST_12 + default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8 + default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 + depends on BR2_sh4 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no # longer exists in gcc 8.x.
This makes the condition easier to read and it's easier to maintain the gcc bug too because we don't have to take care about new gcc versions. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- toolchain/Config.in | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)