diff mbox series

[1/1] package/wilc-driver: fix kconfig syntax

Message ID 20220715211041.7902-1-kris@embeddedTS.com
State Accepted
Headers show
Series [1/1] package/wilc-driver: fix kconfig syntax | expand

Commit Message

Kris Bahnsen July 15, 2022, 9:10 p.m. UTC
Sub-options SPI and SDIO weren't rendering as nested options for
wilc-driver, instead showing on the same indent level. Move the
comment and depends on to bottom of file to correct this.

Fixes: 1a47c42b33 ("package/wilc-driver: add missing BR2_LINUX_KERNEL dependency")
Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
---
 package/wilc-driver/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Yann E. MORIN July 16, 2022, 10:08 p.m. UTC | #1
Kris, All,

On 2022-07-15 14:10 -0700, Kris Bahnsen via buildroot spake thusly:
> Sub-options SPI and SDIO weren't rendering as nested options for
> wilc-driver, instead showing on the same indent level. Move the
> comment and depends on to bottom of file to correct this.
> 
> Fixes: 1a47c42b33 ("package/wilc-driver: add missing BR2_LINUX_KERNEL dependency")
> Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/wilc-driver/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in
> index 24a7b05b17..7ed062bb66 100644
> --- a/package/wilc-driver/Config.in
> +++ b/package/wilc-driver/Config.in
> @@ -17,9 +17,6 @@ config BR2_PACKAGE_WILC_DRIVER
>  
>  	  https://github.com/embeddedTS/wilc3000-external-module
>  
> -comment "wilc kernel module needs a Linux kernel to be built"
> -	depends on !BR2_LINUX_KERNEL
> -
>  if BR2_PACKAGE_WILC_DRIVER
>  
>  config BR2_PACKAGE_WILC_DRIVER_SPI
> @@ -60,3 +57,6 @@ config BR2_PACKAGE_WILC_DRIVER_SDIO_OOB
>  	  time division interrupt.
>  endif
>  endif
> +
> +comment "wilc kernel module needs a Linux kernel to be built"
> +	depends on !BR2_LINUX_KERNEL
> -- 
> 2.11.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard Aug. 4, 2022, 3:05 p.m. UTC | #2
>>>>> "Kris" == Kris Bahnsen via buildroot <buildroot@buildroot.org> writes:

 > Sub-options SPI and SDIO weren't rendering as nested options for
 > wilc-driver, instead showing on the same indent level. Move the
 > comment and depends on to bottom of file to correct this.

 > Fixes: 1a47c42b33 ("package/wilc-driver: add missing BR2_LINUX_KERNEL dependency")
 > Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>

Committed to 2022.05.x, thanks.
diff mbox series

Patch

diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in
index 24a7b05b17..7ed062bb66 100644
--- a/package/wilc-driver/Config.in
+++ b/package/wilc-driver/Config.in
@@ -17,9 +17,6 @@  config BR2_PACKAGE_WILC_DRIVER
 
 	  https://github.com/embeddedTS/wilc3000-external-module
 
-comment "wilc kernel module needs a Linux kernel to be built"
-	depends on !BR2_LINUX_KERNEL
-
 if BR2_PACKAGE_WILC_DRIVER
 
 config BR2_PACKAGE_WILC_DRIVER_SPI
@@ -60,3 +57,6 @@  config BR2_PACKAGE_WILC_DRIVER_SDIO_OOB
 	  time division interrupt.
 endif
 endif
+
+comment "wilc kernel module needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL