| Message ID | 20220618060641.24736-1-huth@tuxfamily.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/kvm-unit-tests: Completely disable the tests on big endian ARM | expand |
On 18/06/2022 08:06, Thomas Huth wrote: > Though the code compiles with a big endian toolchain, the kvm-unit-tests > do not work at all in big endian mode on ARM. Until someone steps up to > fix this, disable the package completely on big endian ARM targets. > > Signed-off-by: Thomas Huth <huth@tuxfamily.org> Applied to master, thanks. Regards, Arnout > --- > package/kvm-unit-tests/Config.in | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/package/kvm-unit-tests/Config.in b/package/kvm-unit-tests/Config.in > index 2b797e13b4..7658877ce9 100644 > --- a/package/kvm-unit-tests/Config.in > +++ b/package/kvm-unit-tests/Config.in > @@ -1,12 +1,13 @@ > config BR2_PACKAGE_KVM_UNIT_TESTS_ARCH_SUPPORTS > bool > - # On ARM, it uses virtualization extensions > - default y if BR2_cortex_a7 || BR2_cortex_a12 || \ > + # On ARM, it needs virtualization extensions and little endian CPUs > + default y if (BR2_arm || BR2_aarch64) && \ > + (BR2_cortex_a7 || BR2_cortex_a12 || \ > BR2_cortex_a15 || BR2_cortex_a15_a7 || \ > BR2_cortex_a17 || BR2_cortex_a17_a7 || \ > BR2_cortex_a55 || BR2_cortex_a75 || \ > BR2_cortex_a75_a55 || BR2_cortex_a76 || \ > - BR2_cortex_a76_a55 > + BR2_cortex_a76_a55) > default y if BR2_i386 || BR2_x86_64 > default y if BR2_powerpc64 || BR2_powerpc64le > default y if BR2_s390x
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes: > On 18/06/2022 08:06, Thomas Huth wrote: >> Though the code compiles with a big endian toolchain, the kvm-unit-tests >> do not work at all in big endian mode on ARM. Until someone steps up to >> fix this, disable the package completely on big endian ARM targets. >> Signed-off-by: Thomas Huth <huth@tuxfamily.org> > Applied to master, thanks. Committed to 2022.05.x, thanks.
diff --git a/package/kvm-unit-tests/Config.in b/package/kvm-unit-tests/Config.in index 2b797e13b4..7658877ce9 100644 --- a/package/kvm-unit-tests/Config.in +++ b/package/kvm-unit-tests/Config.in @@ -1,12 +1,13 @@ config BR2_PACKAGE_KVM_UNIT_TESTS_ARCH_SUPPORTS bool - # On ARM, it uses virtualization extensions - default y if BR2_cortex_a7 || BR2_cortex_a12 || \ + # On ARM, it needs virtualization extensions and little endian CPUs + default y if (BR2_arm || BR2_aarch64) && \ + (BR2_cortex_a7 || BR2_cortex_a12 || \ BR2_cortex_a15 || BR2_cortex_a15_a7 || \ BR2_cortex_a17 || BR2_cortex_a17_a7 || \ BR2_cortex_a55 || BR2_cortex_a75 || \ BR2_cortex_a75_a55 || BR2_cortex_a76 || \ - BR2_cortex_a76_a55 + BR2_cortex_a76_a55) default y if BR2_i386 || BR2_x86_64 default y if BR2_powerpc64 || BR2_powerpc64le default y if BR2_s390x
Though the code compiles with a big endian toolchain, the kvm-unit-tests do not work at all in big endian mode on ARM. Until someone steps up to fix this, disable the package completely on big endian ARM targets. Signed-off-by: Thomas Huth <huth@tuxfamily.org> --- package/kvm-unit-tests/Config.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)