diff mbox series

[1/1] package/linux-tools: perf needs dynamic library

Message ID 20220605155910.1927906-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/linux-tools: perf needs dynamic library | expand

Commit Message

Fabrice Fontaine June 5, 2022, 3:59 p.m. UTC
traceevent needs dynamic library since its addition in kernel 3.14 and
https://github.com/torvalds/linux/commit/c877bbd8eceb14c5eac6779cc804fa8b34044736:

event-plugin.c:10:10: fatal error: dlfcn.h: No such file or directory
   10 | #include <dlfcn.h>
      |          ^~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/24206071721479a6ba4d0267e7e20ef9498e1e05

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/linux-tools/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Yann E. MORIN June 5, 2022, 7:41 p.m. UTC | #1
Fabrice, All,

On 2022-06-05 17:59 +0200, Fabrice Fontaine spake thusly:
> traceevent needs dynamic library since its addition in kernel 3.14 and
> https://github.com/torvalds/linux/commit/c877bbd8eceb14c5eac6779cc804fa8b34044736:
> 
> event-plugin.c:10:10: fatal error: dlfcn.h: No such file or directory
>    10 | #include <dlfcn.h>
>       |          ^~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/24206071721479a6ba4d0267e7e20ef9498e1e05
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/linux-tools/Config.in | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in
> index 6217fcfb7a..131380cb02 100644
> --- a/package/linux-tools/Config.in
> +++ b/package/linux-tools/Config.in
> @@ -50,6 +50,7 @@ config BR2_PACKAGE_LINUX_TOOLS_PCI
>  config BR2_PACKAGE_LINUX_TOOLS_PERF
>  	bool "perf"
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
> +	depends on !BR2_STATIC_LIBS # dlfcn.h
>  	select BR2_PACKAGE_LINUX_TOOLS
>  	help
>  	  perf (sometimes "Perf Events" or perf tools, originally
> @@ -69,6 +70,10 @@ config BR2_PACKAGE_LINUX_TOOLS_PERF
>  
>  	  https://perf.wiki.kernel.org/
>  
> +comment "perf needs a toolchain w/ dynamic library"
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
> +	depends on BR2_STATIC_LIBS
> +
>  if BR2_PACKAGE_LINUX_TOOLS_PERF
>  
>  config BR2_PACKAGE_LINUX_TOOLS_PERF_TUI
> -- 
> 2.35.1
>
Peter Korsgaard June 9, 2022, 7:21 a.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > traceevent needs dynamic library since its addition in kernel 3.14 and
 > https://github.com/torvalds/linux/commit/c877bbd8eceb14c5eac6779cc804fa8b34044736:

 > event-plugin.c:10:10: fatal error: dlfcn.h: No such file or directory
 >    10 | #include <dlfcn.h>
 >       |          ^~~~~~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/24206071721479a6ba4d0267e7e20ef9498e1e05

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.
diff mbox series

Patch

diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in
index 6217fcfb7a..131380cb02 100644
--- a/package/linux-tools/Config.in
+++ b/package/linux-tools/Config.in
@@ -50,6 +50,7 @@  config BR2_PACKAGE_LINUX_TOOLS_PCI
 config BR2_PACKAGE_LINUX_TOOLS_PERF
 	bool "perf"
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on !BR2_STATIC_LIBS # dlfcn.h
 	select BR2_PACKAGE_LINUX_TOOLS
 	help
 	  perf (sometimes "Perf Events" or perf tools, originally
@@ -69,6 +70,10 @@  config BR2_PACKAGE_LINUX_TOOLS_PERF
 
 	  https://perf.wiki.kernel.org/
 
+comment "perf needs a toolchain w/ dynamic library"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on BR2_STATIC_LIBS
+
 if BR2_PACKAGE_LINUX_TOOLS_PERF
 
 config BR2_PACKAGE_LINUX_TOOLS_PERF_TUI