| Message ID | 20220527204250.1748549-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/pcsc-lite: needs gcc >= 4.9 | expand |
On 2022-05-27 22:42 +0200, Fabrice Fontaine spake thusly: > gcc >= 4.9 is needed since bump to version 1.9.6 in commit > b02f13cd54912f3dffd0e0863378050104430d77 and > https://github.com/LudovicRousseau/PCSC/commit/d56ed18dbebc4423506ce7f61d3e3bcf4bdc4cb0: > > In file included from winscard_clnt.c:123:0: > readerfactory.h:101:3: error: unknown type name '_Atomic' > _Atomic DWORD dwEventStatus; /**< Recent event that must be sent */ > ^ > > Fixes: > - http://autobuild.buildroot.org/results/189f030a2252f17abf8b819feec0003815c66e79 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- [--SNIP--] > index ead61e4529..3686f570a9 100644 > --- a/package/libnfc/Config.in > +++ b/package/libnfc/Config.in > @@ -13,13 +13,15 @@ config BR2_PACKAGE_LIBNFC_ACR122_PCSC > depends on BR2_TOOLCHAIN_HAS_THREADS # pcsc-lite > depends on BR2_USE_MMU # pcsc-lite > depends on !BR2_STATIC_LIBS # pcsc-lite > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite libnfc in turn is selected by libfreefare, libllcp, libpam-nfc, and mfoc. This new gcc dependency must be propagated to those packages. Fortunately, none of those packages have reverse dependencies that select them, so it's a one-level-deep chain. Can you respin, please? Regards, Yann E. MORIN. > select BR2_PACKAGE_PCSC_LITE > help > support for acr112_pcsc driver > > -comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library" > +comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library, gcc >= 4.9" > depends on BR2_USE_MMU > - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS > + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \ > + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > > config BR2_PACKAGE_LIBNFC_ACR122_USB > bool "acr122_usb driver" > diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in > index 1b4d0f7d18..f4ed5ba2f0 100644 > --- a/package/pcsc-lite/Config.in > +++ b/package/pcsc-lite/Config.in > @@ -3,6 +3,7 @@ config BR2_PACKAGE_PCSC_LITE > depends on BR2_TOOLCHAIN_HAS_THREADS > depends on BR2_USE_MMU # fork() > depends on !BR2_STATIC_LIBS > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # _Atomic keyword > help > Middleware to access smart card using SCard API (PC/SC). > > @@ -33,6 +34,7 @@ config BR2_PACKAGE_PCSC_LITE_EMBEDDED > > endif > > -comment "pcsc-lite needs a toolchain w/ threads, dynamic library" > +comment "pcsc-lite needs a toolchain w/ threads, dynamic library, gcc >= 4.9" > depends on BR2_USE_MMU > - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS > + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \ > + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in > index 430625a102..919ce1f5bc 100644 > --- a/package/strongswan/Config.in > +++ b/package/strongswan/Config.in > @@ -108,9 +108,13 @@ config BR2_PACKAGE_STRONGSWAN_EAP_SIM_FILE > config BR2_PACKAGE_STRONGSWAN_EAP_SIM_PCSC > bool "Enable EAP-SIM smart card backend" > depends on !BR2_STATIC_LIBS # pcsc-lite > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite > select BR2_PACKAGE_PCSC_LITE > select BR2_PACKAGE_STRONGSWAN_EAP_SIM > > +comment "EAP-SIM smart backend needs a toolchain w/ dynamic library, gcc >= 4.9" > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > + > config BR2_PACKAGE_STRONGSWAN_EAP_AKA > bool "Enable EAP-AKA" > default y if BR2_PACKAGE_STRONGSWAN_EAP # legacy > -- > 2.35.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Le sam. 28 mai 2022 à 21:00, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > On 2022-05-27 22:42 +0200, Fabrice Fontaine spake thusly: > > gcc >= 4.9 is needed since bump to version 1.9.6 in commit > > b02f13cd54912f3dffd0e0863378050104430d77 and > > https://github.com/LudovicRousseau/PCSC/commit/d56ed18dbebc4423506ce7f61d3e3bcf4bdc4cb0: > > > > In file included from winscard_clnt.c:123:0: > > readerfactory.h:101:3: error: unknown type name '_Atomic' > > _Atomic DWORD dwEventStatus; /**< Recent event that must be sent */ > > ^ > > > > Fixes: > > - http://autobuild.buildroot.org/results/189f030a2252f17abf8b819feec0003815c66e79 > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > [--SNIP--] > > index ead61e4529..3686f570a9 100644 > > --- a/package/libnfc/Config.in > > +++ b/package/libnfc/Config.in > > @@ -13,13 +13,15 @@ config BR2_PACKAGE_LIBNFC_ACR122_PCSC > > depends on BR2_TOOLCHAIN_HAS_THREADS # pcsc-lite > > depends on BR2_USE_MMU # pcsc-lite > > depends on !BR2_STATIC_LIBS # pcsc-lite > > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite > > libnfc in turn is selected by libfreefare, libllcp, libpam-nfc, and > mfoc. This new gcc dependency must be propagated to those packages. pcsc-lite is only needed by libnfc's acr122_pcsc driver and no package is selecting BR2_PACKAGE_LIBNFC_ACR122_PCSC. > > Fortunately, none of those packages have reverse dependencies that > select them, so it's a one-level-deep chain. > > Can you respin, please? As explained above, IMHO no update is needed on this patch. > > Regards, > Yann E. MORIN. > > > select BR2_PACKAGE_PCSC_LITE > > help > > support for acr112_pcsc driver > > > > -comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library" > > +comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library, gcc >= 4.9" > > depends on BR2_USE_MMU > > - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS > > + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \ > > + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > > > > config BR2_PACKAGE_LIBNFC_ACR122_USB > > bool "acr122_usb driver" > > diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in > > index 1b4d0f7d18..f4ed5ba2f0 100644 > > --- a/package/pcsc-lite/Config.in > > +++ b/package/pcsc-lite/Config.in > > @@ -3,6 +3,7 @@ config BR2_PACKAGE_PCSC_LITE > > depends on BR2_TOOLCHAIN_HAS_THREADS > > depends on BR2_USE_MMU # fork() > > depends on !BR2_STATIC_LIBS > > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # _Atomic keyword > > help > > Middleware to access smart card using SCard API (PC/SC). > > > > @@ -33,6 +34,7 @@ config BR2_PACKAGE_PCSC_LITE_EMBEDDED > > > > endif > > > > -comment "pcsc-lite needs a toolchain w/ threads, dynamic library" > > +comment "pcsc-lite needs a toolchain w/ threads, dynamic library, gcc >= 4.9" > > depends on BR2_USE_MMU > > - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS > > + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \ > > + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > > diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in > > index 430625a102..919ce1f5bc 100644 > > --- a/package/strongswan/Config.in > > +++ b/package/strongswan/Config.in > > @@ -108,9 +108,13 @@ config BR2_PACKAGE_STRONGSWAN_EAP_SIM_FILE > > config BR2_PACKAGE_STRONGSWAN_EAP_SIM_PCSC > > bool "Enable EAP-SIM smart card backend" > > depends on !BR2_STATIC_LIBS # pcsc-lite > > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite > > select BR2_PACKAGE_PCSC_LITE > > select BR2_PACKAGE_STRONGSWAN_EAP_SIM > > > > +comment "EAP-SIM smart backend needs a toolchain w/ dynamic library, gcc >= 4.9" > > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > > + > > config BR2_PACKAGE_STRONGSWAN_EAP_AKA > > bool "Enable EAP-AKA" > > default y if BR2_PACKAGE_STRONGSWAN_EAP # legacy > > -- > > 2.35.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' Best Regards, Fabrice
Fabrice, All, On 2022-05-28 22:23 +0200, Fabrice Fontaine spake thusly: > Le sam. 28 mai 2022 à 21:00, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > On 2022-05-27 22:42 +0200, Fabrice Fontaine spake thusly: > > > gcc >= 4.9 is needed since bump to version 1.9.6 in commit > > > b02f13cd54912f3dffd0e0863378050104430d77 and > > > https://github.com/LudovicRousseau/PCSC/commit/d56ed18dbebc4423506ce7f61d3e3bcf4bdc4cb0: > > > > > > In file included from winscard_clnt.c:123:0: > > > readerfactory.h:101:3: error: unknown type name '_Atomic' > > > _Atomic DWORD dwEventStatus; /**< Recent event that must be sent */ > > > ^ > > > > > > Fixes: > > > - http://autobuild.buildroot.org/results/189f030a2252f17abf8b819feec0003815c66e79 > > > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > > --- > > [--SNIP--] > > > index ead61e4529..3686f570a9 100644 > > > --- a/package/libnfc/Config.in > > > +++ b/package/libnfc/Config.in > > > @@ -13,13 +13,15 @@ config BR2_PACKAGE_LIBNFC_ACR122_PCSC > > > depends on BR2_TOOLCHAIN_HAS_THREADS # pcsc-lite > > > depends on BR2_USE_MMU # pcsc-lite > > > depends on !BR2_STATIC_LIBS # pcsc-lite > > > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite > > > > libnfc in turn is selected by libfreefare, libllcp, libpam-nfc, and > > mfoc. This new gcc dependency must be propagated to those packages. > pcsc-lite is only needed by libnfc's acr122_pcsc driver and no package > is selecting BR2_PACKAGE_LIBNFC_ACR122_PCSC. Indeed, my bad. Applied to master, thanks. Regards, Yann E. MORIN. > > Fortunately, none of those packages have reverse dependencies that > > select them, so it's a one-level-deep chain. > > > > Can you respin, please? > > As explained above, IMHO no update is needed on this patch. > > > > > Regards, > > Yann E. MORIN. > > > > > select BR2_PACKAGE_PCSC_LITE > > > help > > > support for acr112_pcsc driver > > > > > > -comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library" > > > +comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library, gcc >= 4.9" > > > depends on BR2_USE_MMU > > > - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS > > > + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \ > > > + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > > > > > > config BR2_PACKAGE_LIBNFC_ACR122_USB > > > bool "acr122_usb driver" > > > diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in > > > index 1b4d0f7d18..f4ed5ba2f0 100644 > > > --- a/package/pcsc-lite/Config.in > > > +++ b/package/pcsc-lite/Config.in > > > @@ -3,6 +3,7 @@ config BR2_PACKAGE_PCSC_LITE > > > depends on BR2_TOOLCHAIN_HAS_THREADS > > > depends on BR2_USE_MMU # fork() > > > depends on !BR2_STATIC_LIBS > > > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # _Atomic keyword > > > help > > > Middleware to access smart card using SCard API (PC/SC). > > > > > > @@ -33,6 +34,7 @@ config BR2_PACKAGE_PCSC_LITE_EMBEDDED > > > > > > endif > > > > > > -comment "pcsc-lite needs a toolchain w/ threads, dynamic library" > > > +comment "pcsc-lite needs a toolchain w/ threads, dynamic library, gcc >= 4.9" > > > depends on BR2_USE_MMU > > > - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS > > > + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \ > > > + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > > > diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in > > > index 430625a102..919ce1f5bc 100644 > > > --- a/package/strongswan/Config.in > > > +++ b/package/strongswan/Config.in > > > @@ -108,9 +108,13 @@ config BR2_PACKAGE_STRONGSWAN_EAP_SIM_FILE > > > config BR2_PACKAGE_STRONGSWAN_EAP_SIM_PCSC > > > bool "Enable EAP-SIM smart card backend" > > > depends on !BR2_STATIC_LIBS # pcsc-lite > > > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite > > > select BR2_PACKAGE_PCSC_LITE > > > select BR2_PACKAGE_STRONGSWAN_EAP_SIM > > > > > > +comment "EAP-SIM smart backend needs a toolchain w/ dynamic library, gcc >= 4.9" > > > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > > > + > > > config BR2_PACKAGE_STRONGSWAN_EAP_AKA > > > bool "Enable EAP-AKA" > > > default y if BR2_PACKAGE_STRONGSWAN_EAP # legacy > > > -- > > > 2.35.1 > > > > > > _______________________________________________ > > > buildroot mailing list > > > buildroot@buildroot.org > > > https://lists.buildroot.org/mailman/listinfo/buildroot > > > > -- > > .-----------------.--------------------.------------------.--------------------. > > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > > '------------------------------^-------^------------------^--------------------' > > Best Regards, > > Fabrice > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/acsccid/Config.in b/package/acsccid/Config.in index a926be6e16..2d644ea567 100644 --- a/package/acsccid/Config.in +++ b/package/acsccid/Config.in @@ -1,7 +1,7 @@ config BR2_PACKAGE_ACSCCID bool "acsccid" depends on BR2_TOOLCHAIN_HAS_THREADS # pcsc-lite, libusb - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb, pcsc-lite depends on BR2_USE_MMU # pcsc-lite depends on !BR2_STATIC_LIBS # pcsc-lite select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE diff --git a/package/ccid/Config.in b/package/ccid/Config.in index aae5a7181c..c12733375b 100644 --- a/package/ccid/Config.in +++ b/package/ccid/Config.in @@ -1,7 +1,7 @@ config BR2_PACKAGE_CCID bool "ccid" depends on BR2_TOOLCHAIN_HAS_THREADS # libusb - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb, pcsc-lite depends on BR2_USE_MMU # pcsc-lite depends on !BR2_STATIC_LIBS # pcsc-lite select BR2_PACKAGE_PCSC_LITE diff --git a/package/libnfc/Config.in b/package/libnfc/Config.in index ead61e4529..3686f570a9 100644 --- a/package/libnfc/Config.in +++ b/package/libnfc/Config.in @@ -13,13 +13,15 @@ config BR2_PACKAGE_LIBNFC_ACR122_PCSC depends on BR2_TOOLCHAIN_HAS_THREADS # pcsc-lite depends on BR2_USE_MMU # pcsc-lite depends on !BR2_STATIC_LIBS # pcsc-lite + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite select BR2_PACKAGE_PCSC_LITE help support for acr112_pcsc driver -comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library" +comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library, gcc >= 4.9" depends on BR2_USE_MMU - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 config BR2_PACKAGE_LIBNFC_ACR122_USB bool "acr122_usb driver" diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in index 1b4d0f7d18..f4ed5ba2f0 100644 --- a/package/pcsc-lite/Config.in +++ b/package/pcsc-lite/Config.in @@ -3,6 +3,7 @@ config BR2_PACKAGE_PCSC_LITE depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU # fork() depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # _Atomic keyword help Middleware to access smart card using SCard API (PC/SC). @@ -33,6 +34,7 @@ config BR2_PACKAGE_PCSC_LITE_EMBEDDED endif -comment "pcsc-lite needs a toolchain w/ threads, dynamic library" +comment "pcsc-lite needs a toolchain w/ threads, dynamic library, gcc >= 4.9" depends on BR2_USE_MMU - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in index 430625a102..919ce1f5bc 100644 --- a/package/strongswan/Config.in +++ b/package/strongswan/Config.in @@ -108,9 +108,13 @@ config BR2_PACKAGE_STRONGSWAN_EAP_SIM_FILE config BR2_PACKAGE_STRONGSWAN_EAP_SIM_PCSC bool "Enable EAP-SIM smart card backend" depends on !BR2_STATIC_LIBS # pcsc-lite + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite select BR2_PACKAGE_PCSC_LITE select BR2_PACKAGE_STRONGSWAN_EAP_SIM +comment "EAP-SIM smart backend needs a toolchain w/ dynamic library, gcc >= 4.9" + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 + config BR2_PACKAGE_STRONGSWAN_EAP_AKA bool "Enable EAP-AKA" default y if BR2_PACKAGE_STRONGSWAN_EAP # legacy
gcc >= 4.9 is needed since bump to version 1.9.6 in commit b02f13cd54912f3dffd0e0863378050104430d77 and https://github.com/LudovicRousseau/PCSC/commit/d56ed18dbebc4423506ce7f61d3e3bcf4bdc4cb0: In file included from winscard_clnt.c:123:0: readerfactory.h:101:3: error: unknown type name '_Atomic' _Atomic DWORD dwEventStatus; /**< Recent event that must be sent */ ^ Fixes: - http://autobuild.buildroot.org/results/189f030a2252f17abf8b819feec0003815c66e79 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/acsccid/Config.in | 2 +- package/ccid/Config.in | 2 +- package/libnfc/Config.in | 6 ++++-- package/pcsc-lite/Config.in | 6 ++++-- package/strongswan/Config.in | 4 ++++ 5 files changed, 14 insertions(+), 6 deletions(-)